Mixin deprecation support

Author: wagenet

packages/@ember/-internals/utils/lib/mixin-deprecation.ts

@@ -0,0 +1,42 @@
+import type { DeprecationOptions } from '@ember/debug';
+import type Mixin from '@ember/object/mixin';
+
+/** @internal */
+export const DEPRECATION = Symbol('DEPRECATION');
+
+/** @internal */
+export function setDeprecation(
+  mixin: Mixin,
+  value: { message: string; options: DeprecationOptions } | null
+) {
+  mixin[DEPRECATION] = value;
+}
+
+let deprecationsEnabled = true;
+
+export function findDeprecation(
+  mixin: Mixin
+): { message: string; options: DeprecationOptions } | null {
+  if (!deprecationsEnabled) {
+    return null;
+  }
+  if (mixin[DEPRECATION]) {
+    return mixin[DEPRECATION];
+  }
+  for (let childMixin of mixin.mixins ?? []) {
+    let deprecation = findDeprecation(childMixin);
+    if (deprecation) {
+      return deprecation;
+    }
+  }
+  return null;
+}
+
+export function disableDeprecations<T>(callback: () => T): T {
+  try {
+    deprecationsEnabled = false;
+    return callback();
+  } finally {
+    deprecationsEnabled = true;
+  }
+}

packages/@ember/object/mixin.ts

@@ -29,6 +29,7 @@ import {
   defineDecorator,
   defineValue,
 } from '@ember/-internals/metal';
+import { DEPRECATION, findDeprecation } from '@ember/-internals/utils/lib/mixin-deprecation';
 
 const a_concat = Array.prototype.concat;
 const { isArray } = Array;
@@ -545,21 +546,7 @@ export default class Mixin {
   properties: { [key: string]: any } | undefined;
 
   /*** @internal */
-  deprecation: { message: string; options: DeprecationOptions } | undefined;
-
-  /** @internal */
-  findDeprecation(): { message: string; options: DeprecationOptions } | null {
-    if (this.deprecation) {
-      return this.deprecation;
-    }
-    for (let mixin of this.mixins ?? []) {
-      let deprecation = mixin.findDeprecation();
-      if (deprecation) {
-        return deprecation;
-      }
-    }
-    return null;
-  }
+  [DEPRECATION]: { message: string; options: DeprecationOptions } | null = null;
 
   /** @internal */
   ownerConstructor: any;
@@ -641,7 +628,7 @@ export default class Mixin {
 
     if (DEBUG) {
       for (let mixin of args) {
-        let deprecation = mixin instanceof Mixin ? mixin.findDeprecation() : null;
+        let deprecation = mixin instanceof Mixin ? findDeprecation(mixin) : null;
         deprecate(deprecation?.message ?? 'Huh???', !deprecation, deprecation?.options);
       }
     }