Skip to content

Commit 2319116

Browse files
committed
Deprecate @ember/object/events
1 parent 96c1137 commit 2319116

File tree

3 files changed

+42
-3
lines changed

3 files changed

+42
-3
lines changed

packages/@ember/-internals/glimmer/tests/integration/components/life-cycle-test.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ import { A as emberA } from '@ember/array';
1313
import { getViewElement, getViewId } from '@ember/-internals/views';
1414

1515
import { Component } from '../../utils/helpers';
16-
import { addListener } from '@ember/object/events';
16+
import { addListener } from '@ember/-internals/metal';
1717

1818
class LifeCycleHooksTest extends RenderingTestCase {
1919
constructor() {

packages/@ember/object/events.ts

Lines changed: 39 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1,39 @@
1-
export { addListener, removeListener, sendEvent } from '@ember/-internals/metal';
1+
import {
2+
addListener as originalAddListener,
3+
removeListener as originalRemoveListener,
4+
sendEvent as originalSendEvent,
5+
} from '@ember/-internals/metal';
6+
import { deprecateFunc } from '@ember/debug';
7+
8+
export const addListener = deprecateFunc(
9+
'`addListener is deprecated',
10+
{
11+
for: 'ember-source',
12+
id: 'ember-object-add-listener',
13+
since: { available: '6.8.0' },
14+
until: '7.0.0',
15+
},
16+
originalAddListener
17+
);
18+
19+
export const removeListener = deprecateFunc(
20+
'`removeListener is deprecated',
21+
{
22+
for: 'ember-source',
23+
id: 'ember-object-remove-listener',
24+
since: { available: '6.8.0' },
25+
until: '7.0.0',
26+
},
27+
originalRemoveListener
28+
);
29+
30+
export const sendEvent = deprecateFunc(
31+
'`sendEvent is deprecated',
32+
{
33+
for: 'ember-source',
34+
id: 'ember-object-send-event',
35+
since: { available: '6.8.0' },
36+
until: '7.0.0',
37+
},
38+
originalSendEvent
39+
);

packages/@ember/object/mixin.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,8 @@ import {
1414
type ComputedPropertySetter,
1515
type ComputedDescriptor,
1616
isClassicDecorator,
17+
addListener,
18+
removeListener,
1719
} from '@ember/-internals/metal';
1820
import {
1921
ComputedProperty,
@@ -27,7 +29,6 @@ import {
2729
defineDecorator,
2830
defineValue,
2931
} from '@ember/-internals/metal';
30-
import { addListener, removeListener } from '@ember/object/events';
3132

3233
const a_concat = Array.prototype.concat;
3334
const { isArray } = Array;

0 commit comments

Comments
 (0)