fix: Remove ember-cli-string-helpers (#1672)

MichalBryxi · web-flow · commit cd2bdc2319ef · 2025-05-03T06:06:55.000-07:00
* fix: Remove ember-cli-string-helpers - This pulls @ember/string 3.1.1 into dependent project and that causes a lot of issues - Since we have `capitalize` in @ember/string, we can just call that in our internal helper - Also bumped internal version of @ember/string to v4.x Fixes #1666 * fix: ember-tether & testing issues - As per [ember-tether documentation](https://github.com/yapplabs/ember-tether) in testing mode we have to make sure that the portal is attached to correct DOM scope > Tether works by appending tethered elements to the <body> tag. Unfortunately, this moves your content outside of the Ember application rootElement during acceptance testing. This breaks event dispatch and action handling, including traditional Ember test helpers like click. This fixes all tests that fail because search popup can't be find.
diff --git a/addon/helpers/capitalize.js b/addon/helpers/capitalize.js
@@ -0,0 +1,6 @@
+import { helper } from '@ember/component/helper';
+import { capitalize } from '@ember/string';
+
+export default helper(function capitalizeHelper(positional) {
+  return capitalize(positional[0]);
+});
diff --git a/app/helpers/capitalize.js b/app/helpers/capitalize.js
@@ -0,0 +1 @@
+export { default } from 'ember-cli-addon-docs/helpers/capitalize';
diff --git a/package.json b/package.json
@@ -53,7 +53,6 @@
     "ember-cli-clipboard": "^1.2.1",
     "ember-cli-htmlbars": "^6.3.0",
     "ember-cli-postcss": "^8.2.0",
-    "ember-cli-string-helpers": "^6.1.0",
     "ember-cli-string-utils": "^1.1.0",
     "ember-cli-version-checker": "^5.1.2",
     "ember-code-snippet": "^3.0.0",
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/tests/dummy/config/environment.js b/tests/dummy/config/environment.js
@@ -39,6 +39,10 @@ module.exports = function (environment) {
 
     ENV.APP.rootElement = '#ember-testing';
     ENV.APP.autoboot = false;
+
+    ENV['ember-tether'] = {
+      bodyElementId: 'ember-testing',
+    };
   }
 
   if (environment === 'production') {
diff --git a/tests/integration/helpers/capitalize-test.js b/tests/integration/helpers/capitalize-test.js
@@ -0,0 +1,18 @@
+import { module, test } from 'qunit';
+import { setupRenderingTest } from 'dummy/tests/helpers';
+import { render } from '@ember/test-helpers';
+import { hbs } from 'ember-cli-htmlbars';
+import { capitalize } from '@ember/string';
+
+module('Integration | Helper | capitalize', function (hooks) {
+  setupRenderingTest(hooks);
+
+  test('it renders', async function (assert) {
+    const testString = 'abc 123 ABC !@# Foo Bar';
+    this.set('inputValue', testString);
+
+    await render(hbs`{{capitalize this.inputValue}}`);
+
+    assert.dom().hasText(capitalize(testString));
+  });
+});

Original file line number	Diff line number	Diff line change
`@@ -0,0 +1 @@`
	`1`	`+export { default } from 'ember-cli-addon-docs/helpers/capitalize';`
Original file line number	Diff line number	Diff line change
`@@ -39,6 +39,10 @@ module.exports = function (environment) {`
`39`	`39`
`40`	`40`	`ENV.APP.rootElement = '#ember-testing';`
`41`	`41`	`ENV.APP.autoboot = false;`
	`42`	`+`
	`43`	`+ ENV['ember-tether'] = {`
	`44`	`+ bodyElementId: 'ember-testing',`
	`45`	`+ };`
`42`	`46`	`}`
`43`	`47`
`44`	`48`	`if (environment === 'production') {`