Skip to content

Commit ea1ee50

Browse files
committed
Tidy up tests
1 parent 9413bb3 commit ea1ee50

File tree

4 files changed

+8
-31
lines changed

4 files changed

+8
-31
lines changed

src/test/kotlin/com/embabel/guide/TestApplicationContext.kt

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -15,26 +15,10 @@
1515
*/
1616
package com.embabel.guide
1717

18-
import com.embabel.GuideApplication
19-
import org.springframework.boot.test.context.TestConfiguration
2018
import org.springframework.context.ApplicationContextInitializer
2119
import org.springframework.context.ConfigurableApplicationContext
22-
import org.springframework.context.annotation.Import
2320
import org.springframework.core.env.MapPropertySource
2421

25-
/**
26-
* Shared test configuration for all tests.
27-
*
28-
* Controls whether tests use local Neo4j or Testcontainers:
29-
* - Set useLocalNeo4j = true to use local Neo4j at localhost:7687
30-
* - Set useLocalNeo4j = false to use Testcontainers (slower, but isolated)
31-
*
32-
* Imports GuideApplication to enable full component scanning.
33-
*/
34-
@TestConfiguration
35-
@Import(GuideApplication::class)
36-
class TestApplicationContext
37-
3822
/**
3923
* Initializer that configures Neo4j properties before Spring context starts.
4024
* Add to test classes with: @ContextConfiguration(initializers = [Neo4jPropertiesInitializer::class])

src/test/kotlin/com/embabel/guide/domain/GuideUserServiceTest.kt

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -16,22 +16,16 @@
1616
package com.embabel.guide.domain
1717

1818
import com.embabel.guide.Neo4jPropertiesInitializer
19-
import com.embabel.guide.Neo4jTestContainer
20-
import com.embabel.guide.TestApplicationContext
2119
import org.junit.jupiter.api.Assertions.*
2220
import org.junit.jupiter.api.Test
2321
import org.springframework.ai.mcp.client.autoconfigure.McpClientAutoConfiguration
2422
import org.springframework.beans.factory.annotation.Autowired
2523
import org.springframework.boot.autoconfigure.ImportAutoConfiguration
2624
import org.springframework.boot.test.context.SpringBootTest
27-
import org.springframework.test.annotation.Rollback
2825
import org.springframework.test.context.ContextConfiguration
29-
import org.springframework.test.context.DynamicPropertyRegistry
30-
import org.springframework.test.context.DynamicPropertySource
3126

32-
@SpringBootTest(classes = [TestApplicationContext::class])
27+
@SpringBootTest
3328
@ContextConfiguration(initializers = [Neo4jPropertiesInitializer::class])
34-
@Rollback(false)
3529
@ImportAutoConfiguration(exclude = [McpClientAutoConfiguration::class])
3630
class GuideUserServiceTest {
3731

src/test/kotlin/com/embabel/hub/HubApiControllerTest.kt

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
package com.embabel.hub
22

3-
import com.embabel.guide.TestApplicationContext
3+
import com.embabel.guide.Neo4jPropertiesInitializer
44
import com.embabel.guide.domain.GuideUserRepository
55
import com.fasterxml.jackson.databind.ObjectMapper
66
import org.junit.jupiter.api.Assertions.*
@@ -20,9 +20,7 @@ import org.springframework.test.web.servlet.request.MockMvcRequestBuilders.post
2020
import org.springframework.test.web.servlet.result.MockMvcResultMatchers.*
2121

2222
@SpringBootTest
23-
@AutoConfigureMockMvc
24-
@ContextConfiguration(classes = [TestApplicationContext::class])
25-
@Rollback(false)
23+
@ContextConfiguration(initializers = [Neo4jPropertiesInitializer::class])
2624
@ImportAutoConfiguration(exclude = [McpClientAutoConfiguration::class])
2725
class HubApiControllerTest {
2826

src/test/kotlin/com/embabel/hub/HubServiceTest.kt

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,17 +1,18 @@
11
package com.embabel.hub
22

3-
import com.embabel.guide.TestApplicationContext
3+
import com.embabel.guide.Neo4jPropertiesInitializer
44
import org.junit.jupiter.api.Assertions.*
55
import org.junit.jupiter.api.Test
6+
import org.springframework.ai.mcp.client.autoconfigure.McpClientAutoConfiguration
67
import org.springframework.beans.factory.annotation.Autowired
8+
import org.springframework.boot.autoconfigure.ImportAutoConfiguration
79
import org.springframework.boot.test.context.SpringBootTest
810
import org.springframework.security.crypto.bcrypt.BCryptPasswordEncoder
9-
import org.springframework.test.annotation.Rollback
1011
import org.springframework.test.context.ContextConfiguration
1112

1213
@SpringBootTest
13-
@ContextConfiguration(classes = [TestApplicationContext::class])
14-
@Rollback(false)
14+
@ContextConfiguration(initializers = [Neo4jPropertiesInitializer::class])
15+
@ImportAutoConfiguration(exclude = [McpClientAutoConfiguration::class])
1516
class HubServiceTest {
1617

1718
@Autowired

0 commit comments

Comments
 (0)