Skip to content

Commit 207f93c

Browse files
authored
fix: Compile warnings (#768)
1 parent 4e379b4 commit 207f93c

File tree

5 files changed

+220
-218
lines changed

5 files changed

+220
-218
lines changed

Eask

+3-3
Original file line numberDiff line numberDiff line change
@@ -16,12 +16,12 @@
1616

1717
(depends-on "emacs" "27.1")
1818
(depends-on "dash")
19-
(depends-on "flycheck")
2019
(depends-on "lsp-mode")
2120
(depends-on "markdown-mode")
22-
(depends-on "rustic")
2321

2422
(development
25-
(depends-on "ert-runner"))
23+
(depends-on "ert-runner")
24+
(depends-on "rustic")
25+
(depends-on "flycheck"))
2626

2727
(setq network-security-level 'low) ; see https://github.com/jcs090218/setup-emacs-windows/issues/156#issuecomment-932956432

lsp-ui-doc.el

+35-35
Original file line numberDiff line numberDiff line change
@@ -100,7 +100,7 @@ This affects the position of the documentation when
100100

101101
(defcustom lsp-ui-doc-alignment 'frame
102102
"How to align the doc.
103-
This only takes effect when `lsp-ui-doc-position' is 'top or 'bottom."
103+
This only takes effect when `lsp-ui-doc-position' is `top or `bottom."
104104
:type '(choice (const :tag "Frame" frame)
105105
(const :tag "Window" window))
106106
:group 'lsp-ui-doc)
@@ -182,31 +182,31 @@ Only the `background' is used in this face."
182182
:group 'lsp-ui-doc)
183183

184184
(defvar lsp-ui-doc-frame-parameters
185-
'((left . -1)
186-
(no-focus-on-map . t)
187-
(min-width . 0)
188-
(width . 0)
189-
(min-height . 0)
190-
(height . 0)
191-
(internal-border-width . 1)
192-
(vertical-scroll-bars . nil)
193-
(horizontal-scroll-bars . nil)
194-
(right-fringe . 0)
195-
(menu-bar-lines . 0)
196-
(tool-bar-lines . 0)
197-
(tab-bar-lines . 0)
185+
'((left . -1)
186+
(no-focus-on-map . t)
187+
(min-width . 0)
188+
(width . 0)
189+
(min-height . 0)
190+
(height . 0)
191+
(internal-border-width . 1)
192+
(vertical-scroll-bars . nil)
193+
(horizontal-scroll-bars . nil)
194+
(right-fringe . 0)
195+
(menu-bar-lines . 0)
196+
(tool-bar-lines . 0)
197+
(tab-bar-lines . 0)
198198
(tab-bar-lines-keep-state . 0)
199-
(line-spacing . 0)
200-
(unsplittable . t)
201-
(undecorated . t)
202-
(top . -1)
203-
(visibility . nil)
204-
(mouse-wheel-frame . nil)
205-
(no-other-frame . t)
199+
(line-spacing . 0)
200+
(unsplittable . t)
201+
(undecorated . t)
202+
(top . -1)
203+
(visibility . nil)
204+
(mouse-wheel-frame . nil)
205+
(no-other-frame . t)
206206
(inhibit-double-buffering . t)
207-
(drag-internal-border . t)
208-
(no-special-glyphs . t)
209-
(desktop-dont-save . t))
207+
(drag-internal-border . t)
208+
(no-special-glyphs . t)
209+
(desktop-dont-save . t))
210210
"Frame parameters used to create the frame.")
211211

212212
(defvar lsp-ui-doc-render-function nil
@@ -248,7 +248,8 @@ Because some variables are buffer local.")
248248
"Non-nil when the current document should ask to hide after next command.")
249249

250250

251-
(defconst lsp-ui-doc--buffer-prefix " *lsp-ui-doc-")
251+
(defconst lsp-ui-doc--buffer-prefix " *lsp-ui-doc-"
252+
"LSP UI doc prefix.")
252253

253254
(defmacro lsp-ui-doc--with-buffer (&rest body)
254255
"Execute BODY in the lsp-ui-doc buffer."
@@ -260,7 +261,6 @@ Because some variables are buffer local.")
260261
(setq lsp-ui-doc--parent-vars parent-vars)
261262
(prog1 (let ((buffer-read-only nil)
262263
(inhibit-modification-hooks t)
263-
(inhibit-point-motion-hooks t)
264264
(inhibit-redisplay t))
265265
,@body)
266266
(setq buffer-read-only t)
@@ -904,15 +904,15 @@ HEIGHT is the documentation number of lines."
904904
(run-hook-with-args 'lsp-ui-doc-frame-hook frame window)
905905
(when lsp-ui-doc-use-webkit
906906
(define-key (current-global-map) [xwidget-event]
907-
(lambda ()
908-
(interactive)
909-
(let ((xwidget-event-type (nth 1 last-input-event)))
910-
;; (when (eq xwidget-event-type 'load-changed)
911-
;; (lsp-ui-doc--move-frame (lsp-ui-doc--get-frame)))
912-
(when (eq xwidget-event-type 'javascript-callback)
913-
(let ((proc (nth 3 last-input-event))
914-
(arg (nth 4 last-input-event)))
915-
(funcall proc arg))))))
907+
(lambda ()
908+
(interactive)
909+
(let ((xwidget-event-type (nth 1 last-input-event)))
910+
;; (when (eq xwidget-event-type 'load-changed)
911+
;; (lsp-ui-doc--move-frame (lsp-ui-doc--get-frame)))
912+
(when (eq xwidget-event-type 'javascript-callback)
913+
(let ((proc (nth 3 last-input-event))
914+
(arg (nth 4 last-input-event)))
915+
(funcall proc arg))))))
916916
(lsp-ui-doc--webkit-run-xwidget))
917917
frame))
918918

0 commit comments

Comments
 (0)