Defers tenant event handling for reliability

Ensures tenant events like module activation and workflow schedule creation are executed within a shell scope, improving reliability.

Adds a startup task to populate registries asynchronously.

Renames "Elsa" module to "Elsa Workflows" for clarity.

Author: sfmskywalker

src/modules/OrchardCore.Elsa.Timers/Common/CreateSchedules.cs

@@ -4,6 +4,7 @@
 using Elsa.Workflows.Runtime.Filters;
 using JetBrains.Annotations;
 using Microsoft.Extensions.DependencyInjection;
+using OrchardCore.Environment.Shell.Scope;
 using OrchardCore.Modules;
 
 namespace OrchardCore.Elsa.Timers.Common;
@@ -14,15 +15,19 @@ namespace OrchardCore.Elsa.Timers.Common;
 [UsedImplicitly]
 public class CreateSchedules(IServiceScopeFactory scopeFactory) : ModularTenantEvents
 {
-    public override async Task ActivatedAsync()
+    public override Task ActivatedAsync()
     {
-        using var scope = scopeFactory.CreateScope();
-        var serviceProvider = scope.ServiceProvider;
-        var (triggers, bookmarks) = await GetTriggersAndBookmarksAsync(serviceProvider);
-        var triggerScheduler = serviceProvider.GetRequiredService<ITriggerScheduler>();
-        var bookmarkScheduler = serviceProvider.GetRequiredService<IBookmarkScheduler>();
-        await triggerScheduler.ScheduleAsync(triggers);
-        await bookmarkScheduler.ScheduleAsync(bookmarks);
+        ShellScope.AddDeferredTask(async scope =>
+        {
+            using var serviceScope = scopeFactory.CreateScope();
+            var serviceProvider = serviceScope.ServiceProvider;
+            var (triggers, bookmarks) = await GetTriggersAndBookmarksAsync(serviceProvider);
+            var triggerScheduler = serviceProvider.GetRequiredService<ITriggerScheduler>();
+            var bookmarkScheduler = serviceProvider.GetRequiredService<IBookmarkScheduler>();
+            await triggerScheduler.ScheduleAsync(triggers);
+            await bookmarkScheduler.ScheduleAsync(bookmarks);
+        });
+        return Task.CompletedTask;
     }
 
     public override async Task TerminatingAsync()

src/modules/OrchardCore.Elsa.Timers/Quartz/RegisterJobs.cs

@@ -2,6 +2,7 @@
 using Elsa.Scheduling.Quartz.Jobs;
 using JetBrains.Annotations;
 using Microsoft.Extensions.DependencyInjection;
+using OrchardCore.Environment.Shell.Scope;
 using OrchardCore.Modules;
 using Quartz;
 using QuartzIScheduler = Quartz.IScheduler;
@@ -14,11 +15,15 @@ namespace OrchardCore.Elsa.Timers.Quartz;
 [UsedImplicitly]
 internal class RegisterJobs(ISchedulerFactory schedulerFactoryFactory, IServiceScopeFactory scopeFactory) : ModularTenantEvents
 {
-    public override async Task ActivatingAsync()
+    public override Task ActivatingAsync()
     {
-        var scheduler = await schedulerFactoryFactory.GetScheduler();
-        await CreateJobAsync<RunWorkflowJob>(scheduler);
-        await CreateJobAsync<ResumeWorkflowJob>(scheduler);
+        ShellScope.AddDeferredTask(async scope =>
+        {
+            var scheduler = await schedulerFactoryFactory.GetScheduler();
+            await CreateJobAsync<RunWorkflowJob>(scheduler);
+            await CreateJobAsync<ResumeWorkflowJob>(scheduler);
+        });
+        return Task.CompletedTask;
     }
 
     private async Task CreateJobAsync<TJobType>(QuartzIScheduler scheduler, CancellationToken cancellationToken = default) where TJobType : IJob

src/modules/OrchardCore.Elsa/Manifest.cs

@@ -10,8 +10,8 @@
 
 [assembly: Feature(
     Id = "OrchardCore.Elsa",
-    Name = "Elsa",
-    Description = "Provides foundational Elsa services.",
+    Name = "Elsa Workflows",
+    Description = "Provides foundational Elsa Workflows services.",
     Category = "Elsa",
     Dependencies = ["OrchardCore.Contents", OpenIdConstants.Features.Core]
 )]

src/modules/OrchardCore.Elsa/StartupTasks/PopulateRegistriesTask.cs

@@ -1,12 +1,19 @@
 using Elsa.Workflows.Runtime;
+using Microsoft.Extensions.DependencyInjection;
+using OrchardCore.Environment.Shell.Scope;
 using OrchardCore.Modules;
 
 namespace OrchardCore.Elsa.StartupTasks;
 
-public class PopulateRegistriesTask(IRegistriesPopulator registriesPopulator) : ModularTenantEvents
+public class PopulateRegistriesTask : ModularTenantEvents
 {
-    public override async Task ActivatedAsync()
+    public override Task ActivatedAsync()
     {
-        await registriesPopulator.PopulateAsync();
+        ShellScope.AddDeferredTask(async scope =>
+        {
+            var registriesPopulator = scope.ServiceProvider.GetRequiredService<IRegistriesPopulator>();
+            await registriesPopulator.PopulateAsync();
+        });
+        return Task.CompletedTask;
     }
 }