Fix bug when the client sends multiple contentChanges at once #1131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am not sure whether this would have any noticeable performance impact, especially since most editors will send this notification on every keystroke? |
…multiple content changes at once. On a textDocument/didChange notification, if the contentChanges contain multiple entries, each of them needs to be handled as if all previous changes were already applied. When we don't, the calculation of the change's byte offsets will be wrong, which can lead to a syntax tree that produces parsing errors where the actual file does not have any issues. To solve this, we now apply the text of each change record to the full file text and use the result when applying the next change of the contentChanges array.
Also, only update the document text with each change when it's required, i.e. when there's more than one contentChange.
razzeee
force-pushed
the
fix-multiple-content-changes
branch
from
4d4b69a to
e9da3a2
Compare
|
Necro'ing the thread to say thank you for this patch! I updated from 2.7.1 to 2.8.0 and the LSP doesn't seem to be getting it wrong anymore. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On a textDocument/didChange notification, if the contentChanges contain multiple entries, each of them needs to be handled as if all previous changes were already applied. When we don't, the calculation of the change's byte offsets will be wrong, which can lead to a syntax tree that produces parsing errors where the actual file does not have any issues.
To solve this, we now apply the text of each change record to the full file text and use the result when applying the next change of the contentChanges array.
I think this will fix #878 (see issue comments for details).