Merge pull request #5848 from elizaOS/fix/core-build-declarations

fix(core): fix TypeScript declarations in npm package

Author: ChristopherTrimboli

bun.lock

@@ -122,39 +122,39 @@ async function buildAll() {
  */
 async function generateTypeScriptDeclarations() {
   const fs = await import('node:fs/promises');
+  const { $ } = await import('bun');
 
-  console.log('📝 Setting up TypeScript declarations...');
+  console.log('📝 Generating TypeScript declarations...');
   const startTime = Date.now();
 
   try {
-    // Since we're including src in the package, we can reference the TypeScript files directly
-    // This ensures types work in the monorepo and when published to NPM
-
-    // Ensure dist directories exist
+    // Generate real TypeScript declarations using tsc
+    console.log('   Compiling TypeScript declarations...');
+    await $`tsc --project tsconfig.declarations.json`;
+    
+    // TypeScript has generated all the .d.ts files in dist/
+    // Now we need to create the conditional export entry points
+    
+    // Ensure directories exist
     await fs.mkdir('dist/node', { recursive: true });
     await fs.mkdir('dist/browser', { recursive: true });
 
-    // Create the main index.d.ts that re-exports from the src folder
-    const mainTypeIndex = `// Type definitions for @elizaos/core
-// Re-exports all types from the Node.js entry point
-export * from '../src/index.node';
-`;
-    await fs.writeFile('dist/index.d.ts', mainTypeIndex);
-
-    // For dist/node/index.d.ts - export from the source
+    // For dist/node/index.d.ts - point to the compiled node types
     const nodeIndexDts = `// Type definitions for @elizaos/core (Node.js)
-// Re-exports all types from the Node.js source entry point
-export * from '../../src/index.node';
+// Re-exports all types from the compiled Node.js declarations
+export * from '../index.node';
 `;
     await fs.writeFile('dist/node/index.d.ts', nodeIndexDts);
 
-    // For dist/browser/index.d.ts - export from the source
+    // For dist/browser/index.d.ts - point to the compiled browser types
     const browserIndexDts = `// Type definitions for @elizaos/core (Browser)
-// Re-exports all types from the Browser source entry point
-export * from '../../src/index.browser';
+// Re-exports all types from the compiled Browser declarations
+export * from '../index.browser';
 `;
     await fs.writeFile('dist/browser/index.d.ts', browserIndexDts);
 
+    // The main index.d.ts is already generated by tsc, we don't need to overwrite it
+
     // Create main index.js for fallback (JavaScript runtime entry)
     const mainIndex = `// Main entry point for @elizaos/core
 // This file is not used directly - package.json conditional exports handle the routing
@@ -164,10 +164,10 @@ export * from './node/index.node.js';
     await fs.writeFile('dist/index.js', mainIndex);
 
     const duration = ((Date.now() - startTime) / 1000).toFixed(2);
-    console.log(`✅ TypeScript declarations setup in ${duration}s`);
-    console.log('   Note: Types are exported directly from the included src folder');
+    console.log(`✅ TypeScript declarations generated in ${duration}s`);
+    console.log('   Note: Using compiled TypeScript declarations (no src/ needed in package)');
   } catch (error) {
-    console.error('❌ Failed to setup TypeScript declarations:', error);
+    console.error('❌ Failed to generate TypeScript declarations:', error);
     throw error;
   }
 }

packages/core/build.ts

@@ -39,8 +39,7 @@
     }
   },
   "files": [
-    "dist",
-    "src"
+    "dist"
   ],
   "scripts": {
     "build": "bun run build.ts",

packages/core/package.json

@@ -1,15 +1,14 @@
 {
-  "extends": "./tsconfig.json",
+  "extends": "../../tsconfig.json",
   "compilerOptions": {
-    "declaration": true,
-    "declarationMap": true,
-    "emitDeclarationOnly": true,
     "outDir": "./dist",
     "rootDir": "./src",
+    "types": ["node", "bun"],
+    "noEmit": false,
+    "emitDeclarationOnly": true,
     "composite": false,
-    "incremental": true,
-    "tsBuildInfoFile": "./dist/.tsbuildinfo"
+    "incremental": false
   },
-  "include": ["src/**/*"],
+  "include": ["src/index.node.ts", "src/index.browser.ts"],
   "exclude": ["src/**/*.test.ts", "src/**/*.spec.ts", "src/__tests__/**/*"]
 }