Skip to content

Commit ded1747

Browse files
author
José Valim
committed
Revert "Merge pull request #778 from alexrp/master"
There is still some discussion pending on this, see #791 This reverts commit f2d4d1e, reversing changes made to c524bcd.
1 parent 6a0a768 commit ded1747

File tree

9 files changed

+21
-36
lines changed

9 files changed

+21
-36
lines changed

lib/elixir/lib/code.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -379,7 +379,7 @@ defmodule Code do
379379
end
380380

381381
defp server_call(args) do
382-
:gen_server.call(:elixir_code_server, args, System.services_timeout)
382+
:gen_server.call(:elixir_code_server, args)
383383
end
384384

385385
defp server_cast(args) do

lib/elixir/lib/kernel/cli.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ defmodule Kernel.CLI do
1212
argv = lc arg inlist argv, do: list_to_binary(arg)
1313

1414
{ config, argv } = process_argv(argv, Kernel.CLI.Config.new)
15-
:gen_server.call(:elixir_code_server, { :argv, argv }, System.services_timeout)
15+
:gen_server.call(:elixir_code_server, { :argv, argv })
1616

1717
run fn ->
1818
Enum.map Enum.reverse(config.commands), process_command(&1, config)
@@ -24,7 +24,7 @@ defmodule Kernel.CLI do
2424
Wait until the CLI finishes procesing options.
2525
"""
2626
def wait_until_finished do
27-
case :gen_server.call(:elixir_code_server, { :wait_until_finished, self }, System.services_timeout) do
27+
case :gen_server.call(:elixir_code_server, { :wait_until_finished, self }) do
2828
:wait ->
2929
receive do
3030
{ :elixir_code_server, :finished } -> :ok
@@ -74,7 +74,7 @@ defmodule Kernel.CLI do
7474
## Private
7575

7676
defp at_exit(status) do
77-
hooks = :gen_server.call(:elixir_code_server, :flush_at_exit, System.services_timeout)
77+
hooks = :gen_server.call(:elixir_code_server, :flush_at_exit)
7878

7979
lc hook inlist hooks do
8080
try do

lib/elixir/lib/system.ex

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@ defmodule System do
5050
"""
5151
@spec argv() :: [String.t]
5252
def argv do
53-
:gen_server.call(:elixir_code_server, :argv, System.services_timeout)
53+
:gen_server.call(:elixir_code_server, :argv)
5454
end
5555

5656
@doc """
@@ -296,14 +296,6 @@ defmodule System do
296296
do_halt(to_char_list(status), options)
297297
end
298298

299-
# services_timeout/0 is an internal function only to be used by Elixir.
300-
301-
@doc false
302-
@spec services_timeout() :: non_neg_integer | :infinity
303-
def services_timeout() do
304-
:elixir_compiler.get_timeout
305-
end
306-
307299
# Support R15B
308300
if List.member?(:erlang.module_info(:exports), { :halt, 2 }) do
309301
defp do_halt(status, options), do: :erlang.halt(status, options)
@@ -315,7 +307,7 @@ defmodule System do
315307
## Helpers
316308

317309
defp server_call(args) do
318-
:gen_server.call(:elixir_code_server, args, System.services_timeout)
310+
:gen_server.call(:elixir_code_server, args)
319311
end
320312

321313
defp filter_stacktrace([{ Kernel, :raise, _, _ }|t]), do: t

lib/elixir/src/elixir_compiler.erl

Lines changed: 5 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
-module(elixir_compiler).
2-
-export([get_opts/0, get_opt/1, get_opt/2, string/2, file/1, file_to_path/2, get_timeout/0]).
2+
-export([get_opts/0, get_opt/1, get_opt/2, string/2, file/1, file_to_path/2]).
33
-export([core/0, module/3, eval_forms/4]).
44
-include("elixir.hrl").
55
-compile({parse_transform, elixir_transform}).
@@ -16,14 +16,8 @@ get_opt(Key, Dict) ->
1616
{ Key, Value } -> Value
1717
end.
1818

19-
get_timeout() ->
20-
case application:get_env(elixir, system_services_timeout) of
21-
{ok, Val} -> Val;
22-
undefined -> 60000
23-
end.
24-
2519
get_opts() ->
26-
gen_server:call(elixir_code_server, compiler_options, get_timeout()).
20+
gen_server:call(elixir_code_server, compiler_options).
2721

2822
%% Compiles the given string.
2923

@@ -113,7 +107,7 @@ module(Forms, File, Options, Bootstrap, Callback) when
113107

114108
core() ->
115109
application:start(elixir),
116-
gen_server:call(elixir_code_server, { compiler_options, [{docs,false},{internal,true}] }, get_timeout()),
110+
gen_server:call(elixir_code_server, { compiler_options, [{docs,false},{internal,true}] }),
117111
[core_file(File) || File <- core_main()].
118112

119113
%% HELPERS
@@ -145,7 +139,7 @@ module_form(Fun, Exprs, Line, File, Module, Vars) when
145139
%% Generate module names from code server.
146140

147141
retrieve_module_name() ->
148-
gen_server:call(elixir_code_server, retrieve_module_name, get_timeout()).
142+
gen_server:call(elixir_code_server, retrieve_module_name).
149143

150144
return_module_name(I) ->
151145
gen_server:cast(elixir_code_server, { return_module_name, I }).
@@ -213,4 +207,4 @@ format_errors(File, Errors) ->
213207
format_warnings(Bootstrap, File, Warnings) ->
214208
lists:foreach(fun ({_, Each}) ->
215209
lists:foreach(fun (Warning) -> elixir_errors:handle_file_warning(Bootstrap, File, Warning) end, Each)
216-
end, Warnings).
210+
end, Warnings).

lib/elixir/test/elixir/gen_server/behaviour_test.exs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,8 +31,8 @@ defmodule GenServer.BehaviourTest do
3131

3232
test :using do
3333
assert { :ok, pid } = :gen_server.start_link(Sample, [:hello], [])
34-
assert :gen_server.call(pid, :pop, System.services_timeout) == :hello
34+
assert :gen_server.call(pid, :pop) == :hello
3535
assert :gen_server.cast(pid, { :push, :world }) == :ok
36-
assert :gen_server.call(pid, :pop, System.services_timeout) == :world
36+
assert :gen_server.call(pid, :pop) == :world
3737
end
3838
end

lib/ex_unit/lib/ex_unit/cli_formatter.ex

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ defmodule ExUnit.CLIFormatter do
1818
end
1919

2020
def suite_finished(id) do
21-
:gen_server.call(id, :suite_finished, System.services_timeout)
21+
:gen_server.call(id, :suite_finished)
2222
end
2323

2424
def case_started(_id, _test_case) do
@@ -113,4 +113,4 @@ defmodule ExUnit.CLIFormatter do
113113
binary
114114
end
115115
end
116-
end
116+
end

lib/ex_unit/lib/ex_unit/server.ex

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ defmodule ExUnit.Server do
3030
## After run API
3131

3232
def options do
33-
:gen_server.call(__MODULE__, :options, System.services_timeout)
33+
:gen_server.call(__MODULE__, :options)
3434
end
3535

3636
def cases do
37-
:gen_server.call(__MODULE__, :cases, System.services_timeout)
37+
:gen_server.call(__MODULE__, :cases)
3838
end
3939

4040
def run_after_spawn do
41-
funs = :gen_server.call(__MODULE__, :after_spawn, System.services_timeout)
41+
funs = :gen_server.call(__MODULE__, :after_spawn)
4242
lc fun inlist funs, do: fun.()
4343
end
4444

lib/mix/lib/mix/server.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@ defmodule Mix.Server do
1212
end
1313

1414
def call(arg) do
15-
:gen_server.call(__MODULE__, arg, System.services_timeout)
15+
:gen_server.call(__MODULE__, arg)
1616
end
1717

1818
def cast(arg) do

src/elixir.app.src

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,6 +6,5 @@
66
]},
77
{registered,[elixir_code_server]},
88
{applications, [kernel,stdlib]},
9-
{mod, {elixir,[]}},
10-
{env, [{system_services_timeout, 60000}]}
11-
]}.
9+
{mod, {elixir,[]}}
10+
]}.

0 commit comments

Comments
 (0)