Skip to content

Commit 5ee492a

Browse files
sh41josevalim
authored andcommitted
Fix coverage threshold ignored for Total line in Summary (#11571)
An incorrect variable is being passed to the `display/2` function on line 353 for the Total line in the coverage summary report. The result is that that Total line will always display in red no matter what the threshold is set to.
1 parent 25e480f commit 5ee492a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

lib/mix/lib/mix/tasks/test.coverage.ex

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -350,7 +350,7 @@ defmodule Mix.Tasks.Test.Coverage do
350350
Mix.shell().info("-----------|--------------------------")
351351
results |> Enum.sort() |> Enum.each(&display(&1, threshold))
352352
Mix.shell().info("-----------|--------------------------")
353-
display({totals, "Total"}, opts)
353+
display({totals, "Total"}, threshold)
354354
Mix.shell().info("")
355355
end
356356

0 commit comments

Comments
 (0)