Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle definition download failures #31

Open
leonardb opened this issue Jun 29, 2023 · 0 comments · Fixed by SiftLogic/ua_inspector#1 · May be fixed by #33
Open

Handle definition download failures #31

leonardb opened this issue Jun 29, 2023 · 0 comments · Fixed by SiftLogic/ua_inspector#1 · May be fixed by #33

Comments

@leonardb
Copy link

downloader.ex
defp download_file hard matches on {:ok, content}

When github goes offline, like it did today, this causes a cascading crash issue with deployed applications where ua_inspector is used as a dependency

Logging failures and not crashing would probably be a better strategy
kyle-neal added a commit to SiftLogic/ua_inspector that referenced this issue Jun 29, 2023
@kyle-neal
(fix) elixir-inspector#31 Don't crash on download failures
83ece73
kyle-neal added a commit to SiftLogic/ua_inspector that referenced this issue Jun 29, 2023
@kyle-neal
(fix) elixir-inspector#31 Don't crash on download failures
ab0bcbb 
(fix) Require Logger
@kyle-neal kyle-neal mentioned this issue Jun 29, 2023
Merged
kyle-neal added a commit to SiftLogic/ua_inspector that referenced this issue Jun 29, 2023
@kyle-neal
(fix) elixir-inspector#31 Don't crash on download failures (#1)
2b25d6b 
(fix) Require Logger
@leonardb leonardb linked a pull request Aug 21, 2023 that will close this issue
Open
leonardb pushed a commit to SiftLogic/ua_inspector that referenced this issue Dec 13, 2023
@kyle-neal @leonardb
(fix) elixir-inspector#31 Don't crash on download failures
2c752a1 
(fix) Require Logger
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@leonardb