Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

loop prevention #484

Open
alexanderkirtzel opened this issue Dec 18, 2024 · 1 comment
Open

loop prevention #484

alexanderkirtzel opened this issue Dec 18, 2024 · 1 comment
Assignees
Labels

Comments

@alexanderkirtzel
Copy link
Collaborator

Is your feature request related to a problem? Please describe.
Using both source and destination from the same type might cause a recursive loop 😱.
E.g. dataLayer source listening for pushes and an active dataLayer destination would be bad.

Describe the solution you'd like
Check for the event.source.type and da destination.type in destinationPush. If it's set and equal, don't process the event.

@alexanderkirtzel
Copy link
Collaborator Author

All dataLayer-related destinations check if the event.source?.type === 'dataLayer' before further processing. This is better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: No status
Development

No branches or pull requests

1 participant