Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for CORS headers #1265

Closed
jsoriano opened this issue Jan 9, 2025 · 0 comments · Fixed by #1266
Closed

Add support for CORS headers #1265

jsoriano opened this issue Jan 9, 2025 · 0 comments · Fixed by #1266
Labels
good first issue Good for newcomers

Comments

@jsoriano
Copy link
Member

jsoriano commented Jan 9, 2025

Without CORS headers, responses from the Package Registry cannot be used in javascript applications running in browsers.

Given that all the Package Registry APIs are public and read-only, we don't really need restricting its cross origin access.

It would be probably fine to always allow any origin:

Access-Control-Allow-Origin: *
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add CORS headers to package registry jsoriano/package-registry
1 participant
@jsoriano