From a52b8308e34c260e4c0aa21e54188192c72af345 Mon Sep 17 00:00:00 2001 From: Cee Chen Date: Fri, 26 Apr 2024 10:28:22 -0700 Subject: [PATCH 1/2] Fix grouped badges not truncating - `truncateText: true` needs to be applied now, was previously relying on old CSS that wasn't good - `textOnly` no longer needs to be passed if `truncateText` is passed so we can skip it, also it makes more sense to do so here since custom badges are being rendered --- .../log_rate_analysis_results_table_groups.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table_groups.tsx b/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table_groups.tsx index aefe170fc4b5b..ca73df59f9068 100644 --- a/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table_groups.tsx +++ b/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table_groups.tsx @@ -254,7 +254,7 @@ export const LogRateAnalysisResultsGroupsTable: FC Date: Fri, 26 Apr 2024 10:30:09 -0700 Subject: [PATCH 2/2] Fix field name icon+name rendering on separate lines - kind of the opposite problem going on here - `textTruncate: true` now always applies an inner `__text` wrapper which messes up the flex behavior - so we need to exclude it and apply text truncation only to the actual text --- .../log_rate_analysis_results_table.tsx | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table.tsx b/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table.tsx index ff683855f6d38..8579d8d1beb25 100644 --- a/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table.tsx +++ b/x-pack/plugins/aiops/public/components/log_rate_analysis_results_table/log_rate_analysis_results_table.tsx @@ -170,12 +170,13 @@ export const LogRateAnalysisResultsTable: FC = )} - {fieldName} + + {fieldName} + ); }, sortable: true, - truncateText: true, valign: 'middle', }, {