Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security:Rules:Detection Rules]Notify Bell button on installed rules table on Detection rules(siem) page is missing accessible discernible text #204483

Closed
bhavyarm opened this issue Dec 16, 2024 · 2 comments · Fixed by #205336
Assignees
Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A

Comments

@bhavyarm
Copy link
Contributor

Description
Notify Bell button on installed rules page on Detection Rules (SIEM) page is missing accessible discernible text.

Preconditions
Security -> Rules->Detection Rules(SIEM) page is open and is populated

Steps to reproduce

  1. Click on Rules ->Detection rules (SIEM) make sure some rules are in installed rules so you can see the table
  2. Run axe-core on the page
  3. Notice the critical a11y violation error for Notify alarm button
Image

Kibana Version: 8.17.0

OS: OX X

Browser: Chrome latest

WCAG or Vendor Guidance (optional)

Guidelines:
Understanding SC 4.1.2: Name, Role, Value (Level A)

Related to: https://github.com/elastic/kibana-team/issues/1280

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-accessibility (Project:Accessibility)

@botelastic botelastic bot added the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm added the Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. label Dec 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-solution (Team: SecuritySolution)

@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm added needs-team Issues missing a team label defect-level-1 Critical UX disruption labels Dec 16, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm added WCAG A needs-team Issues missing a team label labels Dec 16, 2024
@botelastic botelastic bot removed the needs-team Issues missing a team label label Dec 16, 2024
@bhavyarm bhavyarm added the impact:critical This issue should be addressed immediately due to a critical level of impact on the product. label Dec 16, 2024
@alexwizp alexwizp self-assigned this Dec 30, 2024
alexwizp added a commit to alexwizp/kibana that referenced this issue Dec 31, 2024
…rules table on Detection rules(siem) page is missing accessible discernible text

Closes: elastic#204483

Related to: elastic#188075
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 2, 2025
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 6, 2025
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 6, 2025
alexwizp added a commit to alexwizp/kibana that referenced this issue Jan 6, 2025
alexwizp added a commit that referenced this issue Jan 6, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (#205336)

Closes: #204483

Related to: #188075

## Description 

A similar issue was already fixed in
#188075. To address #204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
kibanamachine pushed a commit to kibanamachine/kibana that referenced this issue Jan 6, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
(cherry picked from commit eafa15b)
kibanamachine added a commit that referenced this issue Jan 6, 2025
…alled rules table on Detection rules(siem) page is missing accessible discernible text (#205336) (#205629)

# Backport

This will backport the following commits from `main` to `8.x`:
- [fix: [Security:Rules:Detection Rules]Notify Bell button on installed
rules table on Detection rules(siem) page is missing accessible
discernible text
(#205336)](#205336)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Alexey
Antonov","email":"[email protected]"},"sourceCommit":{"committedDate":"2025-01-06T16:24:20Z","message":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text (#205336)\n\nCloses: #204483\r\n\r\nRelated to:
https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description
\r\n\r\nA similar issue was already fixed
in\r\nhttps://github.com//pull/188075. To address #204483,
we\r\njust need to restore the name from the fetchRulesSnoozeSettings
request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Project:Accessibility","release_note:skip","v9.0.0","Team:
SecuritySolution","backport:prev-minor"],"title":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text","number":205336,"url":"https://github.com/elastic/kibana/pull/205336","mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text (#205336)\n\nCloses: #204483\r\n\r\nRelated to:
https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description
\r\n\r\nA similar issue was already fixed
in\r\nhttps://github.com//pull/188075. To address #204483,
we\r\njust need to restore the name from the fetchRulesSnoozeSettings
request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205336","number":205336,"mergeCommit":{"message":"fix:
[Security:Rules:Detection Rules]Notify Bell button on installed rules
table on Detection rules(siem) page is missing accessible discernible
text (#205336)\n\nCloses: #204483\r\n\r\nRelated to:
https://github.com/elastic/kibana/pull/188075\r\n\r\n## Description
\r\n\r\nA similar issue was already fixed
in\r\nhttps://github.com//pull/188075. To address #204483,
we\r\njust need to restore the name from the fetchRulesSnoozeSettings
request.\r\n\r\n## Screen\r\n\r\n<img width=\"1652\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6\"\r\n/>\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<[email protected]>","sha":"eafa15bba6de05ac4d8071c9bf3c939f3833800b"}}]}]
BACKPORT-->

Co-authored-by: Alexey Antonov <[email protected]>
kowalczyk-krzysztof pushed a commit to kowalczyk-krzysztof/kibana that referenced this issue Jan 7, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description 

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this issue Jan 13, 2025
…rules table on Detection rules(siem) page is missing accessible discernible text (elastic#205336)

Closes: elastic#204483

Related to: elastic#188075

## Description 

A similar issue was already fixed in
elastic#188075. To address elastic#204483, we
just need to restore the name from the fetchRulesSnoozeSettings request.

## Screen

<img width="1652" alt="image"
src="https://github.com/user-attachments/assets/c3f6fcf6-6448-49cb-8e46-e840656417a6"
/>

---------

Co-authored-by: kibanamachine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
defect-level-1 Critical UX disruption impact:critical This issue should be addressed immediately due to a critical level of impact on the product. Project:Accessibility Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. WCAG A
Projects
None yet
3 participants