Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Hide K8S Dashboard on Serverless ONLY #203639

Closed
wants to merge 3 commits into from
Closed

[Cloud Security] Hide K8S Dashboard on Serverless ONLY #203639

wants to merge 3 commits into from
+10 −4

Conversation

animehart
Copy link
Contributor

@animehart animehart commented Dec 10, 2024 •
edited
Loading

Summary

This PR addresses the issue where we only want to hide K8S Dashboard on Serverless. Users now won't be able to access K8S Dashboard via Navigation or Direct URL on Serverless. Users will still be able to do so in a non-serverless env

@animehart animehart added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:Cloud Security Cloud Security team related backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) v8.18.0 labels Dec 10, 2024
@animehart animehart marked this pull request as ready for review December 10, 2024 16:27
@animehart animehart requested review from a team as code owners December 10, 2024 16:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@animehart
Copy link
Contributor Author

/ci

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #78 / Stateful Observability - Deployment-agnostic API integration tests SyntheticsAPITests getSyntheticsMonitors get many monitors without params

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 14.7MB 14.7MB +120.0B

History

opauloh
opauloh approved these changes Dec 13, 2024
View reviewed changes
x-pack/plugins/security_solution/public/kubernetes/routes.tsx

export const KubernetesRoutes = () => (
<PluginTemplateWrapper>
<TrackApplicationView viewId={SecurityPageName.kubernetes}>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't need to track collection anymore with TrackApplicationView, or it is now being handled by the SecurityRoutePageWrapper?

Copy link
Contributor Author

@animehart animehart Dec 13, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

its already included internally :) , had a discussion with @semd

kapral18
kapral18 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@kapral18 kapral18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

semd
semd approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@semd semd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links code LGTM. Everything makes sense.

Just clarify that, using this approach, this link will also be hidden in stateful (non-serverless) environments, when showing the new "solution navigation", which uses the same navigation tree as serverless.

I assume that's acceptable.

@maxcold
Copy link
Contributor

maxcold commented Dec 16, 2024 •
edited
Loading

Users will still be able to do so in a non-serverless env

@animehart I don't understand how this requirement is being achieved, I don't see eny specific serverless/non-serverless code

@animehart
Copy link
Contributor Author

animehart commented Dec 19, 2024 •
edited
Loading

@maxcold solutionAppLinksSwitcher takes classic link and returns serverless link ,I edited that function to filter out K8S Dashboard Link and return serverless link with no K8S dashboard link in it

with that being said, there has been a change on the requirement for this that makes this PR to no longer be valid, I will close this PR

@animehart animehart closed this Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kapral18 kapral18 kapral18 approved these changes

@semd semd semd approved these changes

@opauloh opauloh opauloh approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@animehart @elasticmachine @maxcold @kapral18 @semd @opauloh