Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Serverless][DataUsage] Data usage UX/API updates #203465

Merged
merged 32 commits into from
Dec 12, 2024

Conversation

ashokaditya
Copy link
Member

@ashokaditya ashokaditya commented Dec 9, 2024

Summary

Adds a set of changes that include

  • left align filters
  • show invalid date text
  • updates page subtitle to include 10 day clause
  • switch for selecting/de-selecting system indices (maybe in a new PR)
  • tooltip for data streams filter
  • unit tests
  • filter out system indices from the list of datastream filter options

Screenshot 2024-12-09 at 10 17 58
Screenshot 2024-12-09 at 10 18 22
Screenshot 2024-12-06 at 15 56 29
Screenshot 2024-12-11 at 14 28 48

Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Identify risks

Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.

Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.

@ashokaditya ashokaditya requested review from a team as code owners December 9, 2024 16:08
@ashokaditya ashokaditya self-assigned this Dec 9, 2024
@ashokaditya ashokaditya added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 ci:build-serverless-image backport:version Backport to applied version labels v8.18.0 labels Dec 9, 2024
@ashokaditya ashokaditya force-pushed the task/data-usage-feedback-updates branch from 9a901f6 to 6b3bd72 Compare December 9, 2024 16:10
@ashokaditya ashokaditya requested a review from a team as a code owner December 10, 2024 09:49
@ashokaditya ashokaditya force-pushed the task/data-usage-feedback-updates branch from c6611ce to 32e4a83 Compare December 10, 2024 09:50
@ashokaditya ashokaditya force-pushed the task/data-usage-feedback-updates branch from 32e4a83 to cb2f4c6 Compare December 10, 2024 10:22
This reverts commit 129b861.
@ashokaditya ashokaditya force-pushed the task/data-usage-feedback-updates branch from a95ded3 to 9f71686 Compare December 10, 2024 11:49
@ashokaditya ashokaditya force-pushed the task/data-usage-feedback-updates branch from 1fb38a9 to ee15e45 Compare December 12, 2024 15:19
@ashokaditya ashokaditya changed the title [Serverless][DataUsage] Data usage UX updates [Serverless][DataUsage] Data usage UX/API updates Dec 12, 2024
@ashokaditya ashokaditya force-pushed the task/data-usage-feedback-updates branch from ee15e45 to 52cdefa Compare December 12, 2024 15:50
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

  • Buildkite Build
  • Commit: 4de3bbe
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-203465-4de3bbec2d1c

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataUsage 242.1KB 243.3KB +1.3KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataUsage 7.1KB 7.7KB +572.0B

History

cc @ashokaditya

@ashokaditya ashokaditya merged commit b433119 into elastic:main Dec 12, 2024
9 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12305038887

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 12, 2024
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Dec 12, 2024
…04136)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Serverless][DataUsage] Data usage UX/API updates
(#203465)](#203465)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Ash","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-12T21:24:42Z","message":"[Serverless][DataUsage]
Data usage UX/API updates
(#203465)","sha":"b4331195d68a68774a5f85b3d1dbfdf703c49d34","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:build-serverless-image","backport:version","v8.18.0"],"title":"[Serverless][DataUsage]
Data usage UX/API
updates","number":203465,"url":"https://github.com/elastic/kibana/pull/203465","mergeCommit":{"message":"[Serverless][DataUsage]
Data usage UX/API updates
(#203465)","sha":"b4331195d68a68774a5f85b3d1dbfdf703c49d34"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/203465","number":203465,"mergeCommit":{"message":"[Serverless][DataUsage]
Data usage UX/API updates
(#203465)","sha":"b4331195d68a68774a5f85b3d1dbfdf703c49d34"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Ash <[email protected]>
@ashokaditya ashokaditya deleted the task/data-usage-feedback-updates branch December 13, 2024 09:56
@ashokaditya
Copy link
Member Author

@MadameSheema @consulthys @bfishel I've added you all here for visibility. We made a bunch of changes to accommodate UX issues and a few bugs that were discovered during testing. The next serverless prod release should have these changes.

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Jan 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels ci:build-serverless-image release_note:skip Skip the PR/issue when compiling release notes v8.18.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants