[EUI][APM] Update Hardcoded Colors #203348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-removed hardcoded colors -change to a react hook to allow `useEuiTheme` usage
bryce-b
added
release_note:skip
iblancof
reviewed
Dec 10, 2024
...ity_solution/apm/public/components/app/mobile/service_overview/geo_map/embedded_map.test.tsx
Outdated
Show resolved
Hide resolved
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
MiriamAparicio
requested changes
Dec 10, 2024
x-pack/plugins/observability_solution/apm/public/utils/http_status_code_to_color.ts
Outdated
Show resolved
Hide resolved
…atus_code_to_color.ts Co-authored-by: Miriam <[email protected]>
iblancof
approved these changes
Dec 11, 2024
mgadewoll
requested changes
Dec 12, 2024
...s/observability_solution/apm/public/components/app/mobile/service_overview/geo_map/index.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/observability_solution/apm/public/utils/http_status_code_to_color.ts
Show resolved
Hide resolved
mgadewoll
reviewed
Dec 12, 2024
...lic/components/alerting/ui_components/alert_details_app_section/failed_transaction_chart.tsx
Show resolved
Hide resolved
mgadewoll
approved these changes
Dec 12, 2024
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Jan 13, 2025
## Summary This PR replaces a couple of places where hardcoded colors are used in the APM portion of Kibana with EUITheme colors. Before & After screenshots can be seen in the associated issue, elastic#200960. However, I was unable to find an example for the [.../alert_details_app_section/failed_transaction_chart.tsx](https://github.com/elastic/kibana/pull/203348/files#diff-9d9e4bbfe128f4d2f6ff7f027cf746d679a6c06805ef77240cceb2770a837a28). It seems like this chart in the alert creation flyout will never render with annotations. ### Checklist Check the PR satisfies following conditions. Reviewers should verify this PR satisfies this list as well. - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: Miriam <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR replaces a couple of places where hardcoded colors are used in the APM portion of Kibana with EUITheme colors.
Before & After screenshots can be seen in the associated issue, #200960. However, I was unable to find an example for the .../alert_details_app_section/failed_transaction_chart.tsx. It seems like this chart in the alert creation flyout will never render with annotations.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:*label is applied per the guidelines