Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Stabilize FTR test #202476

Merged
merged 2 commits into from
Dec 3, 2024
Merged

[Lens] Stabilize FTR test #202476

merged 2 commits into from
Dec 3, 2024

Conversation

dej611
Copy link
Contributor

@dej611 dej611 commented Dec 2, 2024 •
edited by kibanamachine
Loading

Summary

Fixes #200120

The navigation bar is not focused for some reason. Making it wait a bit seems to stabilize it.

Checklist

@dej611 dej611 added Team:Visualizations Visualization editors, elastic-charts and infrastructure release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:skip This commit does not require backporting Feature:Functional Testing labels Dec 2, 2024
@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7541

[✅] x-pack/test/functional/apps/lens/group2/config.ts: 100/100 tests passed.

see run history

@dej611 dej611 marked this pull request as ready for review December 3, 2024 08:16
@dej611 dej611 requested a review from a team as a code owner December 3, 2024 08:16
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-visualizations (Team:Visualizations)

mbondyra
mbondyra approved these changes Dec 3, 2024
View reviewed changes
Copy link
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we backport?

@dej611 dej611 added backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) and removed backport:skip This commit does not require backporting labels Dec 3, 2024
@dej611 dej611 merged commit 9df7373 into elastic:main Dec 3, 2024
11 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12142347636

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 202476

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Dec 4, 2024
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202476 locally

hop-dev pushed a commit to hop-dev/kibana that referenced this pull request Dec 5, 2024
@dej611 @hop-dev
[Lens] Stabilize FTR test (elastic#202476)
9663b92 
## Summary

Fixes elastic#200120

The navigation bar is not focused for some reason. Making it wait a bit
seems to stabilize it.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202476 locally

2 similar comments
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202476 locally

@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202476 locally

CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 9, 2024
@dej611 @CAWilson94
[Lens] Stabilize FTR test (elastic#202476)
69d33b1 
## Summary

Fixes elastic#200120

The navigation bar is not focused for some reason. Making it wait a bit
seems to stabilize it.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202476 locally

1 similar comment
@kibanamachine
Copy link
Contributor

Friendly reminder: Looks like this PR hasn’t been backported yet.
To create automatically backports add a backport:* label or prevent reminders by adding the backport:skip label.
You can also create backports manually by running node scripts/backport --pr 202476 locally

@dej611 dej611 mentioned this pull request Dec 12, 2024
Merged
@dej611
Copy link
Contributor Author

dej611 commented Dec 12, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

dej611 added a commit to dej611/kibana that referenced this pull request Dec 12, 2024
@dej611
[Lens] Stabilize FTR test (elastic#202476)
d2780b7 
## Summary

Fixes elastic#200120

The navigation bar is not focused for some reason. Making it wait a bit
seems to stabilize it.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 9df7373)

# Conflicts:
#	x-pack/test/functional/apps/lens/group2/persistent_context.ts
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@dej611 @CAWilson94
[Lens] Stabilize FTR test (elastic#202476)
cae6463 
## Summary

Fixes elastic#200120

The navigation bar is not focused for some reason. Making it wait a bit
seems to stabilize it.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
@kibanamachine
Copy link
Contributor

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

dej611 added a commit that referenced this pull request Dec 13, 2024
@dej611 @kibanamachine
[8.x] [Lens] Stabilize FTR test (#202476) (#203970)
17a7b59 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] Stabilize FTR test
(#202476)](#202476)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Marco
Liberati","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-12-03T15:00:31Z","message":"[Lens]
Stabilize FTR test (#202476)\n\n## Summary\r\n\r\nFixes
#200120\r\n\r\nThe navigation bar is not focused for some reason. Making
it wait a bit\r\nseems to stabilize it.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9df737384642b57dc059e854be1236721f1a9bb3","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","backport
missing","Feature:Functional
Testing","v9.0.0","backport:prev-minor"],"number":202476,"url":"https://github.com/elastic/kibana/pull/202476","mergeCommit":{"message":"[Lens]
Stabilize FTR test (#202476)\n\n## Summary\r\n\r\nFixes
#200120\r\n\r\nThe navigation bar is not focused for some reason. Making
it wait a bit\r\nseems to stabilize it.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9df737384642b57dc059e854be1236721f1a9bb3"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202476","number":202476,"mergeCommit":{"message":"[Lens]
Stabilize FTR test (#202476)\n\n## Summary\r\n\r\nFixes
#200120\r\n\r\nThe navigation bar is not focused for some reason. Making
it wait a bit\r\nseems to stabilize it.\r\n\r\n### Checklist\r\n\r\n-
[x] [Unit or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common
scenarios","sha":"9df737384642b57dc059e854be1236721f1a9bb3"}}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <[email protected]>
@kibanamachine kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees
No one assigned
Labels
backport:prev-minor Backport to (9.0) the previous minor version (i.e. one version back from main) Feature:Functional Testing Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Visualization editors, elastic-charts and infrastructure v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
4 participants
@dej611 @kibanamachine @elasticmachine @mbondyra