You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment, within Kibana there exists multiple markdown implementations across the app; we have the legacy markdown component that leverages the package markdown-it which adheres to the commonmark spec then there's the markdown component provided by the shared UX team which is built on top of the Markdown component provided by EUI team which aims to adhere to the Github flavor markdown spec (referred to from here on as GfM), see elastic/eui#5272 (review).
There are also multiple occurrences of the direct usages of the eui markdown component too across the codebase, all of this unfortunately leads to a lack of coherence with the markdown style across the app especially that the eui markdown component, being built on top of remark (basically a text processor) allows any direct usage of the EUI markdown component the addition of any plugin of choice which could in turn further diversify the markdown styles Kibana supports.
This became very evident, with the attempt to migrate parts of the codebase to the shared UX component, we had reports of in consistencies in rendering expectations. See #180576
Proposal;
Adopt the GfM markdown flavour within Kibana, and exclusively support only this flavour.
On deciding what the flavour to adopt (GfM), the shared UX team will provide a component that supports this decided on implementation provided for adoption (leveraging the Markdown component provided by the EUI team), with tests put in place to validate how markdown renders happen so that any future change to this is caught something along the lines of Reference for markdown implementation in kibana #180926 should be sufficient.
All parts of kibana will be migrated to the aforementioned component, guard rails should also be put in place to enforce that only this implementation is what is used across the app.
The text was updated successfully, but these errors were encountered:
Describe the feature:
At the moment, within Kibana there exists multiple markdown implementations across the app; we have the legacy markdown component that leverages the package markdown-it which adheres to the commonmark spec then there's the markdown component provided by the shared UX team which is built on top of the Markdown component provided by EUI team which aims to adhere to the Github flavor markdown spec (referred to from here on as GfM), see elastic/eui#5272 (review).
There are also multiple occurrences of the direct usages of the eui markdown component too across the codebase, all of this unfortunately leads to a lack of coherence with the markdown style across the app especially that the eui markdown component, being built on top of remark (basically a text processor) allows any direct usage of the EUI markdown component the addition of any plugin of choice which could in turn further diversify the markdown styles Kibana supports.
This became very evident, with the attempt to migrate parts of the codebase to the shared UX component, we had reports of in consistencies in rendering expectations. See #180576
Proposal;
The text was updated successfully, but these errors were encountered: