Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The active/recovered badge is not shown correctly in the alert table in observability #169757

Closed
maryam-saeidi opened this issue Oct 25, 2023 · 5 comments · Fixed by elastic/eui#7320
Closed

The active/recovered badge is not shown correctly in the alert table in observability #169757

maryam-saeidi opened this issue Oct 25, 2023 · 5 comments · Fixed by elastic/eui#7320
Assignees
@cee-chen
Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0

Comments

@maryam-saeidi
Copy link
Member

maryam-saeidi commented Oct 25, 2023 •
edited
Loading

📝 Summary

The active badge is not shown correctly in the alert table in observability: (example)

Active Recovered
image image
@maryam-saeidi maryam-saeidi added bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0 labels Oct 25, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@mdefazio
Copy link
Contributor

It looks like it's not just the badge, but something with the row height. The checkbox also seems like it's trimmed on the top and bottom.

Perhaps already what you were imagining, but an issue with data grid?

@maryam-saeidi
Copy link
Member Author

Agree, it seems to be an issue with the row height.

This issue was introduced in this PR: #169135

@JasonStoltz
Copy link
Member

The full changelog for 89.1 is here:
elastic/eui@v89.0.0...v89.1.0

I do see this commit related to data grid: elastic/eui@cff6f41

@cee-chen cee-chen mentioned this issue Oct 26, 2023
Merged
4 tasks
@cee-chen
Copy link
Contributor

EUI Fix: elastic/eui#7320

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cee-chen cee-chen

Labels
bug Fixes for quality problems that affect the customer experience Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.12.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[EuiDataGrid] Fix over-eager visual cutoff on cell contents cee-chen/eui
5 participants
@cee-chen @JasonStoltz @mdefazio @maryam-saeidi @elasticmachine