Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI Actions] On Firefox Drilldown text is missing underline hover #105664

Closed
alisonelizabeth opened this issue Jul 14, 2021 · 4 comments
Closed

[UI Actions] On Firefox Drilldown text is missing underline hover #105664

alisonelizabeth opened this issue Jul 14, 2021 · 4 comments
Assignees
@Dosant
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)

Comments

@alisonelizabeth
Copy link
Contributor

Kibana version:
7.14

Describe the bug:
On Firefox, the name of a url drilldown is sometimes cut off and the underline hover is missing. Not sure if this is a EUI bug, or specific to the dropdown in Dashboard.

Steps to reproduce:

  1. Using Firefox, go to Dashboard and create a visualization.
  2. Create a URL drilldown.
  3. Test the drilldown and note the text is cutoff and the underline hover is missing.

Behavior on Firefox:
firefox_url_drilldown

Behavior on Chrome (correct):
chrome_url_drilldown
@alisonelizabeth alisonelizabeth added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Jul 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-presentation (Team:Presentation)

@kibanamachine kibanamachine added impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. loe:needs-research This issue requires some research before it can be worked on or estimated labels Jul 14, 2021
@ThomThomson ThomThomson added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort and removed loe:needs-research This issue requires some research before it can be worked on or estimated impact:needs-assessment Product and/or Engineering needs to evaluate the impact of the change. labels Oct 28, 2021
@ThomThomson
Copy link
Contributor

Was able to reproduce this. The text is no longer cut off, but the underline is still missing. Checked in the code and it looks like this is happening in the ui_actions plugin owned by @elastic/appex-sharedux so reassigning over there.

@ThomThomson ThomThomson added Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience) and removed Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas labels Apr 10, 2023
@vadimkibana vadimkibana changed the title [Dashboard] [Firefox] Drilldown text partially cutoff and missing underline hover [UI Actions] On Firefox Drilldown text partially cutoff and missing underline hover Aug 14, 2023
@Dosant Dosant self-assigned this Dec 20, 2023
@Dosant
Copy link
Contributor

Dosant commented Dec 20, 2023 •
edited
Loading

but the underline is still missing

there are no custom css overrides, the component is from EUI. reproduced the same behavior in their example https://eui.elastic.co/#/navigation/context-menu - in Firefox there is no underline when item is a a[href]. will create an issue - elastic/eui#7429

@Dosant Dosant changed the title [UI Actions] On Firefox Drilldown text partially cutoff and missing underline hover [UI Actions] On Firefox Drilldown text is missing underline hover Dec 20, 2023
@Dosant
Copy link
Contributor

Dosant commented Jan 8, 2024

should be fixed with #173569

@Dosant Dosant closed this as completed Jan 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Dosant Dosant

Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:SharedUX Team label for AppEx-SharedUX (formerly Global Experience)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@alisonelizabeth @Dosant @ThomThomson @elasticmachine @kibanamachine