From ddca944c37f1c3a34e3cf24739e3238a6303dce0 Mon Sep 17 00:00:00 2001 From: Zacqary Xeper Date: Wed, 15 Jan 2025 09:38:14 -0600 Subject: [PATCH] Remove waitFor in flyout tests --- .../src/rule_flyout/rule_flyout.test.tsx | 24 +++++++------------ 1 file changed, 8 insertions(+), 16 deletions(-) diff --git a/src/platform/packages/shared/response-ops/rule_form/src/rule_flyout/rule_flyout.test.tsx b/src/platform/packages/shared/response-ops/rule_form/src/rule_flyout/rule_flyout.test.tsx index ec8f85d025fb8..8525ba7b5a057 100644 --- a/src/platform/packages/shared/response-ops/rule_form/src/rule_flyout/rule_flyout.test.tsx +++ b/src/platform/packages/shared/response-ops/rule_form/src/rule_flyout/rule_flyout.test.tsx @@ -8,7 +8,7 @@ */ import React from 'react'; -import { fireEvent, render, screen, waitFor } from '@testing-library/react'; +import { fireEvent, render, screen } from '@testing-library/react'; import { RuleFlyout } from './rule_flyout'; import { RULE_FORM_PAGE_RULE_DEFINITION_TITLE_SHORT, @@ -110,30 +110,22 @@ describe('ruleFlyout', () => { render(); fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton')); - await waitFor(() => - expect(screen.getByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument() - ); + expect(await screen.findByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument(); fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton')); - await waitFor(() => - expect(screen.getByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument() - ); + expect(await screen.findByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument(); + fireEvent.click(screen.getByTestId('ruleFlyoutFooterPreviousStepButton')); - await waitFor(() => - expect(screen.getByTestId('ruleFlyoutFooterNextStepButton')).toBeInTheDocument() - ); + expect(await screen.findByTestId('ruleFlyoutFooterNextStepButton')).toBeInTheDocument(); }); test('should call onSave when save button is pressed', async () => { render(); fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton')); - await waitFor(() => - expect(screen.getByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument() - ); + expect(await screen.findByTestId('ruleFlyoutFooterPreviousStepButton')).toBeInTheDocument(); fireEvent.click(screen.getByTestId('ruleFlyoutFooterNextStepButton')); - await waitFor(() => - expect(screen.getByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument() - ); + expect(await screen.findByTestId('ruleFlyoutFooterSaveButton')).toBeInTheDocument(); + fireEvent.click(screen.getByTestId('ruleFlyoutFooterSaveButton')); expect(onSave).toHaveBeenCalledWith({