diff --git a/examples/data_view_field_editor_example/public/app.tsx b/examples/data_view_field_editor_example/public/app.tsx index 71e10634cd818..336c29aa2a1ca 100644 --- a/examples/data_view_field_editor_example/public/app.tsx +++ b/examples/data_view_field_editor_example/public/app.tsx @@ -7,6 +7,7 @@ */ import { + EuiProvider, DefaultItemAction, EuiButton, EuiCheckbox, @@ -121,7 +122,6 @@ const DataViewFieldEditorExample = ({ dataView, dataViewFieldEditor }: Props) => items={fields} columns={columns} pagination={true} - hasActions={true} sorting={{ sort: { field: 'name', @@ -135,10 +135,12 @@ const DataViewFieldEditorExample = ({ dataView, dataViewFieldEditor }: Props) => ); return ( - - - {content} - + + + + {content} + + ); }; diff --git a/examples/field_formats_example/public/app.tsx b/examples/field_formats_example/public/app.tsx index 6aa2f2d5e6c75..2961925f0a160 100644 --- a/examples/field_formats_example/public/app.tsx +++ b/examples/field_formats_example/public/app.tsx @@ -14,6 +14,7 @@ import { EuiCodeBlock, EuiLink, EuiPageTemplate, + EuiProvider, EuiSpacer, EuiText, EuiTitle, @@ -61,7 +62,6 @@ const UsingAnExistingFieldFormatExample: React.FC<{ deps: Deps }> = (props) => { = (props) => { = (props) => { export const App: React.FC<{ deps: Deps }> = (props) => { return ( - - - - -

Using an existing field format

- - - - - - -

Creating a custom field format

- - - - - - -

Creating a custom field format editor

- - - - - + + + + + +

Using an existing field format

+ + + + + + +

Creating a custom field format

+ + + + + + +

Creating a custom field format editor

+ + + + + + ); }; diff --git a/examples/files_example/public/components/app.tsx b/examples/files_example/public/components/app.tsx index db0968d7b43f2..5fea8c5fbc42d 100644 --- a/examples/files_example/public/components/app.tsx +++ b/examples/files_example/public/components/app.tsx @@ -12,6 +12,7 @@ import type { FileJSON } from '@kbn/files-plugin/common'; import type { FilesClientResponses } from '@kbn/files-plugin/public'; import { + EuiProvider, EuiPageTemplate, EuiInMemoryTable, EuiInMemoryTableProps, @@ -131,7 +132,7 @@ export const FilesExampleApp = ({ files, notifications }: FilesExampleAppDeps) = ]; return ( - <> + @@ -185,6 +186,6 @@ export const FilesExampleApp = ({ files, notifications }: FilesExampleAppDeps) = }} /> )} - + ); }; diff --git a/examples/partial_results_example/public/app/app.tsx b/examples/partial_results_example/public/app/app.tsx index 333ce7f6c263e..fb0fe9e3dbef4 100644 --- a/examples/partial_results_example/public/app/app.tsx +++ b/examples/partial_results_example/public/app/app.tsx @@ -9,6 +9,7 @@ import React, { useContext, useEffect, useState } from 'react'; import { pluck } from 'rxjs'; import { + EuiProvider, EuiBasicTable, EuiCallOut, EuiCodeBlock, @@ -40,35 +41,36 @@ export function App() { }, [expressions]); return ( - - - - -

- This example listens for the window events and adds them to the table along with a - trigger counter. -

- - - {expression} - - {datatable ? ( - ({ - field, - name, - 'data-test-subj': `example-column-${field.toLowerCase()}`, - }))} - items={datatable.rows ?? []} - /> - ) : ( - -

Click or press any key.

- - )} - - + + + + + +

+ This example listens for the window events and adds them to the table along with a + trigger counter. +

+ + + {expression} + + {datatable ? ( + ({ + field, + name, + 'data-test-subj': `example-column-${field.toLowerCase()}`, + }))} + items={datatable.rows ?? []} + /> + ) : ( + +

Click or press any key.

+ + )} + + + ); } diff --git a/package.json b/package.json index 19f84d4203033..f23061e31e692 100644 --- a/package.json +++ b/package.json @@ -107,7 +107,7 @@ "@elastic/ecs": "^8.11.1", "@elastic/elasticsearch": "^8.13.0", "@elastic/ems-client": "8.5.1", - "@elastic/eui": "93.6.0", + "@elastic/eui": "94.1.0-backport.0", "@elastic/filesaver": "1.1.2", "@elastic/node-crypto": "1.2.1", "@elastic/numeral": "^2.5.1", diff --git a/packages/content-management/table_list_view_table/src/components/table.tsx b/packages/content-management/table_list_view_table/src/components/table.tsx index 42bd676343362..a459bc26ede50 100644 --- a/packages/content-management/table_list_view_table/src/components/table.tsx +++ b/packages/content-management/table_list_view_table/src/components/table.tsx @@ -242,7 +242,6 @@ export function Table({ data-test-subj="itemsInMemTable" rowHeader="attributes.title" tableCaption={tableCaption} - isSelectable /> ); } diff --git a/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap b/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap index cb10255eb9998..934027aa35ea7 100644 --- a/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap +++ b/packages/core/apps/core-apps-browser-internal/src/status/components/__snapshots__/status_table.test.tsx.snap @@ -38,7 +38,6 @@ exports[`StatusTable renders when statuses is provided 1`] = ` ] } data-test-subj="statusBreakdown" - isExpandable={true} itemId={[Function]} itemIdToExpandedRowMap={Object {}} items={ @@ -58,7 +57,6 @@ exports[`StatusTable renders when statuses is provided 1`] = ` }, ] } - responsive={true} rowProps={[Function]} searchFormat="eql" sorting={ diff --git a/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx b/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx index 37833ebfde923..977dd3efb3e0e 100644 --- a/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx +++ b/packages/core/apps/core-apps-browser-internal/src/status/components/status_table.tsx @@ -104,7 +104,6 @@ export const StatusTable: FunctionComponent = ({ statuses }) = columns={tableColumns} itemId={(item) => item.id} items={statuses} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} rowProps={({ state }) => ({ className: `status-table-row-${state.uiColor}`, diff --git a/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap b/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap index 44170ebcfb06e..d9fc8ecec8050 100644 --- a/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap +++ b/packages/core/i18n/core-i18n-browser-internal/src/__snapshots__/i18n_service.test.tsx.snap @@ -14,7 +14,7 @@ exports[`#start() returns \`Context\` component 1`] = ` "euiAutoRefresh.buttonLabelOn": [Function], "euiBasicTable.noItemsMessage": "No items found", "euiBasicTable.selectAllRows": "Select all rows", - "euiBasicTable.selectThisRow": "Select this row", + "euiBasicTable.selectThisRow": [Function], "euiBasicTable.tableAutoCaptionWithPagination": [Function], "euiBasicTable.tableAutoCaptionWithoutPagination": [Function], "euiBasicTable.tableCaptionWithPagination": [Function], diff --git a/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx b/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx index e4f769c8779c7..3ea767bc5b6bc 100644 --- a/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx +++ b/packages/core/i18n/core-i18n-browser-internal/src/i18n_eui_mapping.tsx @@ -38,10 +38,12 @@ export const getEuiContextMapping = (): EuiTokensObject => { defaultMessage: 'Select all rows', description: 'ARIA and displayed label on a checkbox to select all table rows', }), - 'euiBasicTable.selectThisRow': i18n.translate('core.euiBasicTable.selectThisRow', { - defaultMessage: 'Select this row', - description: 'ARIA and displayed label on a checkbox to select a single table row', - }), + 'euiBasicTable.selectThisRow': ({ index }: EuiValues) => + i18n.translate('core.euiBasicTable.selectThisRow', { + defaultMessage: 'Select row {index}', + values: { index }, + description: 'ARIA and displayed label on a checkbox to select a single table row', + }), 'euiBasicTable.tableCaptionWithPagination': ({ tableCaption, page, pageCount }: EuiValues) => i18n.translate('core.euiBasicTable.tableCaptionWithPagination', { defaultMessage: '{tableCaption}; Page {page} of {pageCount}.', diff --git a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap index 40f115c567f81..66caa5b55f567 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap +++ b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/documents_panel.test.tsx.snap @@ -119,7 +119,6 @@ exports[`DocumentsPanel renders 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap index d4bdda45ccc3b..8320547cb2107 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap +++ b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/events_panel.test.tsx.snap @@ -54,7 +54,6 @@ exports[`EventsPanel renders 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> @@ -110,7 +109,6 @@ exports[`EventsPanel renders with some values missing 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap index cddd85fc851b9..66d241be8d92c 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap +++ b/packages/kbn-search-connectors/components/sync_jobs/__snapshots__/pipeline_panel.test.tsx.snap @@ -43,7 +43,6 @@ exports[`PipelinePanel renders 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx b/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx index ffe2c26d636ed..87f3559c3fab6 100644 --- a/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx +++ b/packages/kbn-search-connectors/components/sync_jobs/sync_jobs_table.tsx @@ -263,7 +263,6 @@ export const SyncJobsTable: React.FC = ({ data-test-subj={`entSearchContent-index-${type}-syncJobs-table`} items={syncJobs} columns={columns} - hasActions onChange={onPaginate} pagination={pagination} tableLayout="fixed" diff --git a/packages/kbn-test-jest-helpers/src/testbed/testbed.ts b/packages/kbn-test-jest-helpers/src/testbed/testbed.ts index 284e8d557de6f..4559924c28aff 100644 --- a/packages/kbn-test-jest-helpers/src/testbed/testbed.ts +++ b/packages/kbn-test-jest-helpers/src/testbed/testbed.ts @@ -263,11 +263,11 @@ export function registerTestBed ({ reactWrapper: row, - columns: row.find('.euiTableCellContent').map((col) => ({ + columns: row.find('div.euiTableCellContent').map((col) => ({ reactWrapper: col, // We can't access the td value with col.text() because // eui adds an extra div in td on mobile => (.euiTableRowCell__mobileHeader) - value: col.find('.euiTableCellContent').text(), + value: col.find('div.euiTableCellContent').text(), })), })); diff --git a/packages/kbn-text-based-editor/src/query_history.test.tsx b/packages/kbn-text-based-editor/src/query_history.test.tsx index 6ee970321a9ae..d1b356e31eaa1 100644 --- a/packages/kbn-text-based-editor/src/query_history.test.tsx +++ b/packages/kbn-text-based-editor/src/query_history.test.tsx @@ -159,7 +159,7 @@ describe('QueryHistory', () => { /> ); expect(screen.getByRole('table')).toHaveTextContent( - 'Time ranRecent queriesLast durationTime ranMar. 25, 24 08:45:27Recent queriesfrom kibana_sample_data_flights | limit 10Last duration2ms' + 'Time ranRecent queriesLast durationMar. 25, 24 08:45:27from kibana_sample_data_flights | limit 102ms' ); }); }); diff --git a/packages/kbn-text-based-editor/src/query_history.tsx b/packages/kbn-text-based-editor/src/query_history.tsx index 3e597cd1ed86f..0759c7fd7e816 100644 --- a/packages/kbn-text-based-editor/src/query_history.tsx +++ b/packages/kbn-text-based-editor/src/query_history.tsx @@ -380,7 +380,7 @@ export function QueryHistory({ defaultMessage: 'Queries history table', } )} - responsive={false} + responsiveBreakpoint={false} items={historyItems} columns={columns} sorting={sorting} diff --git a/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx b/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx index 8e4cdc3d0ff88..5d573e926f5ba 100755 --- a/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx +++ b/packages/kbn-unified-field-list/src/components/field_stats/field_number_summary.tsx @@ -88,7 +88,7 @@ export const FieldNumberSummary: React.FC = ({ columns={summaryTableColumns} tableCaption={summaryTableTitle} data-test-subj={`${dataTestSubject}-numberSummary`} - responsive={false} + responsiveBreakpoint={false} css={css` & .euiTableHeaderCell { ${euiScreenReaderOnly()} diff --git a/src/dev/license_checker/config.ts b/src/dev/license_checker/config.ts index e0e4b2f1376fa..c708ab543476d 100644 --- a/src/dev/license_checker/config.ts +++ b/src/dev/license_checker/config.ts @@ -86,7 +86,7 @@ export const LICENSE_OVERRIDES = { 'jsts@1.6.2': ['Eclipse Distribution License - v 1.0'], // cf. https://github.com/bjornharrtell/jsts '@mapbox/jsonlint-lines-primitives@2.0.2': ['MIT'], // license in readme https://github.com/tmcw/jsonlint '@elastic/ems-client@8.5.1': ['Elastic License 2.0'], - '@elastic/eui@93.6.0': ['SSPL-1.0 OR Elastic License 2.0'], + '@elastic/eui@94.1.0-backport.0': ['SSPL-1.0 OR Elastic License 2.0'], 'language-subtag-registry@0.3.21': ['CC-BY-4.0'], // retired ODC‑By license https://github.com/mattcg/language-subtag-registry 'buffers@0.1.1': ['MIT'], // license in importing module https://www.npmjs.com/package/binary '@bufbuild/protobuf@1.2.1': ['Apache-2.0'], // license (Apache-2.0 AND BSD-3-Clause) diff --git a/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx b/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx index de96c865b90e0..6394deeab843b 100644 --- a/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx +++ b/src/plugins/data/public/search/session/sessions_mgmt/components/table/table.test.tsx @@ -100,8 +100,7 @@ describe('Background Search Session Management Table', () => { ); }); - expect(table.find('thead th .euiTableCellContent__text').map((node) => node.text())) - .toMatchInlineSnapshot(` + expect(table.find('thead th').map((node) => node.text())).toMatchInlineSnapshot(` Array [ "App", "Name", @@ -136,12 +135,12 @@ describe('Background Search Session Management Table', () => { expect(table.find('tbody td').map((node) => node.text())).toMatchInlineSnapshot(` Array [ - "App", - "Namevery background search Info", - "# Searches0", - "StatusExpired", - "Created2 Dec, 2020, 00:19:32", - "Expiration--", + "", + "very background search Info", + "0", + "Expired", + "2 Dec, 2020, 00:19:32", + "--", "", "", ] diff --git a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap index eb243025df2f7..77df622eaddbb 100644 --- a/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap +++ b/src/plugins/data/public/utils/table_inspector_view/components/__snapshots__/data_view.test.tsx.snap @@ -200,123 +200,79 @@ Array [ class="euiBasicTable insDataTableFormat__table eui-xScroll css-1f59z3t" data-test-subj="inspectorTable" > -
-
-
-
-
+ + + + -
- -
-
-
-
-
- - - - - - - + + + + + + + - - - - -
-
- -
- column1 -
-
+ 123 +
+
- 123 -
-
-
-
+ class="euiFlexGroup emotion-euiFlexGroup-none-flexStart-center-row" + />
-
-
+
+ + + +
-
-
-
-
-
+ + + + -
- -
-
-
-
-
- - - - - - - + + + + + + + - - - - -
-
- -
- column1 -
-
+ 123 +
+
- 123 -
-
-
-
+ class="euiFlexGroup emotion-euiFlexGroup-none-flexStart-center-row" + />
-
-
+
+ + + +
@@ -104,7 +104,7 @@ exports[`IndicesList should change pages 1`] = ` exports[`IndicesList should change per page 1`] = `
@@ -206,7 +206,7 @@ exports[`IndicesList should change per page 1`] = ` exports[`IndicesList should highlight fully when an exact match 1`] = `
@@ -314,7 +314,7 @@ exports[`IndicesList should highlight fully when an exact match 1`] = ` exports[`IndicesList should highlight the query in the matches 1`] = `
@@ -422,7 +422,7 @@ exports[`IndicesList should highlight the query in the matches 1`] = ` exports[`IndicesList should render normally 1`] = `
@@ -523,7 +523,7 @@ exports[`IndicesList should render normally 1`] = ` exports[`IndicesList updating props should render all new indices 1`] = `
diff --git a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx index d7542a9e70184..1cb5298911785 100644 --- a/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx +++ b/src/plugins/data_view_editor/public/components/preview_panel/indices_list/indices_list.tsx @@ -218,7 +218,7 @@ export class IndicesList extends React.Component - + {rows} diff --git a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap index 1cff82729e6f9..3fb1b65c2d4af 100644 --- a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap +++ b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/color/__snapshots__/color.test.tsx.snap @@ -82,7 +82,6 @@ exports[`ColorFormatEditor should render multiple colors 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} tableLayout="fixed" /> } - responsive={true} style={ Object { "maxWidth": "400px", @@ -169,7 +168,6 @@ exports[`StaticLookupFormatEditor should render normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} style={ Object { "maxWidth": "400px", diff --git a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap index 9959f3f97edd9..27aaaf65e902d 100644 --- a/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap +++ b/src/plugins/data_view_field_editor/public/components/field_format_editor/editors/url/__snapshots__/url.test.tsx.snap @@ -282,181 +282,129 @@ exports[`UrlFormatEditor should render normally 1`] = ` class="euiBasicTable kbnFieldFormatEditor__samples" id="generated-id" > -
-
-
-
-
-
-
- - - - + + - + - - - + + + + + - - - + - - + + + + - + - - + + + + - + - - -
-
+
+
+
- - Input - + Input -
+ +
- - Output - + Output -
-
- Input -
-
- john -
- 		+ +
-
- Output -
-
-
- converted url for john -
+
+ converted url for john
-
- -
- Input -
-
- /some/pathname/asset.png -
- 		+ +
-
- Output -
-
-
- converted url for /some/pathname/asset.png -
+
+ converted url for /some/pathname/asset.png
-
- -
- Input -
-
- 1234 -
- 		+ +
-
- Output +
+ converted url for 1234
-
-
- converted url for 1234 -
-
-
-
+
+ + + +
diff --git a/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap b/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap index eecd78db02ef1..c1f59038e4756 100644 --- a/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap +++ b/src/plugins/data_view_field_editor/public/components/field_format_editor/samples/__snapshots__/samples.test.tsx.snap @@ -57,7 +57,6 @@ exports[`FormatEditorSamples should render normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap index aeb4417ccbd59..53cb9a9db33b7 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/indexed_fields_table/components/table/__snapshots__/table.test.tsx.snap @@ -57,7 +57,6 @@ exports[`Table render conflict summary modal 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} rowHeader="firstName" tableCaption="Demo of EuiBasicTable" tableLayout="auto" @@ -304,7 +303,6 @@ exports[`Table should render normally 1`] = ` ], } } - responsive={true} searchFormat="eql" sorting={ Object { diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap index 7ce374b2ad3b4..5f8e34d0776ec 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/scripted_fields_table/components/table/__snapshots__/table.test.tsx.snap @@ -86,7 +86,6 @@ exports[`Table should render normally 1`] = ` ], } } - responsive={true} searchFormat="eql" sorting={true} tableLayout="fixed" diff --git a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap index e6f71b425ce8e..66b7b6f106285 100644 --- a/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/edit_index_pattern/source_filters_table/components/table/__snapshots__/table.test.tsx.snap @@ -91,7 +91,6 @@ exports[`Table should render normally 1`] = ` ], } } - responsive={true} searchFormat="eql" sorting={true} tableLayout="fixed" diff --git a/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap b/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap index ac12af2228758..90e0d28996d66 100644 --- a/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap +++ b/src/plugins/data_view_management/public/components/index_pattern_table/__snapshots__/delete_modal_msg.test.tsx.snap @@ -64,7 +64,6 @@ exports[`delete modal content render 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> @@ -127,7 +126,6 @@ exports[`delete modal content render 2`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> @@ -196,7 +194,6 @@ exports[`delete modal content render 3`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> @@ -276,7 +273,6 @@ exports[`delete modal content render 4`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableCaption="Data views selected for deletion" tableLayout="fixed" /> diff --git a/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx b/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx index f2d5c8d18aa0e..044904d96eea3 100644 --- a/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx +++ b/src/plugins/data_view_management/public/components/index_pattern_table/index_pattern_table.tsx @@ -340,7 +340,6 @@ export const IndexPatternTable = ({ = compressed={true} rowHeader="label" columns={columns} - responsive /> diff --git a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx index 667c8937aa649..dcaadb58f1155 100644 --- a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.test.tsx @@ -32,9 +32,9 @@ describe('ClustersTable', () => { render(); const tableRows = screen.getAllByRole('row'); expect(tableRows.length).toBe(4); // 1 header row, 3 data rows - expect(tableRows[1]).toHaveTextContent('Nameremote1StatussuccessfulResponse time50ms'); - expect(tableRows[2]).toHaveTextContent('Nameremote2StatusskippedResponse time1000ms'); - expect(tableRows[3]).toHaveTextContent('Nameremote3StatusfailedResponse time90ms'); + expect(tableRows[1]).toHaveTextContent('remote1successful50ms'); + expect(tableRows[2]).toHaveTextContent('remote2skipped1000ms'); + expect(tableRows[3]).toHaveTextContent('remote3failed90ms'); }); test('should sort by response time', () => { @@ -45,16 +45,16 @@ describe('ClustersTable', () => { fireEvent.click(button); const tableRowsAsc = screen.getAllByRole('row'); expect(tableRowsAsc.length).toBe(4); // 1 header row, 3 data rows - expect(tableRowsAsc[1]).toHaveTextContent('Nameremote1StatussuccessfulResponse time50ms'); - expect(tableRowsAsc[2]).toHaveTextContent('Nameremote3StatusfailedResponse time90ms'); - expect(tableRowsAsc[3]).toHaveTextContent('Nameremote2StatusskippedResponse time1000ms'); + expect(tableRowsAsc[1]).toHaveTextContent('remote1successful50ms'); + expect(tableRowsAsc[2]).toHaveTextContent('remote3failed90ms'); + expect(tableRowsAsc[3]).toHaveTextContent('remote2skipped1000ms'); fireEvent.click(button); const tableRowsDesc = screen.getAllByRole('row'); expect(tableRowsDesc.length).toBe(4); // 1 header row, 3 data rows - expect(tableRowsDesc[1]).toHaveTextContent('Nameremote2StatusskippedResponse time1000ms'); - expect(tableRowsDesc[2]).toHaveTextContent('Nameremote3StatusfailedResponse time90ms'); - expect(tableRowsDesc[3]).toHaveTextContent('Nameremote1StatussuccessfulResponse time50ms'); + expect(tableRowsDesc[1]).toHaveTextContent('remote2skipped1000ms'); + expect(tableRowsDesc[2]).toHaveTextContent('remote3failed90ms'); + expect(tableRowsDesc[3]).toHaveTextContent('remote1successful50ms'); }); }); }); diff --git a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx index 1cd0f0864742f..92e8e7ebcbafe 100644 --- a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/clusters_table.tsx @@ -137,7 +137,6 @@ export function ClustersTable({ clusters }: Props) { ? items.sort(Comparators.property(sortField, Comparators.default(sortDirection))) : items } - isExpandable={true} itemIdToExpandedRowMap={expandedRows} itemId="name" columns={columns} diff --git a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx index 344b17b38a741..d72f661576a55 100644 --- a/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/clusters_view/clusters_table/shards_view/shard_failure_table.tsx @@ -108,7 +108,6 @@ export function ShardFailureTable({ failures }: Props) { failureType: failure.reason.type, }; })} - isExpandable={true} itemIdToExpandedRowMap={expandedRows} itemId="rowId" columns={columns} diff --git a/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx b/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx index fc0ab22e826ff..17d8953f8aef7 100644 --- a/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx +++ b/src/plugins/inspector/public/views/requests/components/details/req_details_stats.tsx @@ -66,7 +66,7 @@ export class RequestDetailsStats extends Component { .map((id) => ({ id, ...stats[id] } as RequestDetailsStatRow)); return ( - + {sortedStats.map(this.renderStatRow)} ); diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap index 03ba5cf5d9ead..e6b32851f7682 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/flyout.test.tsx.snap @@ -114,7 +114,6 @@ exports[`Flyout conflicts should allow conflict resolution 1`] = ` ], } } - responsive={true} searchFormat="eql" tableLayout="fixed" /> diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap index 4e5b62f812633..d942d13b0f022 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/relationships.test.tsx.snap @@ -111,7 +111,6 @@ exports[`Relationships should render dashboards normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -313,7 +312,6 @@ exports[`Relationships should render index patterns normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -447,7 +445,6 @@ exports[`Relationships should render invalid relations 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} searchFormat="eql" tableLayout="fixed" @@ -506,7 +503,6 @@ exports[`Relationships should render invalid relations 1`] = ` } items={Array []} pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -658,7 +654,6 @@ exports[`Relationships should render searches normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -820,7 +815,6 @@ exports[`Relationships should render visualizations normally 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap index 159ef79066a89..528ec071e3c84 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/__snapshots__/table.test.tsx.snap @@ -144,7 +144,7 @@ exports[`Table prevents hidden saved objects from being deleted 1`] = ` "name": "Type", "render": [Function], "sortable": true, - "width": "50px", + "width": "65px", }, Object { "data-test-subj": "savedObjectsTableRowTitle", @@ -227,7 +227,6 @@ exports[`Table prevents hidden saved objects from being deleted 1`] = ` "totalItemCount": 3, } } - responsive={true} rowProps={[Function]} selection={ Object { @@ -384,7 +383,7 @@ exports[`Table should render normally 1`] = ` "name": "Type", "render": [Function], "sortable": true, - "width": "50px", + "width": "65px", }, Object { "data-test-subj": "savedObjectsTableRowTitle", @@ -467,7 +466,6 @@ exports[`Table should render normally 1`] = ` "totalItemCount": 3, } } - responsive={true} rowProps={[Function]} selection={ Object { diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx b/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx index 8dffee1b91b64..edfe0b1d00edf 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/delete_confirm_modal.test.tsx @@ -84,7 +84,7 @@ describe('DeleteConfirmModal', () => { allowedTypes={allowedTypes} /> ); - expect(wrapper.find('.euiTableRow')).toHaveLength(3); + expect(wrapper.find('tr.euiTableRow')).toHaveLength(3); }); it('calls `onCancel` when clicking on the cancel button', () => { @@ -135,7 +135,7 @@ describe('DeleteConfirmModal', () => { allowedTypes={allowedTypes} /> ); - expect(wrapper.find('.euiTableRow')).toHaveLength(1); + expect(wrapper.find('tr.euiTableRow')).toHaveLength(1); }); it('displays a callout when at least one object cannot be deleted', () => { diff --git a/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx b/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx index 1d2e2e14b4050..8cd7234e2591b 100644 --- a/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx +++ b/src/plugins/saved_objects_management/public/management_section/objects_table/components/table.tsx @@ -234,7 +234,7 @@ export class Table extends PureComponent { name: i18n.translate('savedObjectsManagement.objectsTable.table.columnTypeName', { defaultMessage: 'Type', }), - width: '50px', + width: '65px', align: 'center', description: i18n.translate( 'savedObjectsManagement.objectsTable.table.columnTypeDescription', diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx index ecc0d23f09092..97ae04a2331e2 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_table/drilldown_table.tsx @@ -147,8 +147,7 @@ export const DrilldownTable: React.FC = ({ items={drilldowns} itemId="id" columns={columns} - isSelectable={true} - responsive={false} + responsiveBreakpoint={false} selection={{ onSelectionChange: (selection) => { setSelectedDrilldowns(selection.map((drilldown) => drilldown.id)); @@ -158,7 +157,6 @@ export const DrilldownTable: React.FC = ({ rowProps={{ 'data-test-subj': TEST_SUBJ_DRILLDOWN_ITEM, }} - hasActions={true} sorting={{ sort: { field: 'drilldownName', diff --git a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx index feabf1a75556b..162b78a61b650 100644 --- a/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx +++ b/src/plugins/ui_actions_enhanced/public/drilldowns/drilldown_manager/components/drilldown_template_table/drilldown_template_table.tsx @@ -107,11 +107,10 @@ export const DrilldownTemplateTable: React.FC = ({ <> = ({ }, selectableMessage: () => txtSelectableMessage, }} - hasActions={true} /> {!!onClone && !!selected.length && ( diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx index 310c8653bbee5..deb5e5a52fb7a 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/legacy/table.tsx @@ -116,8 +116,7 @@ export const DocViewerLegacyTable = ({ items={items} columns={tableColumns} rowProps={onSetRowProps} - pagination={false} - responsive={false} + responsiveBreakpoint={false} /> ); }; diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss index c3d3631177c4e..881e988111129 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss @@ -41,13 +41,17 @@ .kbnDocViewer__tableActionsCell, .kbnDocViewer__tableFieldNameCell { - align-items: flex-start; - padding: $euiSizeXS; + .euiTableCellContent { + align-items: flex-start; + padding: $euiSizeXS; + } } .kbnDocViewer__tableValueCell { - flex-direction: column; - align-items: flex-start; + .euiTableCellContent { + flex-direction: column; + align-items: flex-start; + } } .kbnDocViewer__value { diff --git a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx index ad957053b7dd8..b87efe1cad043 100644 --- a/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx +++ b/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.tsx @@ -434,7 +434,7 @@ export const DocViewerTable = ({ ) : ( - + {headers} {rowElements} diff --git a/test/functional/services/inspector.ts b/test/functional/services/inspector.ts index 2b9fef9818dd0..348f37281156e 100644 --- a/test/functional/services/inspector.ts +++ b/test/functional/services/inspector.ts @@ -144,7 +144,7 @@ export class InspectorService extends FtrService { return await inspectorPanel.findByTagName('thead'); }); const $ = await dataTableHeader.parseDomContent(); - return $('th span.euiTableCellContent__text') + return $('th .euiTableCellContent span') .toArray() .map((cell) => $(cell).text().trim()); } diff --git a/test/functional/services/listing_table.ts b/test/functional/services/listing_table.ts index 98841ea996d2a..61da3756a3d2a 100644 --- a/test/functional/services/listing_table.ts +++ b/test/functional/services/listing_table.ts @@ -69,14 +69,10 @@ export class ListingTableService extends FtrService { private async getAllSelectableItemsNamesOnCurrentPage(): Promise { const visualizationNames = []; - // TODO - use .euiTableRow-isSelectable when it's working again (https://github.com/elastic/eui/issues/7515) - const rows = await this.find.allByCssSelector('.euiTableRow'); + const rows = await this.find.allByCssSelector('.euiTableRow-isSelectable'); for (let i = 0; i < rows.length; i++) { - const checkbox = await rows[i].findByCssSelector('.euiCheckbox__input'); - if (await checkbox.isEnabled()) { - const link = await rows[i].findByCssSelector('.euiLink'); - visualizationNames.push(await link.getVisibleText()); - } + const link = await rows[i].findByCssSelector('.euiLink'); + visualizationNames.push(await link.getVisibleText()); } this.log.debug(`Found ${visualizationNames.length} selectable visualizations on current page`); return visualizationNames; diff --git a/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx b/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx index 1cfb80c8ad693..6eeb80f2bb911 100644 --- a/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx +++ b/x-pack/packages/kbn-elastic-assistant/impl/data_anonymization_editor/context_editor/index.tsx @@ -133,7 +133,6 @@ const ContextEditorComponent: React.FC = ({ columns={columns} compressed={true} data-test-subj="contextEditor" - isSelectable={true} itemId={FIELDS.FIELD} items={rows} pagination={pagination} diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx index 8209e96a22ea4..673a74e357b66 100644 --- a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx +++ b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.test.tsx @@ -177,7 +177,7 @@ describe('helpers', () => { name: 'Result', sortable: true, truncateText: false, - width: '50px', + width: '65px', }, { field: 'indexName', name: 'Index', sortable: true, truncateText: false, width: '300px' }, { field: 'docsCount', name: 'Docs', sortable: true, truncateText: false }, diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx index 6af80a1e0628e..6d135477b9af3 100644 --- a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx +++ b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/helpers.tsx @@ -194,7 +194,7 @@ export const getSummaryTableColumns = ({ ), sortable: true, truncateText: false, - width: '50px', + width: '65px', }, { field: 'indexName', diff --git a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx index a230510029222..6379539f05096 100644 --- a/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx +++ b/x-pack/packages/security-solution/ecs_data_quality_dashboard/impl/data_quality/data_quality_panel/summary_table/index.tsx @@ -108,7 +108,6 @@ const SummaryTableComponent: React.FC = ({ compressed={true} columns={columns} data-test-subj="summaryTable" - isExpandable={true} itemId={getItemId} itemIdToExpandedRowMap={itemIdToExpandedRowMap} items={items} diff --git a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx index f42e1acc31996..308a4d8dc22b0 100644 --- a/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx +++ b/x-pack/plugins/aiops/public/components/change_point_detection/change_points_table.tsx @@ -153,9 +153,7 @@ export const ChangePointsTable: FC = ({ truncateText: false, valign: 'middle', css: { - // Extra specificity needed here to override Sass styles - // TODO: Can be removed once EuiTable has been converted to Emotion - ['&.euiTableCellContent']: { display: 'block', padding: 0 }, + '.euiTableCellContent': { display: 'block', padding: 0 }, }, render: (annotation: ChangePointAnnotation) => { return ( @@ -313,7 +311,7 @@ export const ChangePointsTable: FC = ({ return ( - itemId={'id'} + itemId="id" selection={selectionValue} loading={isLoading} data-test-subj={`aiopsChangePointResultsTable ${isLoading ? 'loading' : 'loaded'}`} @@ -324,7 +322,6 @@ export const ChangePointsTable: FC = ({ } sorting={sorting} onTableChange={onTableChange} - hasActions={hasActions} rowProps={(item) => ({ 'data-test-subj': `aiopsChangePointResultsTableRow row-${item.id}`, })} diff --git a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx index a8bf7d04298e1..fc2d4b559e859 100644 --- a/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx +++ b/x-pack/plugins/aiops/public/components/log_categorization/category_table/category_table.tsx @@ -317,14 +317,12 @@ export const CategoryTable: FC = ({ compressed items={categories} columns={columns} - isSelectable={true} selection={selectionValue} itemId="key" onTableChange={onTableChange} pagination={pagination} sorting={sorting} data-test-subj="aiopsLogPatternsTable" - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} rowProps={(category) => { return enableRowActions diff --git a/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx b/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx index 0abd1c4e1863c..dd396057e3724 100644 --- a/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx +++ b/x-pack/plugins/alerting/public/pages/maintenance_windows/components/maintenance_windows_list.tsx @@ -191,7 +191,6 @@ export const MaintenanceWindowsList = React.memo( sorting={sorting} rowProps={rowProps} search={search} - hasActions={true} /> ); } diff --git a/x-pack/plugins/canvas/public/components/var_config/var_config.tsx b/x-pack/plugins/canvas/public/components/var_config/var_config.tsx index 25c77ab7704bf..b3ddd8c96c2ba 100644 --- a/x-pack/plugins/canvas/public/components/var_config/var_config.tsx +++ b/x-pack/plugins/canvas/public/components/var_config/var_config.tsx @@ -212,7 +212,6 @@ export const VarConfig: FC = ({ className="canvasVarConfig__list" items={variables} columns={varColumns} - hasActions={true} pagination={false} sorting={true} compressed diff --git a/x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx b/x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx index 6e96596a41ab9..5a34be12232d3 100644 --- a/x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx +++ b/x-pack/plugins/cases/public/components/all_cases/all_cases_list.test.tsx @@ -368,13 +368,6 @@ describe('AllCasesListGeneric', () => { }); }); - it('case table should not be selectable when isSelectorView=true', async () => { - appMockRenderer.render(); - await waitFor(() => { - expect(screen.queryByTestId('cases-table')).not.toHaveAttribute('isSelectable'); - }); - }); - it('should call onRowClick with no cases and isSelectorView=true when create case is clicked', async () => { appMockRenderer.render(); userEvent.click(screen.getByTestId('cases-table-add-case-filter-bar')); diff --git a/x-pack/plugins/cases/public/components/all_cases/table.tsx b/x-pack/plugins/cases/public/components/all_cases/table.tsx index 24c354970f038..022753a2899c4 100644 --- a/x-pack/plugins/cases/public/components/all_cases/table.tsx +++ b/x-pack/plugins/cases/public/components/all_cases/table.tsx @@ -82,7 +82,6 @@ export const CasesTable: FunctionComponent = ({ className={classnames({ isSelectorView })} columns={columns} data-test-subj="cases-table" - isSelectable={!isSelectorView} itemId="id" items={data.cases} loading={isCommentUpdating} @@ -114,7 +113,6 @@ export const CasesTable: FunctionComponent = ({ rowProps={tableRowProps} selection={!isSelectorView ? selection : undefined} sorting={sorting} - hasActions={false} /> ); diff --git a/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx b/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx index fa9b53ff06c11..8b61b3f093b70 100644 --- a/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx +++ b/x-pack/plugins/cloud_security_posture/public/pages/compliance_dashboard/dashboard_sections/benchmarks_section.tsx @@ -133,7 +133,7 @@ export const BenchmarksSection = ({ id="xpack.csp.dashboard.benchmarkSection.columnsHeader.complianceScoreTitle" defaultMessage="Compliance Score" /> - +
diff --git a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js index 5c966eac9219d..b5df0f1c5011e 100644 --- a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js +++ b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/auto_follow_pattern_list/components/auto_follow_pattern_table/auto_follow_pattern_table.js @@ -341,7 +341,6 @@ export class AutoFollowPatternTable extends PureComponent { pagination={pagination} sorting={sorting} selection={selection} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js index 6b4170cf18c02..5d04fe8586a25 100644 --- a/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js +++ b/x-pack/plugins/cross_cluster_replication/public/app/sections/home/follower_indices_list/components/follower_indices_table/follower_indices_table.js @@ -326,7 +326,6 @@ export class FollowerIndicesTable extends PureComponent { pagination={pagination} sorting={sorting} selection={selection} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx b/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx index be5ecf5acc15a..6c5fedce0fee3 100644 --- a/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx +++ b/x-pack/plugins/data_visualizer/public/application/common/components/field_types_filter/field_types_help_popover.tsx @@ -130,7 +130,7 @@ export const FieldTypesHelpPopover: FC<{ compressed={true} rowHeader="firstName" columns={columnsSidebar} - responsive={false} + responsiveBreakpoint={false} /> diff --git a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx index 2e2c1e2b9d9e8..9f52a00a3b2be 100644 --- a/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx +++ b/x-pack/plugins/data_visualizer/public/application/common/components/stats_table/data_visualizer_stats_table.tsx @@ -395,7 +395,7 @@ export const DataVisualizerTable = ({ backgroundColor: euiTheme.colors.emptyShade, boxShadow: `inset 0 0px 0, inset 0 -1px 0 ${euiTheme.border.color}`, }, - '.euiTableRow > .euiTableRowCel': { + '.euiTableRow > .euiTableRowCell': { borderTop: 0, }, [useEuiMinBreakpoint('s')]: { @@ -481,9 +481,7 @@ export const DataVisualizerTable = ({ columns={columns} pagination={pagination} sorting={sorting} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isSelectable={false} onTableChange={onTableChange} data-test-subj={`dataVisualizerTable-${loading ? 'loading' : 'loaded'}`} rowProps={(item) => ({ diff --git a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx index 55bce9d953c5b..7de413c74b4de 100644 --- a/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx +++ b/x-pack/plugins/data_visualizer/public/application/data_drift/data_drift_overview_table.tsx @@ -305,7 +305,6 @@ export const DataDriftOverviewTable = ({ cellProps={getCellProps} itemId="featureName" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable={true} sorting={sorting} onChange={onTableChange} pagination={pagination} diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx index 53fa6312b9c49..a5e981e7f7b8d 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/analytics/components/analytics_tables/analytics_table.tsx @@ -59,8 +59,6 @@ export const AnalyticsTable: React.FC = ({ items, hasClicks, isSmall }) = = ({ items }) => { = ({ items }) => { [TERM_COLUMN, TIME_COLUMN, TAGS_LIST_COLUMN, RESULTS_COLUMN, ACTIONS_COLUMN] as Columns } items={items} - responsive - hasActions noItemsMessage={ = ({ hasPagination }) => { } {...paginationProps} diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx index defa71847a183..8286bcc263a45 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/crawler/components/domains_table.test.tsx @@ -143,6 +143,8 @@ describe('DomainsTable', () => { }); describe('when the user can manage/delete engines', () => { + const simulatedClickEvent = { persist: () => {} }; // Required for EUI action clicks. Can be removed if switching away from Enzyme to RTL + const getManageAction = () => getActionItems().at(0).dive().find(EuiButtonIcon); const getDeleteAction = () => getActionItems().at(1).dive().find(EuiButtonIcon); @@ -159,7 +161,7 @@ describe('DomainsTable', () => { it('sends the user to the engine overview on click', () => { const { navigateToUrl } = mockKibanaValues; - getManageAction().simulate('click'); + getManageAction().simulate('click', simulatedClickEvent); expect(navigateToUrl).toHaveBeenCalledWith('/engines/some-engine/crawler/domains/1234'); }); @@ -169,7 +171,7 @@ describe('DomainsTable', () => { it('clicking the action and confirming deletes the domain', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(true); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(actions.deleteDomain).toHaveBeenCalledWith( expect.objectContaining({ id: '1234' }) @@ -179,7 +181,7 @@ describe('DomainsTable', () => { it('clicking the action and not confirming does not delete the engine', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(false); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(actions.deleteDomain).not.toHaveBeenCalled(); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx index b8f019dc65fca..31897bf9ec8c8 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/curations/components/curations_table.tsx @@ -138,8 +138,6 @@ export const CurationsTable: React.FC = () => { { { itemId="query" // @ts-expect-error - EuiBasicTable wants an array of objects, but will accept strings if coerced columns={columns} - hasActions pagination={{ ...convertMetaToPagination(meta), showPerPageOptions: false, diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx index e00497a419a3c..fffd9156555c7 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/engines/components/tables/test_helpers/shared_columns.tsx @@ -22,6 +22,8 @@ export const runSharedColumnsTests = ( tableContent: string, values: object = {} ) => { + const simulatedClickEvent = { persist: () => {} }; // Required for EUI action clicks. Can be removed if switching away from Enzyme to RTL + const getTableBody = () => wrapper.find(EuiBasicTable).dive().find('RenderWithEuiTheme').renderProp('children')(); @@ -83,7 +85,7 @@ export const runSharedColumnsTests = ( it('sends the user to the engine overview on click', () => { jest.spyOn(engineLinkHelpers, 'navigateToEngine'); const { navigateToEngine } = engineLinkHelpers; - getManageAction().simulate('click'); + getManageAction().simulate('click', simulatedClickEvent); expect(navigateToEngine).toHaveBeenCalledWith('test-engine'); }); @@ -94,7 +96,7 @@ export const runSharedColumnsTests = ( it('clicking the action and confirming deletes the engine', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(true); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(deleteEngine).toHaveBeenCalledWith( expect.objectContaining({ name: 'test-engine' }) @@ -103,7 +105,7 @@ export const runSharedColumnsTests = ( it('clicking the action and not confirming does not delete the engine', () => { jest.spyOn(global, 'confirm').mockReturnValueOnce(false); - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(deleteEngine).not.toHaveBeenCalled(); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx index 8abb716183a9f..8b481d38d23bb 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/non_text_fields_body.test.tsx @@ -50,15 +50,15 @@ describe('NonTextFieldsBody', () => { const tableRows = getTableRows(wrapper); expect(tableRows.length).toBe(3); - expect(tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'bar' - ); - expect(tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'foo' - ); - expect(tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'zoo' - ); + expect( + tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('bar'); + expect( + tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('foo'); + expect( + tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('zoo'); }); describe('the "raw" checkbox within each table row', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/result_settings_table.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/result_settings_table.tsx index 092a4beee0c8e..eb9ef02cea45e 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/result_settings_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/result_settings_table.tsx @@ -28,7 +28,7 @@ export const ResultSettingsTable: React.FC = () => { // TODO This table currently has mutiple theads, which is invalid html. We could change these subheaders to be EuiTableRow instead of EuiTableHeader // to alleviate the issue. return ( - + {!!Object.keys(textResultFields).length && ( diff --git a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx index 3081ccc445655..3986809c549aa 100644 --- a/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/app_search/components/result_settings/result_settings_table/text_fields_body.test.tsx @@ -65,15 +65,15 @@ describe('TextFieldsBody', () => { const tableRows = getTableRows(wrapper); expect(tableRows.length).toBe(3); - expect(tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'bar' - ); - expect(tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'foo' - ); - expect(tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').dive().text()).toEqual( - 'zoo' - ); + expect( + tableRows.at(0).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('bar'); + expect( + tableRows.at(1).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('foo'); + expect( + tableRows.at(2).find('[data-test-subj="ResultSettingFieldName"]').render().text() + ).toEqual('zoo'); }); describe('the "raw" checkbox within each table row', () => { diff --git a/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx b/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx index 0ec4998d018c0..a9343feea72fc 100644 --- a/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/applications/components/search_application/search_application_schema.tsx @@ -145,7 +145,7 @@ const SchemaFieldDetails: React.FC<{ schemaField: SchemaField }> = ({ schemaFiel css={{ '& .euiTable': { backgroundColor: 'transparent' } }} columns={columns} items={schemaField.indices} - responsive={false} + responsiveBreakpoint={false} /> @@ -451,8 +451,7 @@ export const SearchApplicationSchema: React.FC = () => { loading={isLoadingSearchApplicationSchema} itemId="name" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable - responsive={false} + responsiveBreakpoint={false} /> {totalConflictsHiddenByTypeFilters > 0 && ( { )} { }); describe('actions column', () => { + const simulatedClickEvent = { persist: () => {} }; // Required for EUI action clicks. Can be removed if switching away from Enzyme to RTL + const getActions = () => getTableBody().find('ExpandedItemActions'); const getActionItems = () => getActions().first().dive().find('DefaultItemAction'); @@ -157,7 +159,7 @@ describe('DomainsTable', () => { it('sends the user to the engine overview on click', () => { const { navigateToUrl } = mockKibanaValues; - getManageAction().simulate('click'); + getManageAction().simulate('click', simulatedClickEvent); expect(navigateToUrl).toHaveBeenCalledWith( '/search_indices/index-name/domain_management/1234' @@ -167,7 +169,7 @@ describe('DomainsTable', () => { describe('delete action', () => { it('clicking the action and confirming deletes the domain', () => { - getDeleteAction().simulate('click'); + getDeleteAction().simulate('click', simulatedClickEvent); expect(actions.showModal).toHaveBeenCalled(); }); diff --git a/x-pack/plugins/enterprise_search/public/applications/shared/role_mapping/role_mappings_table.tsx b/x-pack/plugins/enterprise_search/public/applications/shared/role_mapping/role_mappings_table.tsx index 427368a2a6f98..45756b91b73d6 100644 --- a/x-pack/plugins/enterprise_search/public/applications/shared/role_mapping/role_mappings_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/shared/role_mapping/role_mappings_table.tsx @@ -170,7 +170,7 @@ export const RoleMappingsTable: React.FC = ({ search={search} pagination={pagination} message={ROLE_MAPPINGS_NO_RESULTS_MESSAGE} - responsive={false} + responsiveBreakpoint={false} /> ); }; diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx index 8081dbff5b3fe..68f7bf732c427 100644 --- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/components/shared/sources_table/sources_table.tsx @@ -26,7 +26,7 @@ export const SourcesTable: React.FC = ({ onSearchableToggle, }) => { return ( - + {SOURCE} {STATUS_HEADER} diff --git a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx index f72d4825aa040..f4a9790770ee4 100644 --- a/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx +++ b/x-pack/plugins/enterprise_search/public/applications/workplace_search/views/groups/components/group_source_prioritization.tsx @@ -123,7 +123,7 @@ export const GroupSourcePrioritization: React.FC = () => { ); const sourceTable = ( - + {SOURCE_TABLE_HEADER} {PRIORITY_TABLE_HEADER} diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx index 7f3880947782c..fd9a27ed66f01 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/details_page/components/package_policies/package_policies_table.tsx @@ -335,7 +335,6 @@ export const PackagePoliciesTable: React.FunctionComponent = ({ }, ], }} - isSelectable={false} /> ); }; diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx index a24ba5e7135a8..cdd804f60d484 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/list_page/index.tsx @@ -279,7 +279,6 @@ export const AgentPolicyListPage: React.FunctionComponent<{}> = () => { loading={isLoading} - hasActions={true} noItemsMessage={ isLoading ? ( = () => { items={agentPolicyData ? agentPolicyData.items : []} itemId="id" columns={columns} - isSelectable={false} pagination={{ pageIndex: pagination.currentPage - 1, pageSize: pagination.pageSize, diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx index dc4eea8b69e2d..1a1320e8b942a 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/agent_list_page/components/agent_list_table.tsx @@ -321,7 +321,6 @@ export const AgentListTable: React.FC = (props: Props) => { className="fleet__agentList__table" data-test-subj="fleetAgentListTable" loading={isLoading} - hasActions={true} noItemsMessage={noItemsMessage} items={ totalAgents @@ -338,7 +337,6 @@ export const AgentListTable: React.FC = (props: Props) => { totalItemCount: totalAgents, pageSizeOptions, }} - isSelectable={true} selection={ !authz.fleet.allAgents ? undefined diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx index 05b4ead4cc3ea..b72794868a1c2 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/agents/enrollment_token_list_page/index.tsx @@ -275,7 +275,6 @@ export const EnrollmentTokenListPage: React.FunctionComponent<{}> = () => { data-test-subj="enrollmentTokenListTable" loading={isLoading} - hasActions={true} noItemsMessage={ isLoading ? ( { }} onChange={handleTablePagination} noItemsMessage={} - hasActions={true} /> diff --git a/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx b/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx index daf4aff7079b8..29f672c012a2c 100644 --- a/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx +++ b/x-pack/plugins/fleet/public/applications/fleet/sections/data_stream/list_page/index.tsx @@ -193,7 +193,6 @@ export const DataStreamListPage: React.FunctionComponent<{}> = () => { return ( > ): TransformOptions['components'] => { return { - table: ({ children }) => ( - {children} - ), + table: ({ children }) => {children}, tr: ({ children }) => {children}, th: ({ children }) => {children}, td: ({ children }) => {children}, diff --git a/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx b/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx index b7278f79b0668..f6a579b58f09b 100644 --- a/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx +++ b/x-pack/plugins/index_lifecycle_management/__jest__/policy_table.test.tsx @@ -307,11 +307,11 @@ describe('policy table', () => { const policyName = findTestSubject(firstRow, 'policyTablePolicyNameLink').text(); expect(policyName).toBe(`${testPolicy.name}`); const policyIndexTemplates = findTestSubject(firstRow, 'policy-indexTemplates').text(); - expect(policyIndexTemplates).toBe(`Linked index templates${testPolicy.indexTemplates.length}`); + expect(policyIndexTemplates).toBe(`${testPolicy.indexTemplates.length}`); const policyIndices = findTestSubject(firstRow, 'policy-indices').text(); - expect(policyIndices).toBe(`Linked indices${testPolicy.indices.length}`); + expect(policyIndices).toBe(`${testPolicy.indices.length}`); const policyModifiedDate = findTestSubject(firstRow, 'policy-modifiedDate').text(); - expect(policyModifiedDate).toBe(`Modified date${testDateFormatted}`); + expect(policyModifiedDate).toBe(`${testDateFormatted}`); }); test('opens a flyout with index templates', () => { const rendered = mountWithIntl(component); diff --git a/x-pack/plugins/index_management/__jest__/components/index_table.test.js b/x-pack/plugins/index_management/__jest__/components/index_table.test.js index af3333d3201ef..721d6a65d92cf 100644 --- a/x-pack/plugins/index_management/__jest__/components/index_table.test.js +++ b/x-pack/plugins/index_management/__jest__/components/index_table.test.js @@ -75,7 +75,7 @@ const status = (rendered, row = 0) => { rendered.update(); return findTestSubject(rendered, 'indexTableCell-status') .at(row) - .find('.euiTableCellContent') + .find('div.euiTableCellContent') .text(); }; diff --git a/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx b/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx index 7f6eb87566410..68e6e9b74f4c2 100644 --- a/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx +++ b/x-pack/plugins/index_management/public/application/components/component_templates/component_template_list/table.tsx @@ -131,7 +131,6 @@ export const ComponentTable: FunctionComponent = ({ const tableProps: EuiInMemoryTableProps = { tableLayout: 'auto', itemId: 'name', - isSelectable: true, 'data-test-subj': 'componentTemplatesTable', sorting: { sort: { field: 'name', direction: 'asc' } }, selection: { diff --git a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/field_parameters/relations_parameter.tsx b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/field_parameters/relations_parameter.tsx index c9a3b49d9e048..f01d2d8699e25 100644 --- a/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/field_parameters/relations_parameter.tsx +++ b/x-pack/plugins/index_management/public/application/components/mappings_editor/components/document_fields/field_parameters/relations_parameter.tsx @@ -244,7 +244,6 @@ export const RelationsParameter = () => { defaultMessage: 'No relationship defined', } )} - hasActions /> {/* Add relation button */} diff --git a/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx index 97293c9a5f13b..8fc1e46bf0688 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/data_stream_list/data_stream_table/data_stream_table.tsx @@ -271,7 +271,6 @@ export const DataStreamTable: React.FunctionComponent = ({ columns={columns} search={searchConfig} sorting={sorting} - isSelectable={true} selection={selectionConfig} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx index 50140898ee090..ad0106869361f 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/enrich_policies_list/policies_table/policies_table.tsx @@ -169,7 +169,6 @@ export const PoliciesTable: FunctionComponent = ({ search={search} pagination={pagination} sorting={true} - isSelectable={false} /> ); }; diff --git a/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js b/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js index bdeb31a55343d..8ad11dbdbeb80 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js +++ b/x-pack/plugins/index_management/public/application/sections/home/index_list/index_table/index_table.js @@ -374,24 +374,11 @@ export class IndexTable extends Component { return columnConfigs.map((columnConfig) => { const { name } = index; const { fieldName } = columnConfig; - if (fieldName === 'name') { - return ( - -
- {this.buildRowCell(index, columnConfig)} -
- - ); - } return ( diff --git a/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx index 136fa6a63fa41..a390c28e78480 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/template_list/legacy_templates/template_table/template_table.tsx @@ -281,7 +281,6 @@ export const LegacyTemplateTable: React.FunctionComponent = ({ columns={columns} search={searchConfig} sorting={sorting} - isSelectable={true} selection={selectionConfig} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx b/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx index 4a08a93c9a0c4..775bc8aa34ff8 100644 --- a/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx +++ b/x-pack/plugins/index_management/public/application/sections/home/template_list/template_table/template_table.tsx @@ -282,7 +282,6 @@ export const TemplateTable: React.FunctionComponent = ({ columns={columns} search={searchConfig} sorting={sorting} - isSelectable={true} selection={selectionConfig} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx b/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx index f689f55e99742..8c50cc885e073 100644 --- a/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx +++ b/x-pack/plugins/ingest_pipelines/public/application/sections/pipelines_list/table.tsx @@ -114,7 +114,6 @@ export const PipelineTable: FunctionComponent = ({ const tableProps: EuiInMemoryTableProps = { itemId: 'name', - isSelectable: true, 'data-test-subj': 'pipelinesTable', sorting: { sort: { field: 'name', direction: 'asc' } }, selection: { diff --git a/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx b/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx index ca23cc220e3dd..9a4666788656b 100644 --- a/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx +++ b/x-pack/plugins/lens/public/datasources/form_based/dimension_panel/dimension_editor.tsx @@ -800,7 +800,7 @@ export function DimensionEditor(props: DimensionEditorProps) { compressed={true} rowHeader="firstName" columns={columnsSidebar} - responsive={false} + responsiveBreakpoint={false} /> diff --git a/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap b/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap index c552aebbd0164..2de5ed1f88cdf 100644 --- a/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap +++ b/x-pack/plugins/logstash/public/application/components/pipeline_list/__snapshots__/pipelines_table.test.js.snap @@ -39,7 +39,6 @@ exports[`PipelinesTable component renders component as expected 1`] = ` ] } data-test-subj="pipelineTable" - isSelectable={true} itemId="id" items={ Array [ @@ -62,7 +61,6 @@ exports[`PipelinesTable component renders component as expected 1`] = ` "totalItemCount": 1, } } - responsive={true} rowProps={ Object { "data-test-subj": "row", diff --git a/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js b/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js index 002c4818e0815..95a68649b052e 100644 --- a/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js +++ b/x-pack/plugins/logstash/public/application/components/pipeline_list/pipelines_table.js @@ -186,7 +186,6 @@ function PipelinesTableUi({ diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx index cc5c6d5ad1e75..73f50f51befc2 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/analytics_management/components/analytics_list/analytics_list.tsx @@ -280,10 +280,7 @@ export const DataFrameAnalyticsList: FC = ({ allowNeutralSort={false} columns={columns} - hasActions={false} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isSelectable={false} items={analytics} itemId={DataFrameAnalyticsListColumn.id} loading={isLoading} diff --git a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx index cbfe96f14ff9d..7878e58193b89 100644 --- a/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx +++ b/x-pack/plugins/ml/public/application/data_frame_analytics/pages/components/analytics_selector/analytics_id_selector.tsx @@ -238,7 +238,6 @@ export function AnalyticsIdSelector({ pagination={pagination} sorting={true} selection={selectionValue} - isSelectable={true} /> ), }, @@ -259,7 +258,6 @@ export function AnalyticsIdSelector({ pagination={pagination} sorting={true} selection={selectionValue} - isSelectable={true} /> ), }); diff --git a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js index b7988b0f71a81..c746d8003ce6b 100644 --- a/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js +++ b/x-pack/plugins/ml/public/application/jobs/jobs_list/components/jobs_list/jobs_list.js @@ -304,13 +304,10 @@ export class JobsList extends Component { field: 'latestTimestampSortValue', 'data-test-subj': 'mlJobListColumnLatestTimestamp', sortable: true, - render: (time, item) => ( - - {item.latestTimestampMs === undefined - ? '' - : moment(item.latestTimestampMs).format(TIME_FORMAT)} - - ), + render: (time, item) => + item.latestTimestampMs === undefined + ? '' + : moment(item.latestTimestampMs).format(TIME_FORMAT), textOnly: true, width: '15%', }, @@ -393,9 +390,7 @@ export class JobsList extends Component { onChange={this.onTableChange} selection={selectionControls} itemIdToExpandedRowMap={this.state.itemIdToExpandedRowMap} - isExpandable={true} sorting={sorting} - hasActions={true} rowProps={(item) => ({ 'data-test-subj': `mlJobListRow row-${item.id}`, })} diff --git a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx index 6f280a8da6de6..41b9c24c635b3 100644 --- a/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx +++ b/x-pack/plugins/ml/public/application/jobs/new_job/pages/components/pick_fields_step/components/advanced_detector_modal/function_help.tsx @@ -243,7 +243,7 @@ export const FunctionHelpPopover: FC = memo(() => { items={items} compressed={true} columns={columns} - responsive={false} + responsiveBreakpoint={false} /> diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx index d33c1a0c8bc40..f0ff64eae6445 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/allocated_models.tsx @@ -257,9 +257,6 @@ export const AllocatedModels: FC = ({ allowNeutralSort={false} columns={columns} - hasActions={false} - isExpandable={false} - isSelectable={false} items={models} itemId={'key'} rowProps={(item) => ({ diff --git a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx index 2fbb8ffb8a144..c6632adcefccf 100644 --- a/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx +++ b/x-pack/plugins/ml/public/application/memory_usage/nodes_overview/nodes_list.tsx @@ -220,10 +220,7 @@ export const NodesList: FC = ({ compactView = false }) => { allowNeutralSort={false} columns={columns} - hasActions={false} - isExpandable={true} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isSelectable={false} items={items} itemId={'id'} loading={isLoading} diff --git a/x-pack/plugins/ml/public/application/model_management/models_list.tsx b/x-pack/plugins/ml/public/application/model_management/models_list.tsx index b26014b57c065..8f4a9ae1e55f1 100644 --- a/x-pack/plugins/ml/public/application/model_management/models_list.tsx +++ b/x-pack/plugins/ml/public/application/model_management/models_list.tsx @@ -769,9 +769,6 @@ export const ModelsList: FC = ({
css={{ overflowX: 'auto' }} - isSelectable={true} - isExpandable={true} - hasActions={true} allowNeutralSort={false} columns={columns} itemIdToExpandedRowMap={itemIdToExpandedRowMap} diff --git a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx index 25e76c989bb4f..904fe5bcbe09c 100644 --- a/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx +++ b/x-pack/plugins/ml/public/application/model_management/pipelines/expanded_row.tsx @@ -170,9 +170,6 @@ export const ProcessorsStats: FC = ({ stats }) => { allowNeutralSort={false} columns={columns} - hasActions={false} - isExpandable={false} - isSelectable={false} items={items} itemId={'id'} rowProps={(item) => ({ diff --git a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx index 665e886516551..cb2f64c69050b 100644 --- a/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx +++ b/x-pack/plugins/ml/public/application/notifications/components/notifications_list.tsx @@ -397,9 +397,6 @@ export const NotificationsList: FC = () => { columns={columns} - hasActions={false} - isExpandable={false} - isSelectable={false} items={itemsPerPage} itemId={'id'} loading={isLoading} diff --git a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx index c6c715aa5cad5..5e24dd230ae82 100644 --- a/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/analytics_panel/table.tsx @@ -112,9 +112,6 @@ export const AnalyticsTable: FC = ({ items }) => { allowNeutralSort={false} className="mlAnalyticsTable" columns={columns} - hasActions={true} - isExpandable={false} - isSelectable={false} items={items} itemId={DataFrameAnalyticsListColumn.id} onTableChange={onTableChange} diff --git a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx index 2476a0d2a3bed..5531c1a4b578e 100644 --- a/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx +++ b/x-pack/plugins/ml/public/application/overview/components/anomaly_detection_panel/table.tsx @@ -186,9 +186,6 @@ export const AnomalyDetectionTable: FC = ({ items, chartsService }) => { allowNeutralSort={false} className="mlAnomalyDetectionTable" columns={columns} - hasActions={true} - isExpandable={false} - isSelectable={false} items={groupsList} itemId={AnomalyDetectionListColumns.id} onTableChange={onTableChange} diff --git a/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap b/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap index ba65f329cf735..2266fab97c439 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/calendars/edit/events_table/__snapshots__/events_table.test.js.snap @@ -56,7 +56,6 @@ exports[`EventsTable Renders events table with no search bar 1`] = ` ], } } - responsive={true} rowProps={[Function]} searchFormat="eql" sorting={ @@ -128,7 +127,6 @@ exports[`EventsTable Renders events table with search bar 1`] = ` ], } } - responsive={true} rowProps={[Function]} search={ Object { diff --git a/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap b/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap index d7da276215d10..6611dd20fc699 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/calendars/list/table/__snapshots__/table.test.js.snap @@ -34,7 +34,6 @@ exports[`CalendarsListTable renders the table with all calendars 1`] = ` ] } data-test-subj="mlCalendarTable loaded" - isSelectable={true} itemId="calendar_id" items={ Array [ @@ -66,7 +65,6 @@ exports[`CalendarsListTable renders the table with all calendars 1`] = ` ], } } - responsive={true} rowProps={[Function]} search={ Object { diff --git a/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js b/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js index 374ab80da118f..e9240557d2a68 100644 --- a/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js +++ b/x-pack/plugins/ml/public/application/settings/calendars/list/table/table.js @@ -142,7 +142,6 @@ export const CalendarsListTable = ({ sorting={sorting} loading={loading} selection={tableSelection} - isSelectable={true} data-test-subj={loading ? 'mlCalendarTable loading' : 'mlCalendarTable loaded'} rowProps={(item) => ({ 'data-test-subj': `mlCalendarListRow row-${item.calendar_id}`, diff --git a/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap b/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap index b5f0f5614145b..9ac0bcd5ce5bd 100644 --- a/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap +++ b/x-pack/plugins/ml/public/application/settings/filter_lists/list/__snapshots__/table.test.js.snap @@ -39,7 +39,6 @@ exports[`Filter Lists Table renders with filter lists and selection supplied 1`] ] } data-test-subj="mlFilterListsTable" - isSelectable={true} itemId="filter_id" items={ Array [ @@ -64,7 +63,6 @@ exports[`Filter Lists Table renders with filter lists and selection supplied 1`] ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { @@ -158,7 +156,6 @@ exports[`Filter Lists Table renders with filter lists supplied 1`] = ` ] } data-test-subj="mlFilterListsTable" - isSelectable={true} itemId="filter_id" items={ Array [ @@ -183,7 +180,6 @@ exports[`Filter Lists Table renders with filter lists supplied 1`] = ` ] } pagination={true} - responsive={true} rowProps={[Function]} search={ Object { diff --git a/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js b/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js index 6eadf71e4e725..a97c70d8c1a2c 100644 --- a/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js +++ b/x-pack/plugins/ml/public/application/settings/filter_lists/list/table.js @@ -213,7 +213,6 @@ export function FilterListsTable({ pagination={true} sorting={sorting} selection={tableSelection} - isSelectable={true} data-test-subj="mlFilterListsTable" rowProps={(item) => ({ 'data-test-subj': `mlFilterListRow row-${item.filter_id}`, diff --git a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap index c4ce91823ce03..fd33ec5254d2f 100644 --- a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_active.test.js.snap @@ -45,7 +45,6 @@ exports[`Latest Active that latest active component renders normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> `; diff --git a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap index 4b4f5ca654971..1a12f37e028b7 100644 --- a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_types.test.js.snap @@ -37,7 +37,6 @@ exports[`Latest Types that latest active component renders normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> `; diff --git a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap index 88e673eb8dcea..8318c6301a3f3 100644 --- a/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/beats/overview/__snapshots__/latest_versions.test.js.snap @@ -33,7 +33,6 @@ exports[`Latest Versions that latest active component renders normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> `; diff --git a/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap b/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap index 70d8be491f571..2cb56a0c9b424 100644 --- a/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/elasticsearch/ccr/__snapshots__/ccr.test.js.snap @@ -127,7 +127,6 @@ exports[`Ccr that it renders normally 1`] = ` ] } pagination={false} - responsive={true} searchFormat="eql" sorting={ Object { diff --git a/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap b/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap index e85ba5522bdf1..c558d98ea792b 100644 --- a/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap +++ b/x-pack/plugins/monitoring/public/components/logs/__snapshots__/logs.test.js.snap @@ -274,7 +274,6 @@ exports[`Logs should render normally 1`] = ` token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> - + + + ); diff --git a/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx b/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx index 0974b4ee63287..c77c3e7cc7a92 100644 --- a/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx +++ b/x-pack/plugins/observability_solution/apm/public/components/shared/overview_table_container/index.tsx @@ -42,8 +42,9 @@ const OverviewTableContainerDiv = euiStyled.div<{ flex-direction: column; flex-grow: 1; - > :first-child { - flex-grow: 1; + /* Align the pagination to the bottom of the card */ + > :last-child { + margin-top: auto; } `} diff --git a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx index 2629a00318da6..e4ef50266de2d 100644 --- a/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx +++ b/x-pack/plugins/observability_solution/dataset_quality/public/components/dataset_quality/table/table.tsx @@ -81,7 +81,6 @@ export const Table = () => { onChange={onTableChange} pagination={pagination} data-test-subj="datasetQualityTable" - isSelectable rowProps={{ 'data-test-subj': 'datasetQualityTableRow', }} diff --git a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx index 1e5e31b887911..42245552b664c 100644 --- a/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx +++ b/x-pack/plugins/observability_solution/infra/public/components/asset_details/tabs/metadata/add_pin_to_row.tsx @@ -6,8 +6,9 @@ */ import React, { Dispatch } from 'react'; +import { css } from '@emotion/css'; import { i18n } from '@kbn/i18n'; -import { EuiToolTip, EuiButtonIcon } from '@elastic/eui'; +import { EuiToolTip, EuiButtonIcon, useEuiTheme, euiCanAnimate } from '@elastic/eui'; import type { Field } from './utils'; interface AddMetadataPinToRowProps { @@ -25,6 +26,8 @@ export const AddMetadataPinToRow = ({ pinnedItems, onPinned, }: AddMetadataPinToRowProps) => { + const { euiTheme } = useEuiTheme(); + const handleAddPin = () => { onPinned([...pinnedItems, fieldName]); }; @@ -58,8 +61,22 @@ export const AddMetadataPinToRow = ({ ); } + // Custom table show on hover CSS, since this button is not technically in an action column + // Potential EUI TODO - multiple action columns and `align`ed actions are not currently supported + const showOnRowHoverCss = css` + opacity: 0; + ${euiCanAnimate} { + transition: opacity ${euiTheme.animation.normal} ${euiTheme.animation.resistance}; + } + + .euiTableRow:hover &, + &:focus-within { + opacity: 1; + } + `; + return ( - + { return ( { return ; @@ -173,10 +171,9 @@ export const Table = ({ loading, rows, onSearchChange, search, showActionsColumn + {columns.map((column) => ( @@ -252,6 +252,7 @@ const ProcessesTableBody = ({ items, currentTime }: TableBodyProps) => ( mobileOptions={{ header: column.name }} align={column.align ?? LEFT_ALIGNMENT} textOnly={column.textOnly ?? true} + truncateText={column.truncateText} > {column.render ? column.render(item[column.field], currentTime) : item[column.field]} @@ -291,6 +292,7 @@ const columns: Array<{ render?: Function; width?: string | number; textOnly?: boolean; + truncateText?: boolean; align?: typeof RIGHT_ALIGNMENT | typeof LEFT_ALIGNMENT; }> = [ { @@ -310,6 +312,7 @@ const columns: Array<{ }), sortable: false, width: '40%', + truncateText: true, render: (command: string) => , }, { diff --git a/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx b/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx index 0c1b656169033..b38af534df6e7 100644 --- a/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/components/ml/anomaly_detection/anomalies_table/anomalies_table.tsx @@ -531,7 +531,6 @@ export const AnomaliesTable = ({ items={results} sorting={{ sort: sorting }} onChange={onTableChange} - hasActions={true} loading={isLoading} noItemsMessage={ isLoading ? ( diff --git a/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx b/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx index 1e1f720a1ad67..34075a301c911 100644 --- a/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/pages/logs/log_entry_rate/sections/anomalies/table.tsx @@ -207,8 +207,6 @@ export const AnomaliesTable: React.FunctionComponent<{ items={tableItems} itemId="id" itemIdToExpandedRowMap={expandedIdsRowContents} - isExpandable={true} - hasActions={true} columns={columns} sorting={tableSortOptions} onChange={handleTableChange} diff --git a/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx b/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx index eaa1a14f37380..cc0b7302da20a 100644 --- a/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx +++ b/x-pack/plugins/observability_solution/infra/public/pages/metrics/hosts/components/hosts_table.tsx @@ -41,8 +41,9 @@ export const HostsTable = () => { /> { return items.sort(sortTableData(sorting)).slice(startIndex, endIndex); }, [items, pagination, sorting]); - const metricColumnsWidth = displayAlerts ? '11%' : '15%'; + const metricColumnsWidth = displayAlerts ? '12%' : '16%'; const columns: Array> = useMemo( () => [ @@ -360,7 +360,7 @@ export const useHostsTable = () => { formula={formulas?.rx.value} /> ), - width: '10%', + width: '12%', field: 'rx', sortable: true, 'data-test-subj': 'hostsView-tableRow-rx', @@ -375,7 +375,7 @@ export const useHostsTable = () => { formula={formulas?.tx.value} /> ), - width: '10%', + width: '12%', field: 'tx', sortable: true, 'data-test-subj': 'hostsView-tableRow-tx', diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx b/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx index a4d8532205fa8..337ae9503fe65 100644 --- a/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx +++ b/x-pack/plugins/observability_solution/observability_ai_assistant/public/components/message_panel/message_text.tsx @@ -5,6 +5,10 @@ * 2.0. */ import { + EuiTable, + EuiTableRow, + EuiTableRowCell, + EuiTableHeaderCell, EuiMarkdownFormat, EuiSpacer, EuiText, @@ -141,36 +145,21 @@ export function MessageText({ loading, content, onActionClick }: Props) { }, table: (props) => ( <> -
- {' '} - - + ), th: (props) => { const { children, ...rest } = props; - return ( - - ); + return {children}; }, - tr: (props) => , + tr: (props) => , td: (props) => { const { children, ...rest } = props; return ( - + + {children} + ); }, }; diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts index 46d9e00ccb774..b9a9b23d16ca7 100644 --- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts +++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/private_locations.journey.ts @@ -118,9 +118,9 @@ journey(`PrivateLocationsSettings`, async ({ page, params }) => { await page.click('[data-test-subj="settings-page-link"]'); await page.click('h1:has-text("Settings")'); await page.click('text=Private Locations'); - await page.waitForSelector('td:has-text("Monitors"):has-text("1")'); - await page.waitForSelector('td:has-text("Location nam"):has-text("Test private")'); - await page.click('.euiTableCellContent__hoverItem .euiToolTipAnchor'); + await page.waitForSelector('td:has-text("1")'); + await page.waitForSelector('td:has-text("Test private")'); + await page.click('.euiTableRowCell .euiToolTipAnchor'); await page.click('button:has-text("Tags")'); await page.click('[aria-label="Tags"] >> text=Area51'); await page.click( @@ -128,7 +128,7 @@ journey(`PrivateLocationsSettings`, async ({ page, params }) => { ); await page.click('text=Test private'); - await page.click('.euiTableCellContent__hoverItem .euiToolTipAnchor'); + await page.click('.euiTableRowCell .euiToolTipAnchor'); await page.locator(byTestId(`deleteLocation-${locationId}`)).isDisabled(); diff --git a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts index dcaf893dfa96b..ac931bbd1e725 100644 --- a/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts +++ b/x-pack/plugins/observability_solution/synthetics/e2e/synthetics/journeys/test_now_mode.journey.ts @@ -137,9 +137,7 @@ journey(`TestNowMode`, async ({ page, params }) => { await services.addTestSummaryDocument({ testRunId, docType: 'stepEnd', stepIndex: 1 }); await page.waitForSelector('text=1 step completed'); - await page.waitForSelector( - '.euiTableRowCell--hideForMobile :has-text("Go to https://www.google.com")' - ); + await page.waitForSelector('.euiTableRowCell:has-text("Go to https://www.google.com")'); expect(await page.getByTestId('stepDurationText1').first()).toHaveText('1.4 sec'); await page.waitForSelector('text=Complete'); }); diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx index f596b632fe158..114b206f95b24 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/common/monitor_test_result/browser_steps_list.tsx @@ -298,8 +298,6 @@ export const BrowserStepsList = ({ loading={loading} columns={columns} error={error?.message} - isExpandable={showExpand} - hasActions={false} items={stepEnds} noItemsMessage={ loading @@ -310,9 +308,9 @@ export const BrowserStepsList = ({ defaultMessage: 'No data found', }) } - tableLayout={'auto'} + tableLayout="auto" itemId="_id" - itemIdToExpandedRowMap={testNowMode ? expandedMap : undefined} + itemIdToExpandedRowMap={testNowMode || showExpand ? expandedMap : undefined} /> ); diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx index c61242fa2373b..f2d50b165d952 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/monitor_details/monitor_summary/test_runs_table.tsx @@ -293,16 +293,14 @@ export const TestRunsTable = ({ /> { - const { euiTheme } = useEuiTheme(); const isXl = useIsWithinMinBreakpoint('xxl'); const [monitorPendingDeletion, setMonitorPendingDeletion] = @@ -104,16 +102,13 @@ export const MonitorList = ({ <> {recordRangeLabel} - -
+ { items={filteredItems} columns={columns} tableLayout="auto" - isSelectable={canSave} pagination={true} sorting={{ sort: { field: 'key', direction: 'asc' }, diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx index 92714aa148174..a791028641ca3 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/step_details_page/step_waterfall_chart/waterfall/waterfall_flyout/waterfall_flyout_table.tsx @@ -67,9 +67,9 @@ export const Table = (props: Props) => { diff --git a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx index 830bd3edb2964..7d81ee24af68c 100644 --- a/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx +++ b/x-pack/plugins/observability_solution/synthetics/public/apps/synthetics/components/test_now_mode/simple/ping_list/ping_list_table.tsx @@ -115,8 +115,6 @@ export function PingListTable({ loading, error, pings, onChange }: Props) { loading={loading} columns={columns} error={error?.message} - isExpandable={true} - hasActions={true} items={pings} itemId="docId" itemIdToExpandedRowMap={expandedRows} @@ -129,7 +127,7 @@ export function PingListTable({ loading, error, pings, onChange }: Props) { defaultMessage: 'No history found', }) } - tableLayout={'auto'} + tableLayout="auto" onChange={onChange} /> ); diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx index 98ccc4524d48c..90c878d0982f5 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/ping_list/ping_list_table.tsx @@ -226,8 +226,6 @@ export function PingListTable({ loading, error, pings, pagination, onChange, fai loading={loading} columns={columns} error={error?.message} - isExpandable={true} - hasActions={true} items={pings} itemId="docId" itemIdToExpandedRowMap={expandedRows} @@ -241,7 +239,7 @@ export function PingListTable({ loading, error, pings, pagination, onChange, fai defaultMessage: 'No history found', }) } - tableLayout={'auto'} + tableLayout="auto" rowProps={getRowProps} onChange={onChange} /> diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx index 109416c3e8c84..a1f9b03c96c1a 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/monitor/status_details/availability_reporting/availability_reporting.tsx @@ -75,7 +75,7 @@ export const AvailabilityReporting: React.FC = ({ allLocations }) => { <> { diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx index 0543a2676791f..d206664c3bbaf 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/overview/monitor_list/monitor_list.tsx @@ -226,8 +226,6 @@ export const MonitorListComponent: ({ aria-label={labels.getDescriptionLabel(items.length)} error={error?.body?.message || error?.message} loading={loading || isPending} - isExpandable={true} - hasActions={true} itemId="monitor_id" itemIdToExpandedRowMap={getExpandedRowMap()} items={items} @@ -235,7 +233,7 @@ export const MonitorListComponent: ({ } columns={columns} - tableLayout={'auto'} + tableLayout="auto" rowProps={ hideExtraColumns ? ({ monitor_id: monitorId }) => ({ diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx index 00b40415adefb..82c5bbf472ece 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.test.tsx @@ -8,7 +8,7 @@ import React from 'react'; import { JourneyStep } from '../../../../../common/runtime_types/ping'; import { StepsList } from './steps_list'; -import { render, forDesktopOnly, forMobileOnly } from '../../../lib/helper/rtl_helpers'; +import { render } from '../../../lib/helper/rtl_helpers'; import { VIEW_PERFORMANCE } from '../../monitor/synthetics/translations'; describe('StepList component', () => { @@ -83,7 +83,7 @@ describe('StepList component', () => { ); expect(getByTestId('step-detail-link')).toHaveAttribute('href', '/journey/fake-group/step/1'); - expect(forDesktopOnly(getByTitle, 'title')(`Failed`)); + expect(getByTitle(`Failed`)).toBeInTheDocument(); }); it.each([ @@ -94,7 +94,7 @@ describe('StepList component', () => { const step = steps[0]; step.synthetics!.payload!.status = status; const { getByText } = render(); - expect(forDesktopOnly(getByText)(expectedStatus)); + expect(getByText(expectedStatus)).toBeInTheDocument(); }); it('creates expected message for all succeeded', () => { @@ -156,24 +156,27 @@ describe('StepList component', () => { }); describe('Mobile Designs', () => { - // We don't need to resize the window here because EUI - // does all the manipulation of what is displayed through - // CSS. Therefore, it's enough to check what's actually - // rendered and its classes. + const jestWindowWidth = window.innerWidth; + beforeAll(() => { + window.innerWidth = 600; + }); + afterAll(() => { + window.innerWidth = jestWindowWidth; + }); it('renders the step name and index', () => { const { getByText } = render( ); - expect(forMobileOnly(getByText)('1. load page')).toBeInTheDocument(); - expect(forMobileOnly(getByText)('2. go to login')).toBeInTheDocument(); + expect(getByText('1. load page')).toBeInTheDocument(); + expect(getByText('2. go to login')).toBeInTheDocument(); }); it('does not render the link to view step details', async () => { const { queryByText } = render( ); - expect(forMobileOnly(queryByText)(VIEW_PERFORMANCE)).not.toBeInTheDocument(); + expect(queryByText(VIEW_PERFORMANCE)).not.toBeInTheDocument(); }); it('renders the status label', () => { @@ -183,8 +186,8 @@ describe('StepList component', () => { const { getByText } = render( ); - expect(forMobileOnly(getByText)('Succeeded')).toBeInTheDocument(); - expect(forMobileOnly(getByText)('Skipped')).toBeInTheDocument(); + expect(getByText('Succeeded')).toBeInTheDocument(); + expect(getByText('Skipped')).toBeInTheDocument(); }); }); }); diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx index 4063671661647..70ffc6d7be859 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/components/synthetics/check_steps/steps_list.tsx @@ -236,8 +236,6 @@ export const StepsList = ({ loading={loading} columns={columns} error={error?.message} - isExpandable={true} - hasActions={true} items={steps} itemIdToExpandedRowMap={expandedRows} noItemsMessage={ @@ -249,7 +247,7 @@ export const StepsList = ({ defaultMessage: 'No history found', }) } - tableLayout={'auto'} + tableLayout="auto" rowProps={getRowProps} /> diff --git a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx index 0b23c089385d7..9ca652edb9cc4 100644 --- a/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx +++ b/x-pack/plugins/observability_solution/uptime/public/legacy_uptime/lib/helper/rtl_helpers.tsx @@ -356,38 +356,3 @@ export const makeUptimePermissionsCore = ( }, }; }; - -// This function filters out the queried elements which appear only -// either on mobile or desktop. -// -// It does so by filtering those with the class passed as the `classWrapper`. -// For mobile, we filter classes which tell elements to be hidden on desktop. -// For desktop, we do the opposite. -// -// We have this function because EUI will manipulate the visibility of some -// elements through pure CSS, which we can't assert on tests. Therefore, -// we look for the corresponding class wrapper. -const finderWithClassWrapper = - (classWrapper: string) => - ( - getterFn: (f: MatcherFunction) => HTMLElement | null, - customAttribute?: keyof Element | keyof HTMLElement - ) => - (text: string): HTMLElement | null => - getterFn((_content: string, node: Element | null) => { - if (!node) return false; - // There are actually properties that are not in Element but which - // appear on the `node`, so we must cast the customAttribute as a keyof Element - const content = node[(customAttribute as keyof Element) ?? 'innerHTML']; - if (content === text && wrappedInClass(node, classWrapper)) return true; - return false; - }); - -const wrappedInClass = (element: HTMLElement | Element, classWrapper: string): boolean => { - if (element.className.includes(classWrapper)) return true; - if (element.parentElement) return wrappedInClass(element.parentElement, classWrapper); - return false; -}; - -export const forMobileOnly = finderWithClassWrapper('hideForDesktop'); -export const forDesktopOnly = finderWithClassWrapper('hideForMobile'); diff --git a/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx b/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx index 45b85531a73de..e80b2d133d387 100644 --- a/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx +++ b/x-pack/plugins/observability_solution/ux/public/components/app/rum_dashboard/impactful_metrics/js_errors.tsx @@ -120,7 +120,7 @@ export function JSErrors() { }) : '' } - responsive={false} + responsiveBreakpoint={false} compressed={true} columns={cols} items={data?.items ?? []} diff --git a/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts b/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts index 05fb987bd0d07..4852db20f0bfd 100644 --- a/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts +++ b/x-pack/plugins/osquery/cypress/e2e/all/packs_create_edit.cy.ts @@ -579,7 +579,7 @@ describe('Packs - Create and Edit', { tags: ['@ess', '@serverless'] }, () => { return cy.get('tbody .euiTableRow > td:nth-child(5)').invoke('text'); }, - (response) => response !== 'Docs-', + (response) => response !== '-', { timeout: 300000, post: () => { diff --git a/x-pack/plugins/osquery/public/live_queries/form/pack_queries_status_table.tsx b/x-pack/plugins/osquery/public/live_queries/form/pack_queries_status_table.tsx index 7f65b498890e3..73d66481d94fc 100644 --- a/x-pack/plugins/osquery/public/live_queries/form/pack_queries_status_table.tsx +++ b/x-pack/plugins/osquery/public/live_queries/form/pack_queries_status_table.tsx @@ -419,7 +419,6 @@ const PackQueriesStatusTableComponent: React.FC = ( columns={columns} sorting={sorting} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable /> {queryDetailsFlyoutOpen ? ( diff --git a/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx b/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx index 89b1a6adacdad..f4f941a1254eb 100644 --- a/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx +++ b/x-pack/plugins/osquery/public/packs/pack_queries_status_table.tsx @@ -757,7 +757,6 @@ const PackQueriesStatusTableComponent: React.FC = ( columns={columns} sorting={sorting} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable /> ); }; diff --git a/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx b/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx index 60569ebaf184a..f3a76e98a4626 100644 --- a/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx +++ b/x-pack/plugins/osquery/public/packs/pack_queries_table.tsx @@ -181,7 +181,7 @@ const PackQueriesTableComponent: React.FC = ({ itemId={itemId} columns={columns} sorting={sorting} - {...(!isReadOnly ? { selection, isSelectable: true } : {})} + selection={isReadOnly ? undefined : selection} /> ); }; diff --git a/x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.js b/x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.js index 02357224d9a15..d5bd0b9537dae 100644 --- a/x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.js +++ b/x-pack/plugins/remote_clusters/public/application/sections/remote_cluster_list/remote_cluster_table/remote_cluster_table.js @@ -424,7 +424,6 @@ export class RemoteClusterTable extends Component { pagination={pagination} sorting={sorting} selection={selection} - isSelectable={true} data-test-subj="remoteClusterListTable" /> ); diff --git a/x-pack/plugins/reporting/public/management/report_listing_table.tsx b/x-pack/plugins/reporting/public/management/report_listing_table.tsx index 0b07ae38697e9..5cb113693c915 100644 --- a/x-pack/plugins/reporting/public/management/report_listing_table.tsx +++ b/x-pack/plugins/reporting/public/management/report_listing_table.tsx @@ -421,7 +421,6 @@ export class ReportListingTable extends Component { } pagination={pagination} selection={selection} - isSelectable={true} onChange={this.onTableChange} data-test-subj={REPORT_TABLE_ID} rowProps={() => ({ 'data-test-subj': REPORT_TABLE_ROW_ID })} diff --git a/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx b/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx index dbe89d489ef27..039fc8d85a73d 100644 --- a/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx +++ b/x-pack/plugins/search_playground/public/components/message_list/citations_table.tsx @@ -75,7 +75,6 @@ export const CitationsTable: React.FC = ({ citations }) => items={citationsWithId} itemId="id" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable /> ); }; diff --git a/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx b/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx index 50dcee6c283bf..86e7e9e3d5a6a 100644 --- a/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx +++ b/x-pack/plugins/search_playground/public/components/sources_panel/indices_table.tsx @@ -46,6 +46,5 @@ export const IndicesTable: React.FC = ({ indices, onRemoveCli ], }, ]} - hasActions /> ); diff --git a/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx b/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx index 834c4d4fd6054..0f717ecfe46c9 100644 --- a/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx +++ b/x-pack/plugins/security/public/management/api_keys/api_keys_grid/api_keys_grid_page.tsx @@ -518,7 +518,6 @@ export const ApiKeysTable: FunctionComponent = ({ pageSizeOptions: [10, 25, 50], }} loading={loading} - isSelectable={canManageOwnApiKeys} /> ); }; diff --git a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx index bebc0619e2a68..7f2182e1a7e67 100644 --- a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx +++ b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.test.tsx @@ -292,28 +292,22 @@ describe('RoleMappingsGridPage', () => { await nextTick(); wrapper.update(); - const editButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="editRoleMappingButton-some-realm"]' - ); + const editButton = wrapper.find('a[data-test-subj="editRoleMappingButton-some-realm"]'); expect(editButton).toHaveLength(1); expect(editButton.prop('href')).toBe('/edit/some-realm'); - const cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="cloneRoleMappingButton-some-realm"]' - ); + const cloneButton = wrapper.find('a[data-test-subj="cloneRoleMappingButton-some-realm"]'); expect(cloneButton).toHaveLength(1); expect(cloneButton.prop('href')).toBe('/clone/some-realm'); - const actionMenuButton = wrapper.find( - 'EuiButtonIcon[data-test-subj="euiCollapsedItemActionsButton"]' - ); + const actionMenuButton = wrapper.find('button[data-test-subj="euiCollapsedItemActionsButton"]'); expect(actionMenuButton).toHaveLength(1); actionMenuButton.simulate('click'); wrapper.update(); const deleteButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="deleteRoleMappingButton-some-realm"]' + 'button[data-test-subj="deleteRoleMappingButton-some-realm"]' ); expect(deleteButton).toHaveLength(1); }); @@ -371,30 +365,22 @@ describe('RoleMappingsGridPage', () => { await nextTick(); wrapper.update(); - const bulkButton = wrapper.find('EuiButtonEmpty[data-test-subj="bulkDeleteActionButton"]'); + const bulkButton = wrapper.find('[data-test-subj="bulkDeleteActionButton"]'); expect(bulkButton).toHaveLength(0); - const createButton = wrapper.find('EuiButton[data-test-subj="createRoleMappingButton"]'); + const createButton = wrapper.find('[data-test-subj="createRoleMappingButton"]'); expect(createButton).toHaveLength(0); - const editButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="editRoleMappingButton-some-realm"]' - ); + const editButton = wrapper.find('[data-test-subj="editRoleMappingButton-some-realm"]'); expect(editButton).toHaveLength(0); - const cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="cloneRoleMappingButton-some-realm"]' - ); + const cloneButton = wrapper.find('[data-test-subj="cloneRoleMappingButton-some-realm"]'); expect(cloneButton).toHaveLength(0); - const deleteButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="deleteRoleMappingButton-some-realm"]' - ); + const deleteButton = wrapper.find('[data-test-subj="deleteRoleMappingButton-some-realm"]'); expect(deleteButton).toHaveLength(0); - const actionMenuButton = wrapper.find( - 'EuiButtonIcon[data-test-subj="euiCollapsedItemActionsButton"]' - ); + const actionMenuButton = wrapper.find('[data-test-subj="euiCollapsedItemActionsButton"]'); expect(actionMenuButton).toHaveLength(0); }); }); diff --git a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx index ed733ac8d24b9..4ddcb83abf7f3 100644 --- a/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx +++ b/x-pack/plugins/security/public/management/role_mappings/role_mappings_grid/role_mappings_grid_page.tsx @@ -7,7 +7,6 @@ import type { EuiBasicTableColumn } from '@elastic/eui'; import { EuiButton, - EuiButtonEmpty, EuiCallOut, EuiFlexGroup, EuiFlexItem, @@ -16,7 +15,6 @@ import { EuiPageHeader, EuiPageSection, EuiSpacer, - EuiToolTip, } from '@elastic/eui'; import React, { Component } from 'react'; @@ -41,7 +39,6 @@ import { } from '../../management_urls'; import { RoleTableDisplay } from '../../role_table_display'; import type { RolesAPIClient } from '../../roles'; -import { ActionsEuiTableFormatting } from '../../table_utils'; import { DeleteProvider, NoCompatibleRealms, @@ -278,26 +275,22 @@ export class RoleMappingsGridPage extends Component { > {(deleteRoleMappingPrompt) => { return ( - - { - return { - 'data-test-subj': 'roleMappingRow', - }; - }} - /> - + { + return { + 'data-test-subj': 'roleMappingRow', + }; + }} + /> ); }} @@ -382,102 +375,63 @@ export class RoleMappingsGridPage extends Component { name: i18n.translate('xpack.security.management.roleMappings.actionsColumnName', { defaultMessage: 'Actions', }), - width: '80px', + width: '108px', actions: [ { isPrimary: true, - render: (record: RoleMapping) => { - const title = i18n.translate( - 'xpack.security.management.roleMappings.actionCloneTooltip', - { defaultMessage: 'Clone' } - ); - const label = i18n.translate( - 'xpack.security.management.roleMappings.actionCloneAriaLabel', - { - defaultMessage: `Clone '{name}'`, - values: { name: record.name }, - } - ); - return ( - - = 1} - {...reactRouterNavigate( - this.props.history, - getCloneRoleMappingHref(record.name) - )} - > - {title} - - - ); - }, + type: 'icon', + icon: 'copy', + name: i18n.translate('xpack.security.management.roleMappings.actionCloneTooltip', { + defaultMessage: 'Clone', + }), + description: (record: RoleMapping) => + i18n.translate('xpack.security.management.roleMappings.actionCloneAriaLabel', { + defaultMessage: `Clone '{name}'`, + values: { name: record.name }, + }), + href: (record: RoleMapping) => + reactRouterNavigate(this.props.history, getCloneRoleMappingHref(record.name)).href, + onClick: (record: RoleMapping, event: React.MouseEvent) => + reactRouterNavigate(this.props.history, getCloneRoleMappingHref(record.name)).onClick( + event + ), + 'data-test-subj': (record: RoleMapping) => `cloneRoleMappingButton-${record.name}`, }, { - render: (record: RoleMapping) => { - const title = i18n.translate( - 'xpack.security.management.roleMappings.actionDeleteTooltip', - { defaultMessage: 'Delete' } - ); - const label = i18n.translate( - 'xpack.security.management.roleMappings.actionDeleteAriaLabel', - { - defaultMessage: `Delete '{name}'`, - values: { name: record.name }, - } - ); - return ( - - = 1} - onClick={() => deleteRoleMappingPrompt([record], this.onRoleMappingsDeleted)} - > - {title} - - - ); - }, + type: 'icon', + icon: 'trash', + color: 'danger', + name: i18n.translate('xpack.security.management.roleMappings.actionDeleteTooltip', { + defaultMessage: 'Delete', + }), + description: (record: RoleMapping) => + i18n.translate('xpack.security.management.roleMappings.actionDeleteAriaLabel', { + defaultMessage: `Delete '{name}'`, + values: { name: record.name }, + }), + 'data-test-subj': (record: RoleMapping) => `deleteRoleMappingButton-${record.name}`, + onClick: (record: RoleMapping) => + deleteRoleMappingPrompt([record], this.onRoleMappingsDeleted), }, { isPrimary: true, - render: (record: RoleMapping) => { - const label = i18n.translate( - 'xpack.security.management.roleMappings.actionEditAriaLabel', - { - defaultMessage: `Edit '{name}'`, - values: { name: record.name }, - } - ); - const title = i18n.translate( - 'xpack.security.management.roleMappings.actionEditTooltip', - { defaultMessage: 'Edit' } - ); - return ( - - = 1} - {...reactRouterNavigate( - this.props.history, - getEditRoleMappingHref(record.name) - )} - > - {title} - - - ); - }, + type: 'icon', + icon: 'pencil', + name: i18n.translate('xpack.security.management.roleMappings.actionEditTooltip', { + defaultMessage: 'Edit', + }), + description: (record: RoleMapping) => + i18n.translate('xpack.security.management.roleMappings.actionEditAriaLabel', { + defaultMessage: `Edit '{name}'`, + values: { name: record.name }, + }), + 'data-test-subj': (record: RoleMapping) => `editRoleMappingButton-${record.name}`, + href: (record: RoleMapping) => + reactRouterNavigate(this.props.history, getEditRoleMappingHref(record.name)).href, + onClick: (record: RoleMapping, event: React.MouseEvent) => + reactRouterNavigate(this.props.history, getEditRoleMappingHref(record.name)).onClick( + event + ), }, ], }); diff --git a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx index cbbbc96863bda..530f6ffb2ee3c 100644 --- a/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx +++ b/x-pack/plugins/security/public/management/roles/edit_role/privileges/kibana/space_aware_privilege_section/privilege_space_table.tsx @@ -264,7 +264,6 @@ export class PrivilegeSpaceTable extends Component { { return { className: isGlobalPrivilegeDefinition(item.privileges) diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx index 6ca8dd1322cbf..ed6f28ea8321f 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.test.tsx @@ -144,34 +144,24 @@ describe('', () => { expect(wrapper.find(PermissionDenied)).toHaveLength(0); - let editButton = wrapper.find('EuiButtonEmpty[data-test-subj="edit-role-action-test-role-1"]'); + let editButton = wrapper.find('a[data-test-subj="edit-role-action-test-role-1"]'); expect(editButton).toHaveLength(1); expect(editButton.prop('href')).toBe('/edit/test-role-1'); - editButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="edit-role-action-special%chars%role"]' - ); + editButton = wrapper.find('a[data-test-subj="edit-role-action-special%chars%role"]'); expect(editButton).toHaveLength(1); expect(editButton.prop('href')).toBe('/edit/special%25chars%25role'); - let cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="clone-role-action-test-role-1"]' - ); + let cloneButton = wrapper.find('a[data-test-subj="clone-role-action-test-role-1"]'); expect(cloneButton).toHaveLength(1); expect(cloneButton.prop('href')).toBe('/clone/test-role-1'); - cloneButton = wrapper.find( - 'EuiButtonEmpty[data-test-subj="clone-role-action-special%chars%role"]' - ); + cloneButton = wrapper.find('a[data-test-subj="clone-role-action-special%chars%role"]'); expect(cloneButton).toHaveLength(1); expect(cloneButton.prop('href')).toBe('/clone/special%25chars%25role'); - expect( - wrapper.find('EuiButtonEmpty[data-test-subj="edit-role-action-disabled-role"]') - ).toHaveLength(1); - expect( - wrapper.find('EuiButtonEmpty[data-test-subj="clone-role-action-disabled-role"]') - ).toHaveLength(1); + expect(wrapper.find('a[data-test-subj="edit-role-action-disabled-role"]')).toHaveLength(1); + expect(wrapper.find('a[data-test-subj="clone-role-action-disabled-role"]')).toHaveLength(1); }); it('hides reserved roles when instructed to', async () => { diff --git a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx index 4273a31e207c9..a21d0a1e99912 100644 --- a/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx +++ b/x-pack/plugins/security/public/management/roles/roles_grid/roles_grid_page.tsx @@ -17,7 +17,6 @@ import { EuiSpacer, EuiSwitch, EuiText, - EuiToolTip, } from '@elastic/eui'; import _ from 'lodash'; import React, { Component } from 'react'; @@ -41,7 +40,6 @@ import { isRoleReserved, } from '../../../../common/model'; import { DeprecatedBadge, DisabledBadge, ReservedBadge } from '../../badges'; -import { ActionsEuiTableFormatting } from '../../table_utils'; import type { RolesAPIClient } from '../roles_api_client'; export interface Props extends StartServices { @@ -183,62 +181,54 @@ export class RolesGridPage extends Component { /> ) : null} - - !role.metadata || !role.metadata._reserved, - selectableMessage: (selectable: boolean) => - !selectable ? 'Role is reserved' : '', - onSelectionChange: (selection: Role[]) => this.setState({ selection }), - selected: this.state.selection, - } - } - pagination={{ - initialPageSize: 20, - pageSizeOptions: [10, 20, 30, 50, 100], - }} - message={emptyResultsMessage} - items={this.state.visibleRoles} - loading={isLoading} - search={{ - toolsLeft: this.renderToolsLeft(), - toolsRight: this.renderToolsRight(), - box: { - incremental: true, - 'data-test-subj': 'searchRoles', - }, - onChange: (query: Record) => { - this.setState({ - filter: query.queryText, - visibleRoles: this.getVisibleRoles( - this.state.roles, - query.queryText, - this.state.includeReservedRoles - ), - }); - }, - }} - sorting={{ - sort: { - field: 'name', - direction: 'asc', - }, - }} - rowProps={(_role: Role) => { - return { - 'data-test-subj': `roleRow`, - }; - }} - isSelectable - /> - + !role.metadata || !role.metadata._reserved, + selectableMessage: (selectable: boolean) => + !selectable ? 'Role is reserved' : '', + onSelectionChange: (selection: Role[]) => this.setState({ selection }), + selected: this.state.selection, + } + } + pagination={{ + initialPageSize: 20, + pageSizeOptions: [10, 20, 30, 50, 100], + }} + message={emptyResultsMessage} + items={this.state.visibleRoles} + loading={isLoading} + search={{ + toolsLeft: this.renderToolsLeft(), + toolsRight: this.renderToolsRight(), + box: { + incremental: true, + 'data-test-subj': 'searchRoles', + }, + onChange: (query: Record) => { + this.setState({ + filter: query.queryText, + visibleRoles: this.getVisibleRoles( + this.state.roles, + query.queryText, + this.state.includeReservedRoles + ), + }); + }, + }} + sorting={{ + sort: { + field: 'name', + direction: 'asc', + }, + }} + rowProps={{ 'data-test-subj': 'roleRow' }} + /> ); }; @@ -251,7 +241,7 @@ export class RolesGridPage extends Component { defaultMessage: 'Role', }), sortable: true, - render: (name: string, _record: Role) => { + render: (name: string) => { return ( { width: '150px', actions: [ { - available: (role: Role) => !isRoleReserved(role), + type: 'icon', + icon: 'copy', isPrimary: true, - render: (role: Role) => { - const title = i18n.translate('xpack.security.management.roles.cloneRoleActionName', { - defaultMessage: `Clone`, - }); - - const label = i18n.translate('xpack.security.management.roles.cloneRoleActionLabel', { - defaultMessage: `Clone {roleName}`, + available: (role: Role) => !isRoleReserved(role), + name: i18n.translate('xpack.security.management.roles.cloneRoleActionName', { + defaultMessage: 'Clone', + }), + description: (role: Role) => + i18n.translate('xpack.security.management.roles.cloneRoleActionLabel', { + defaultMessage: 'Clone {roleName}', values: { roleName: role.name }, - }); - - return ( - - = 1} - iconType={'copy'} - {...reactRouterNavigate( - this.props.history, - getRoleManagementHref('clone', role.name) - )} - > - {title} - - - ); - }, + }), + href: (role: Role) => + reactRouterNavigate(this.props.history, getRoleManagementHref('clone', role.name)) + .href, + onClick: (role: Role, event: React.MouseEvent) => + reactRouterNavigate( + this.props.history, + getRoleManagementHref('clone', role.name) + ).onClick(event), + 'data-test-subj': (role: Role) => `clone-role-action-${role.name}`, }, { + type: 'icon', + icon: 'trash', + color: 'danger', + name: i18n.translate('xpack.security.management.roles.deleteRoleActionName', { + defaultMessage: 'Delete', + }), + description: (role: Role) => + i18n.translate('xpack.security.management.roles.deleteRoleActionLabel', { + defaultMessage: `Delete {roleName}`, + values: { roleName: role.name }, + }), + 'data-test-subj': (role: Role) => `delete-role-action-${role.name}`, + onClick: (role: Role) => this.deleteOneRole(role), available: (role: Role) => !role.metadata || !role.metadata._reserved, - render: (role: Role) => { - const title = i18n.translate('xpack.security.management.roles.deleteRoleActionName', { - defaultMessage: `Delete`, - }); - - const label = i18n.translate( - 'xpack.security.management.roles.deleteRoleActionLabel', - { - defaultMessage: `Delete {roleName}`, - values: { roleName: role.name }, - } - ); - - return ( - - = 1} - iconType={'trash'} - onClick={() => this.deleteOneRole(role)} - > - {title} - - - ); - }, }, { - available: (role: Role) => !isRoleReadOnly(role), - enabled: () => this.state.selection.length === 0, isPrimary: true, - render: (role: Role) => { - const title = i18n.translate('xpack.security.management.roles.editRoleActionName', { - defaultMessage: `Edit`, - }); - - const label = i18n.translate('xpack.security.management.roles.editRoleActionLabel', { + type: 'icon', + icon: 'pencil', + name: i18n.translate('xpack.security.management.roles.editRoleActionName', { + defaultMessage: 'Edit', + }), + description: (role: Role) => + i18n.translate('xpack.security.management.roles.editRoleActionLabel', { defaultMessage: `Edit {roleName}`, values: { roleName: role.name }, - }); - - return ( - - = 1} - iconType={'pencil'} - {...reactRouterNavigate( - this.props.history, - getRoleManagementHref('edit', role.name) - )} - > - {title} - - - ); - }, + }), + 'data-test-subj': (role: Role) => `edit-role-action-${role.name}`, + href: (role: Role) => + reactRouterNavigate(this.props.history, getRoleManagementHref('edit', role.name)) + .href, + onClick: (role: Role, event: React.MouseEvent) => + reactRouterNavigate( + this.props.history, + getRoleManagementHref('edit', role.name) + ).onClick(event), + available: (role: Role) => !isRoleReadOnly(role), + enabled: () => this.state.selection.length === 0, }, ], }); diff --git a/x-pack/plugins/security/public/management/table_utils.tsx b/x-pack/plugins/security/public/management/table_utils.tsx deleted file mode 100644 index 74dd51f1cad85..0000000000000 --- a/x-pack/plugins/security/public/management/table_utils.tsx +++ /dev/null @@ -1,37 +0,0 @@ -/* - * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one - * or more contributor license agreements. Licensed under the Elastic License - * 2.0; you may not use this file except in compliance with the Elastic License - * 2.0. - */ -import { css } from '@emotion/react'; -import type { ReactNode } from 'react'; -import React from 'react'; - -interface ActionsEuiTableFormattingProps { - children: ReactNode; -} - -/* - * Notes to future engineer: - * We created this component because as this time EUI actions table where not allowing to pass - * props href on an action. In our case, we want our actions to work with href - * and onClick. Then the problem is that the design did not match with EUI example, therefore - * we are doing some css magic to only have icon showing up when user is hovering a row - */ -export const ActionsEuiTableFormatting = React.memo( - ({ children }) => ( -
- {children} -
- ) -); diff --git a/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx b/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx index 071de42046706..a9861850cf13e 100644 --- a/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx +++ b/x-pack/plugins/security/public/management/users/users_grid/users_grid_page.tsx @@ -282,7 +282,6 @@ export class UsersGridPage extends Component { search={search} sorting={sorting} rowProps={rowProps} - isSelectable /> } diff --git a/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx b/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx index e021fbca2bccc..c40b0c04043ad 100644 --- a/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx +++ b/x-pack/plugins/security_solution/public/assistant/get_comments/stream/message_text.tsx @@ -5,6 +5,10 @@ * 2.0. */ import { + EuiTable, + EuiTableRow, + EuiTableRowCell, + EuiTableHeaderCell, EuiMarkdownFormat, EuiSpacer, EuiText, @@ -114,36 +118,21 @@ const getPluginDependencies = () => { }, table: (props) => ( <> -
- {' '} -
- - - {children} - - -
-
- - {children} - -
-
- + ), th: (props) => { const { children, ...rest } = props; - return ( - - ); + return {children}; }, - tr: (props) => , + tr: (props) => , td: (props) => { const { children, ...rest } = props; return ( - + + {children} + ); }, }; diff --git a/x-pack/plugins/security_solution/public/common/components/conditions_table/__snapshots__/index.test.tsx.snap b/x-pack/plugins/security_solution/public/common/components/conditions_table/__snapshots__/index.test.tsx.snap index c14e0bb283de0..9f25007a5cb90 100644 --- a/x-pack/plugins/security_solution/public/common/components/conditions_table/__snapshots__/index.test.tsx.snap +++ b/x-pack/plugins/security_solution/public/common/components/conditions_table/__snapshots__/index.test.tsx.snap @@ -64,7 +64,6 @@ exports[`conditions_table ConditionsTable should render multi item table with an token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> @@ -135,7 +134,6 @@ exports[`conditions_table ConditionsTable should render multi item table with or token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> @@ -181,7 +179,6 @@ exports[`conditions_table ConditionsTable should render single item table correc token="euiBasicTable.noItemsMessage" /> } - responsive={true} tableLayout="fixed" /> diff --git a/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx b/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx index 0756992878518..570029e1c3c0b 100644 --- a/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx +++ b/x-pack/plugins/security_solution/public/common/components/event_details/event_fields_browser.test.tsx @@ -17,14 +17,6 @@ import { TimelineTabs } from '../../../../common/types/timeline'; jest.mock('../../lib/kibana'); -jest.mock('@elastic/eui', () => { - const original = jest.requireActual('@elastic/eui'); - return { - ...original, - EuiScreenReaderOnly: () => <>, - }; -}); - jest.mock('../../hooks/use_get_field_spec'); jest.mock('@kbn/cell-actions/src/hooks/use_load_actions', () => { @@ -129,8 +121,8 @@ describe('EventFieldsBrowser', () => { expect( wrapper - .find('.euiTableRow') - .find('.euiTableRowCell') + .find('tr.euiTableRow') + .find('td.euiTableRowCell') .at(1) .find('[data-euiicon-type]') .exists() @@ -168,8 +160,8 @@ describe('EventFieldsBrowser', () => { ); expect( wrapper - .find('.euiTableRow') - .find('.euiTableRowCell') + .find('tr.euiTableRow') + .find('td.euiTableRowCell') .at(1) .find('[data-euiicon-type]') .last() diff --git a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx index 712bd4650f14f..8426ccb39e0f7 100644 --- a/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx +++ b/x-pack/plugins/security_solution/public/common/components/ml_popover/jobs_table/jobs_table.tsx @@ -175,7 +175,7 @@ export const JobsTableComponent = ({ loading={isLoading} noItemsMessage={} pagination={pagination} - responsive={false} + responsiveBreakpoint={false} onChange={({ page }: { page: { index: number } }) => { setPageIndex(page.index); }} diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx index e30e2b6e6aa52..1171c22fbcea2 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_details_ui/pages/rule_details/execution_log_table/execution_log_table.tsx @@ -524,7 +524,6 @@ const ExecutionLogTableComponent: React.FC = ({ onChange={onTableChangeCallback} itemId={getItemId} itemIdToExpandedRowMap={rows.itemIdToExpandedRowMap} - isExpandable={true} /> ); diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx index 94ceb9337e674..87a735e442855 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_list/index.tsx @@ -61,7 +61,6 @@ const ExceptionsLinkedToListsComponent: React.FC diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx index e963c8d7707f9..a007cee4c1963 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_exceptions/components/flyout_components/linked_to_rule/index.test.tsx @@ -24,7 +24,7 @@ describe('ExceptionsLinkedToRule', () => { /> ); - expect(wrapper.find('[data-test-subj="ruleNameCell"]').at(0).text()).toEqual('NameMy rule'); + expect(wrapper.find('[data-test-subj="ruleNameCell"]').at(0).text()).toEqual('My rule'); expect(wrapper.find('[data-test-subj="linkToRuleSecuritySolutionLink"]').exists()).toBeTruthy(); }); }); diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx index e64645e967cc2..22794ab525dca 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/add_prebuilt_rules_table/add_prebuilt_rules_table.tsx @@ -86,7 +86,6 @@ export const AddPrebuiltRulesTable = React.memo(() => { initialPageSize: RULES_TABLE_INITIAL_PAGE_SIZE, pageSizeOptions: RULES_TABLE_PAGE_SIZE_OPTIONS, }} - isSelectable selection={{ selectable: () => true, onSelectionChange: selectRules, diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx index 707846c8a492a..4dfac4c0c2c39 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_management_ui/components/rules_table/rules_tables.tsx @@ -297,7 +297,6 @@ export const RulesTables = React.memo(({ selectedTab }) => { { initialPageSize: RULES_TABLE_INITIAL_PAGE_SIZE, pageSizeOptions: RULES_TABLE_PAGE_SIZE_OPTIONS, }} - isSelectable selection={{ selectable: () => true, onSelectionChange: selectRules, diff --git a/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx b/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx index f05636f9aced1..85870f7cda4e3 100644 --- a/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx +++ b/x-pack/plugins/security_solution/public/detection_engine/rule_monitoring/components/execution_events_table/execution_events_table.tsx @@ -123,7 +123,6 @@ const ExecutionEventsTableComponent: React.FC = ({ ru items={items} itemId={getItemId} itemIdToExpandedRowMap={rows.itemIdToExpandedRowMap} - isExpandable={true} loading={executionEvents.isFetching} sorting={sorting.state} pagination={pagination.state} diff --git a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx index 56aad747a856d..3740c7b2ef7df 100644 --- a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.test.tsx @@ -89,7 +89,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField0Key"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField0Key"] div.euiTableCellContent`) .hostNodes() .at(i) .text() @@ -114,7 +114,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="doc_count"] > div.euiTableCellContent`) + .find(`[data-test-subj="doc_count"] div.euiTableCellContent`) .hostNodes() .at(i) .text() @@ -144,7 +144,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField0Key"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField0Key"] div.euiTableCellContent`) .hostNodes() .at(resultRow++) .text() @@ -175,7 +175,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField1Key"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField1Key"] div.euiTableCellContent`) .hostNodes() .at(resultRow++) .text() @@ -206,7 +206,7 @@ describe('AlertsCount', () => { expect( wrapper - .find(`[data-test-subj="stackByField1DocCount"] > div.euiTableCellContent`) + .find(`[data-test-subj="stackByField1DocCount"] div.euiTableCellContent`) .hostNodes() .at(resultRow++) .text() diff --git a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx index 6c2e3fc008cfb..84fba825b5965 100644 --- a/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx +++ b/x-pack/plugins/security_solution/public/detections/components/alerts_kpis/alerts_count_panel/alerts_count.tsx @@ -88,13 +88,7 @@ export const AlertsCountComponent: React.FC = ({ return ( - + ); }; diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx index ee3c4cfd022d8..8c511ad19fe17 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.test.tsx @@ -242,7 +242,7 @@ describe('EntityAnalyticsAnomalies', () => { ); - expect(getByTestId('anomalies-table-column-count').textContent).toEqual('Count'); // 'Count' is always rendered by only displayed on mobile + expect(getByTestId('anomalies-table-column-count')).toHaveTextContent(''); }); it('renders a warning message when jobs are incompatible', () => { diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx index d841e59aeb67a..5102cb40124e2 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_analytics_anomalies/index.tsx @@ -194,7 +194,7 @@ export const EntityAnalyticsAnomalies = () => { )} { ); expect(queryByTestId('risk-input-asset-criticality-title')).not.toBeInTheDocument(); - expect(getByTestId('risk-input-table-description-cell')).toHaveTextContent( - 'Rule nameRule Name' - ); + expect(getByTestId('risk-input-table-description-cell')).toHaveTextContent('Rule Name'); }); it('Does not render the context section if enabled but no asset criticality', () => { diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx index 5532ec51a1054..bcf83d2cd9ad3 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/entity_details_flyout/tabs/risk_inputs/risk_inputs_tab.tsx @@ -176,13 +176,12 @@ export const RiskInputsTab = ({ entityType, entityName }: RiskInputsTabProps) => diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_score_preview_table.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_score_preview_table.tsx index 17a2e9f0f81f9..db03ddde63761 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_score_preview_table.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_score_preview_table.tsx @@ -85,10 +85,9 @@ export const RiskScorePreviewTable = ({ data-test-subj={ type === RiskScoreEntity.host ? 'host-risk-preview-table' : 'user-risk-preview-table' } - responsive={false} + responsiveBreakpoint={false} items={items} columns={columns} - loading={false} /> ); }; diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx index 8de14bdbf7521..c7debcdbdc965 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.test.tsx @@ -57,18 +57,12 @@ describe('RiskSummary', () => { // Alerts expect(getByTestId('risk-summary-table')).toHaveTextContent( - `Inputs${mockHostRiskScoreState.data?.[0].host.risk.category_1_count ?? 0}` - ); - expect(getByTestId('risk-summary-table')).toHaveTextContent( - `AlertsScore${mockHostRiskScoreState.data?.[0].host.risk.category_1_score ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count}` ); // Context expect(getByTestId('risk-summary-table')).not.toHaveTextContent( - `Inputs${mockHostRiskScoreState.data?.[0].host.risk.category_2_count ?? 0}` - ); - expect(getByTestId('risk-summary-table')).not.toHaveTextContent( - `ContextsScore${mockHostRiskScoreState.data?.[0].host.risk.category_2_score ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_2_count}` ); // Result row doesn't exist if alerts are the only category @@ -93,15 +87,12 @@ describe('RiskSummary', () => { // Alerts expect(getByTestId('risk-summary-table')).toHaveTextContent( - `Inputs${mockHostRiskScoreState.data?.[0].host.risk.category_1_count ?? 0}` - ); - expect(getByTestId('risk-summary-table')).toHaveTextContent( - `AlertsScore${mockHostRiskScoreState.data?.[0].host.risk.category_1_score ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count}` ); // Result expect(getByTestId('risk-summary-result-count')).toHaveTextContent( - `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count ?? 0}` + `${mockHostRiskScoreState.data?.[0].host.risk.category_1_count}` ); expect(getByTestId('risk-summary-result-score')).toHaveTextContent( diff --git a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx index 4b5a85f35ebe1..dc3471d46254c 100644 --- a/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx +++ b/x-pack/plugins/security_solution/public/entity_analytics/components/risk_summary_flyout/risk_summary.tsx @@ -261,7 +261,7 @@ const RiskSummaryComponent = ({ -
-
-
-
-
-
-
-
- - - {children} - - -
-
- - {children} - -
-
- - - + + - + - + - + - + - + - + - + - + - - - + + + + + - - - - -
-
+
+
+
- - User - + User -
+ +
- - Successes - + Successes -
+ +
- - Failures - + Failures -
+ +
- - Last success - + Last success -
+ +
- - Last successful source - + Last successful source -
+ +
- - Last successful destination - + Last successful destination -
+ +
- - Last failure - + Last failure -
+ +
- - Last failed source - + Last failed source -
+ +
- - Last failed destination - + Last failed destination -
-
- - No items found - -
-
-
+ No items found + +
+ + + +
-
-
-
-
-
-
-
- - - - + + - + - + - + - + - + - + - + - + - - - + + + + + - - - - -
-
+
+
+
- - User - + User -
+ +
- - Successes - + Successes -
+ +
- - Failures - + Failures -
+ +
- - Last success - + Last success -
+ +
- - Last successful source - + Last successful source -
+ +
- - Last successful destination - + Last successful destination -
+ +
- - Last failure - + Last failure -
+ +
- - Last failed source - + Last failed source -
+ +
- - Last failed destination - + Last failed destination -
-
- - No items found - -
-
-
+ No items found + +
+ + + +
{ ); - expect(wrapper.find('.euiTableRow').at(0).find('.euiTableRowCell').at(3).text()).toBe( - `Host names${getEmptyValue()}` + expect(wrapper.find('tr.euiTableRow').at(0).find('td.euiTableRowCell').at(3).text()).toBe( + `${getEmptyValue()}` ); }); @@ -78,8 +78,8 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(1).find('.euiTableRowCell').at(3).text()).toBe( - 'Host nameshello-world ' + expect(wrapper.find('tr.euiTableRow').at(1).find('td.euiTableRowCell').at(3).text()).toBe( + 'hello-world ' ); }); @@ -91,7 +91,7 @@ describe('Uncommon Process Table Component', () => { ); expect( - wrapper.find('.euiTableRow').at(1).find('.euiTableRowCell').at(3).find('a').length + wrapper.find('tr.euiTableRow').at(1).find('td.euiTableRowCell').at(3).find('a').length ).toBe(1); }); @@ -102,8 +102,8 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(2).find('.euiTableRowCell').at(3).text()).toBe( - 'Host nameshello-worldhello-world-2 ' + expect(wrapper.find('tr.euiTableRow').at(2).find('td.euiTableRowCell').at(3).text()).toBe( + 'hello-worldhello-world-2 ' ); }); @@ -115,7 +115,7 @@ describe('Uncommon Process Table Component', () => { ); expect( - wrapper.find('.euiTableRow').at(2).find('.euiTableRowCell').at(3).find('a').length + wrapper.find('tr.euiTableRow').at(2).find('td.euiTableRowCell').at(3).find('a').length ).toBe(2); }); @@ -125,8 +125,8 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(3).find('.euiTableRowCell').at(3).text()).toBe( - `Host names${getEmptyValue()}` + expect(wrapper.find('tr.euiTableRow').at(3).find('td.euiTableRowCell').at(3).text()).toBe( + `${getEmptyValue()}` ); }); @@ -137,7 +137,7 @@ describe('Uncommon Process Table Component', () => { ); expect( - wrapper.find('.euiTableRow').at(3).find('.euiTableRowCell').at(3).find('a').length + wrapper.find('tr.euiTableRow').at(3).find('td.euiTableRowCell').at(3).find('a').length ).toBe(0); }); @@ -147,8 +147,8 @@ describe('Uncommon Process Table Component', () => { ); - expect(wrapper.find('.euiTableRow').at(4).find('.euiTableRowCell').at(3).text()).toBe( - 'Host nameshello-worldhello-world-2 ' + expect(wrapper.find('tr.euiTableRow').at(4).find('td.euiTableRowCell').at(3).text()).toBe( + 'hello-worldhello-world-2 ' ); }); }); diff --git a/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx b/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx index 03a2485892dac..795044b240bb8 100644 --- a/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx +++ b/x-pack/plugins/security_solution/public/management/components/endpoint_response_actions_list/components/actions_log_table.tsx @@ -436,7 +436,6 @@ export const ActionsLogTable = memo( columns={columns} itemId="id" itemIdToExpandedRowMap={expandedRowMap} - isExpandable pagination={tablePagination} onChange={onChange} loading={loading} diff --git a/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx b/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx index fb875b3ceec3f..e6091d1f4776a 100644 --- a/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx +++ b/x-pack/plugins/security_solution/public/resolver/view/panel.test.tsx @@ -36,17 +36,17 @@ describe(`Resolver: when analyzing a tree with no ancestors and two children and * These are the details we expect to see in the node detail view when the origin is selected. */ const originEventDetailEntries: Array<[string, string]> = [ - ['Field@timestamp', 'ValueSep 23, 2020 @ 08:25:32.316'], - ['Fieldprocess.executable', 'Valueexecutable'], - ['Fieldprocess.pid', 'Value0'], - ['Fieldprocess.entity_id', 'Valueorigin'], - ['Fielduser.name', 'Valueuser.name'], - ['Fielduser.domain', 'Valueuser.domain'], - ['Fieldprocess.parent.pid', 'Value0'], - ['Fieldprocess.hash.md5', 'Valuehash.md5'], - ['Fieldprocess.args', 'Valueargs0'], - ['Fieldprocess.args', 'Valueargs1'], - ['Fieldprocess.args', 'Valueargs2'], + ['@timestamp', 'Sep 23, 2020 @ 08:25:32.316'], + ['process.executable', 'executable'], + ['process.pid', '0'], + ['process.entity_id', 'origin'], + ['user.name', 'user.name'], + ['user.domain', 'user.domain'], + ['process.parent.pid', '0'], + ['process.hash.md5', 'hash.md5'], + ['process.args', 'args0'], + ['process.args', 'args1'], + ['process.args', 'args2'], ]; beforeEach(() => { @@ -137,17 +137,17 @@ describe(`Resolver: when analyzing a tree with no ancestors and two children and }); it('should show the node details for the first child', async () => { await expect(simulator().map(() => simulator().nodeDetailEntries())).toYieldEqualTo([ - ['Field@timestamp', 'ValueSep 23, 2020 @ 08:25:32.317'], - ['Fieldprocess.executable', 'Valueexecutable'], - ['Fieldprocess.pid', 'Value1'], - ['Fieldprocess.entity_id', 'ValuefirstChild'], - ['Fielduser.name', 'Valueuser.name'], - ['Fielduser.domain', 'Valueuser.domain'], - ['Fieldprocess.parent.pid', 'Value0'], - ['Fieldprocess.hash.md5', 'Valuehash.md5'], - ['Fieldprocess.args', 'Valueargs0'], - ['Fieldprocess.args', 'Valueargs1'], - ['Fieldprocess.args', 'Valueargs2'], + ['@timestamp', 'Sep 23, 2020 @ 08:25:32.317'], + ['process.executable', 'executable'], + ['process.pid', '1'], + ['process.entity_id', 'firstChild'], + ['user.name', 'user.name'], + ['user.domain', 'user.domain'], + ['process.parent.pid', '0'], + ['process.hash.md5', 'hash.md5'], + ['process.args', 'args0'], + ['process.args', 'args1'], + ['process.args', 'args2'], ]); }); }); @@ -220,20 +220,19 @@ describe(`Resolver: when analyzing a tree with no ancestors and two children and return typesAndCounts; }) ).toYieldEqualTo([ - // Because there is no printed whitespace after "Count", the count immediately follows it. - { link: 'registry', type: 'Count2' }, - { link: 'authentication', type: 'Count1' }, - { link: 'database', type: 'Count1' }, - { link: 'driver', type: 'Count1' }, - { link: 'file', type: 'Count1' }, - { link: 'host', type: 'Count1' }, - { link: 'iam', type: 'Count1' }, - { link: 'intrusion_detection', type: 'Count1' }, - { link: 'malware', type: 'Count1' }, - { link: 'network', type: 'Count1' }, - { link: 'package', type: 'Count1' }, - { link: 'process', type: 'Count1' }, - { link: 'web', type: 'Count1' }, + { link: 'registry', type: '2' }, + { link: 'authentication', type: '1' }, + { link: 'database', type: '1' }, + { link: 'driver', type: '1' }, + { link: 'file', type: '1' }, + { link: 'host', type: '1' }, + { link: 'iam', type: '1' }, + { link: 'intrusion_detection', type: '1' }, + { link: 'malware', type: '1' }, + { link: 'network', type: '1' }, + { link: 'package', type: '1' }, + { link: 'process', type: '1' }, + { link: 'web', type: '1' }, ]); }); describe('and when the user clicks the registry events link', () => { diff --git a/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx b/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx index c62d05a25d69a..b4841b68810f7 100644 --- a/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx +++ b/x-pack/plugins/security_solution/public/timelines/components/open_timeline/timelines_table/index.tsx @@ -230,8 +230,6 @@ export const TimelinesTable = React.memo( ); }; diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx index 0e56c47abc430..2097a139adebe 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/policy_list/policy_table/policy_table.tsx @@ -418,7 +418,6 @@ export const PolicyTable: React.FunctionComponent = ({ sorting={sorting} selection={selection} pagination={pagination} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx index abfd7e6f1b624..a6fb6b10ae4a0 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/repository_list/repository_table/repository_table.tsx @@ -300,7 +300,6 @@ export const RepositoryTable: React.FunctionComponent = ({ sorting={sorting} selection={selection} pagination={pagination} - isSelectable={true} rowProps={() => ({ 'data-test-subj': 'row', })} diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/restore_list/restore_table/restore_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/restore_list/restore_table/restore_table.tsx index edb097cecb796..ff5f904770aa1 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/restore_list/restore_table/restore_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/restore_list/restore_table/restore_table.tsx @@ -191,7 +191,6 @@ export const RestoreTable: React.FunctionComponent = React.memo(({ restor items={getRestores()} itemId="index" itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable={true} columns={columns} sorting={getSorting()} pagination={getPagination()} diff --git a/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx b/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx index 1272d841173c6..7204bb4bc3895 100644 --- a/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx +++ b/x-pack/plugins/snapshot_restore/public/application/sections/home/snapshot_list/components/snapshot_table.tsx @@ -330,7 +330,6 @@ export const SnapshotTable: React.FunctionComponent = (props: Props) => { }); }} loading={isLoading} - isSelectable={true} selection={selection} pagination={pagination} rowProps={() => ({ diff --git a/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx b/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx index d557fcdb604bb..6d2cd1a9bd05d 100644 --- a/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx +++ b/x-pack/plugins/spaces/public/management/spaces_grid/spaces_grid_page.tsx @@ -130,7 +130,6 @@ export class SpacesGridPage extends Component { })} rowHeader="name" columns={this.getColumnConfig()} - hasActions pagination={true} sorting={true} search={{ diff --git a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx index df67a4e16ba5c..b70de170df611 100644 --- a/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx +++ b/x-pack/plugins/transform/public/app/sections/transform_management/components/transform_list/transform_list.tsx @@ -350,9 +350,6 @@ export const TransformList: FC = ({ className="transform__TransformTable" columns={columns} error={searchError} - hasActions={false} - isExpandable={true} - isSelectable={false} items={filteredTransforms} itemId={TRANSFORM_LIST_COLUMN.ID} itemIdToExpandedRowMap={itemIdToExpandedRowMap} diff --git a/x-pack/plugins/translations/translations/fr-FR.json b/x-pack/plugins/translations/translations/fr-FR.json index dde0b0f63fd56..d14910cd195cd 100644 --- a/x-pack/plugins/translations/translations/fr-FR.json +++ b/x-pack/plugins/translations/translations/fr-FR.json @@ -692,7 +692,6 @@ "core.euiAutoRefresh.buttonLabelOff": "L'actualisation automatique est désactivée", "core.euiBasicTable.noItemsMessage": "Aucun élément n'a été trouvé", "core.euiBasicTable.selectAllRows": "Sélectionner toutes les lignes", - "core.euiBasicTable.selectThisRow": "Sélectionner cette ligne", "core.euiBottomBar.screenReaderAnnouncement": "Il y a un nouveau repère de région avec des commandes de niveau de page à la fin du document.", "core.euiBottomBar.screenReaderHeading": "Commandes de niveau de page", "core.euiBreadcrumb.collapsedBadge.ariaLabel": "Voir le fil d’Ariane réduit", diff --git a/x-pack/plugins/translations/translations/ja-JP.json b/x-pack/plugins/translations/translations/ja-JP.json index 4705c43ac0166..b705bc247e9b0 100644 --- a/x-pack/plugins/translations/translations/ja-JP.json +++ b/x-pack/plugins/translations/translations/ja-JP.json @@ -692,7 +692,6 @@ "core.euiAutoRefresh.buttonLabelOff": "自動更新はオフです", "core.euiBasicTable.noItemsMessage": "項目が見つかりません", "core.euiBasicTable.selectAllRows": "すべての行を選択", - "core.euiBasicTable.selectThisRow": "この行を選択", "core.euiBottomBar.screenReaderAnnouncement": "ドキュメントの最後には、新しいリージョンランドマークとページレベルのコントロールがあります。", "core.euiBottomBar.screenReaderHeading": "ページレベルのコントロール", "core.euiBreadcrumb.collapsedBadge.ariaLabel": "折りたたまれたブレッドクラムを表示", diff --git a/x-pack/plugins/translations/translations/zh-CN.json b/x-pack/plugins/translations/translations/zh-CN.json index af6c1e6110591..286bd4c5c707e 100644 --- a/x-pack/plugins/translations/translations/zh-CN.json +++ b/x-pack/plugins/translations/translations/zh-CN.json @@ -694,7 +694,6 @@ "core.euiAutoRefresh.buttonLabelOff": "自动刷新已关闭", "core.euiBasicTable.noItemsMessage": "找不到项目", "core.euiBasicTable.selectAllRows": "选择所有行", - "core.euiBasicTable.selectThisRow": "选择此行", "core.euiBottomBar.screenReaderAnnouncement": "有页面级别控件位于文档结尾的新地区地标。", "core.euiBottomBar.screenReaderHeading": "页面级别控件", "core.euiBreadcrumb.collapsedBadge.ariaLabel": "查看折叠的痕迹导航", diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx index 66d7705a1bd12..ae0f5d7670f1a 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/field_items.tsx @@ -12,8 +12,6 @@ import { EuiFlexGroup, EuiFlexItem, EuiBadge, - EuiBasicTableColumn, - EuiTableActionsColumnType, EuiScreenReaderOnly, } from '@elastic/eui'; import { uniqBy } from 'lodash/fp'; @@ -189,8 +187,3 @@ export const getFieldColumns = ({ ? getFieldTableColumns({ highlight, onHide }) : getDefaultFieldTableColumns({ highlight })), ]; - -/** Returns whether the table column has actions attached to it */ -export const isActionsColumn = (column: EuiBasicTableColumn): boolean => { - return !!(column as EuiTableActionsColumnType).actions?.length; -}; diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts index 103d94a29e151..d783e8cd7f095 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_items/index.ts @@ -5,4 +5,4 @@ * 2.0. */ -export { getFieldItemsData, getFieldColumns, isActionsColumn } from './field_items'; +export { getFieldItemsData, getFieldColumns } from './field_items'; diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx index eb2962c9af20f..c5bf664776301 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/field_browser/components/field_table/field_table.tsx @@ -7,7 +7,7 @@ import React, { useCallback, useEffect, useMemo, useState } from 'react'; import { EuiInMemoryTable, Pagination, Direction, useEuiTheme } from '@elastic/eui'; import { BrowserFields } from '@kbn/rule-registry-plugin/common'; -import { getFieldColumns, getFieldItemsData, isActionsColumn } from '../field_items'; +import { getFieldColumns, getFieldItemsData } from '../field_items'; import { CATEGORY_TABLE_CLASS_NAME, TABLE_HEIGHT } from '../../helpers'; import type { FieldBrowserProps, GetFieldTableColumns } from '../../types'; import { FieldTableHeader } from './field_table_header'; @@ -128,7 +128,6 @@ const FieldTableComponent: React.FC = ({ }), [getFieldTableColumns, searchInput, onHide, onToggleColumn] ); - const hasActions = useMemo(() => columns.some((column) => isActionsColumn(column)), [columns]); return ( <> @@ -147,7 +146,6 @@ const FieldTableComponent: React.FC = ({ columns={columns} pagination={pagination} sorting={sorting} - hasActions={hasActions} onChange={onTableChange} compressed /> diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx index c586aba931682..4066f088ad10e 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rule_details/components/rule_error_log.test.tsx @@ -176,7 +176,7 @@ describe('rule_error_log', () => { }); expect(wrapper.find(EuiSuperDatePicker).props().isLoading).toBeFalsy(); - expect(wrapper.find('.euiTableRow').length).toEqual(10); + expect(wrapper.find('tr.euiTableRow').length).toEqual(10); nowMock.mockRestore(); }); diff --git a/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx b/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx index 0f1f42b475a35..0652d5416f0a8 100644 --- a/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx +++ b/x-pack/plugins/triggers_actions_ui/public/application/sections/rules_list/components/rules_list_table.tsx @@ -944,7 +944,6 @@ export const RulesListTable = (props: RulesListTableProps) => { } }} itemIdToExpandedRowMap={itemIdToExpandedRowMap} - isExpandable={true} /> diff --git a/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx b/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx index 37d73d0c8a25a..2a3dc8fc09444 100644 --- a/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx +++ b/x-pack/plugins/watcher/public/application/sections/watch_list_page/watch_list_page.tsx @@ -515,7 +515,6 @@ export const WatchListPage = () => { }, }} selection={selectionConfig} - isSelectable={true} childrenBetween={ queryError && ( <> diff --git a/x-pack/test/functional/page_objects/tag_management_page.ts b/x-pack/test/functional/page_objects/tag_management_page.ts index 68100ef3ad6db..9f8c91f084eda 100644 --- a/x-pack/test/functional/page_objects/tag_management_page.ts +++ b/x-pack/test/functional/page_objects/tag_management_page.ts @@ -381,7 +381,7 @@ export class TagManagementPageObject extends FtrService { async clickEdit(tagName: string) { const tagRow = await this.getRowByName(tagName); if (tagRow) { - const editButton = await this.testSubjects.findDescendant('tagsTableAction-edit', tagRow); + const editButton = await tagRow.findByTestSubject('tagsTableAction-edit'); await editButton?.click(); } } diff --git a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts index c85e38cd78b8e..3279013f98069 100644 --- a/x-pack/test/functional/services/ml/data_frame_analytics_table.ts +++ b/x-pack/test/functional/services/ml/data_frame_analytics_table.ts @@ -147,11 +147,15 @@ export function MachineLearningDataFrameAnalyticsTableProvider({ } public async assertJobRowViewButtonExists(analyticsId: string) { - await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobViewButton')); + await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobViewButton'), { + allowHidden: true, // Table action may be only visible on row hover + }); } public async assertJobRowMapButtonExists(analyticsId: string) { - await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobMapButton')); + await testSubjects.existOrFail(this.rowSelector(analyticsId, 'mlAnalyticsJobMapButton'), { + allowHidden: true, // Table action may be only visible on row hover + }); } public async assertJobRowViewButtonEnabled(analyticsId: string, expectedValue: boolean) { diff --git a/x-pack/test/functional/services/ml/stack_management_jobs.ts b/x-pack/test/functional/services/ml/stack_management_jobs.ts index 63c2005650c0d..bbf985d4c0d67 100644 --- a/x-pack/test/functional/services/ml/stack_management_jobs.ts +++ b/x-pack/test/functional/services/ml/stack_management_jobs.ts @@ -446,7 +446,7 @@ export function MachineLearningStackManagementJobsProvider({ const ids: string[] = []; for (const row of rows) { - const cols = await row.findAllByClassName('euiTableRowCell euiTableRowCell--middle'); + const cols = await row.findAllByClassName('euiTableRowCell'); if (cols.length) { ids.push(await cols[0].getVisibleText()); } diff --git a/yarn.lock b/yarn.lock index d0e2a6e1736a1..1ebcab60a14c3 100644 --- a/yarn.lock +++ b/yarn.lock @@ -1752,10 +1752,10 @@ resolved "https://registry.yarnpkg.com/@elastic/eslint-plugin-eui/-/eslint-plugin-eui-0.0.2.tgz#56b9ef03984a05cc213772ae3713ea8ef47b0314" integrity sha512-IoxURM5zraoQ7C8f+mJb9HYSENiZGgRVcG4tLQxE61yHNNRDXtGDWTZh8N1KIHcsqN1CEPETjuzBXkJYF/fDiQ== -"@elastic/eui@93.6.0": - version "93.6.0" - resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-93.6.0.tgz#9a5892164a4457ba0382a76b63731eeed10dfb89" - integrity sha512-o6TEgSE+mOJmZYtMm+xYMeFQoOcoGTQOMWwRBCkP1efEPAlqjeBnUeahco8jKM3kqTeah+jMLm/A02ZjRwU+GA== +"@elastic/eui@94.1.0-backport.0": + version "94.1.0-backport.0" + resolved "https://registry.yarnpkg.com/@elastic/eui/-/eui-94.1.0-backport.0.tgz#93ad707b12785a7e0198af333cdee8d1acdcf35e" + integrity sha512-WFUpYBUgbJfcJInjhyQpOYGFs7JGpBMwpgmbRbKmyf3bJb0yqZeaiL5Qwyk6hOl8j1CSRvcaWOT/P33JxdrV3w== dependencies: "@hello-pangea/dnd" "^16.3.0" "@types/lodash" "^4.14.202"