From b56ed4c12fae7c503b1a00c2748bd3cdea9da6f9 Mon Sep 17 00:00:00 2001
From: Kibana Machine <42973632+kibanamachine@users.noreply.github.com>
Date: Tue, 7 Jan 2025 22:30:16 +1100
Subject: [PATCH] [8.17] [Obs ai assistant] - bug bulk import for knowledge
 base (#205075) (#205687)
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

# Backport

This will backport the following commits from `main` to `8.17`:
- [[Obs ai assistant] - bug bulk import for knowledge base
(#205075)](https://github.com/elastic/kibana/pull/205075)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Arturo
Lidueña","email":"arturo.liduena@elastic.co"},"sourceCommit":{"committedDate":"2025-01-07T09:44:16Z","message":"[Obs
ai assistant] - bug bulk import for knowledge base (#205075)\n\nCloses
#196096 \r\n\r\n## Summary\r\n\r\nWrong successful message with error
notification pop up on adding a\r\nwrong format file under bulk import
for knowledge
base\r\n[#196096](https://github.com/elastic/kibana/issues/196096)\r\n\r\n---------\r\n\r\nCo-authored-by:
Søren Louv-Jansen <sorenlouv@gmail.com>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2c97ed3bfec8a99de931d85f50b1e940835bde47","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix","v9.0.0","Team:Obs
AI
Assistant","v8.16.0","backport:version","v8.17.0","v8.18.0"],"title":"[Obs
ai assistant] - bug bulk import for knowledge
base","number":205075,"url":"https://github.com/elastic/kibana/pull/205075","mergeCommit":{"message":"[Obs
ai assistant] - bug bulk import for knowledge base (#205075)\n\nCloses
#196096 \r\n\r\n## Summary\r\n\r\nWrong successful message with error
notification pop up on adding a\r\nwrong format file under bulk import
for knowledge
base\r\n[#196096](https://github.com/elastic/kibana/issues/196096)\r\n\r\n---------\r\n\r\nCo-authored-by:
Søren Louv-Jansen <sorenlouv@gmail.com>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2c97ed3bfec8a99de931d85f50b1e940835bde47"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.17","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/205075","number":205075,"mergeCommit":{"message":"[Obs
ai assistant] - bug bulk import for knowledge base (#205075)\n\nCloses
#196096 \r\n\r\n## Summary\r\n\r\nWrong successful message with error
notification pop up on adding a\r\nwrong format file under bulk import
for knowledge
base\r\n[#196096](https://github.com/elastic/kibana/issues/196096)\r\n\r\n---------\r\n\r\nCo-authored-by:
Søren Louv-Jansen <sorenlouv@gmail.com>\r\nCo-authored-by: kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"2c97ed3bfec8a99de931d85f50b1e940835bde47"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.17","label":"v8.17.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Arturo Lidueña <arturo.liduena@elastic.co>
---
 .../components/knowledge_base_bulk_import_flyout.tsx | 12 ++++++++----
 1 file changed, 8 insertions(+), 4 deletions(-)

diff --git a/x-pack/plugins/observability_solution/observability_ai_assistant_management/public/routes/components/knowledge_base_bulk_import_flyout.tsx b/x-pack/plugins/observability_solution/observability_ai_assistant_management/public/routes/components/knowledge_base_bulk_import_flyout.tsx
index 23d5ad00af12a..b1ac694bc9929 100644
--- a/x-pack/plugins/observability_solution/observability_ai_assistant_management/public/routes/components/knowledge_base_bulk_import_flyout.tsx
+++ b/x-pack/plugins/observability_solution/observability_ai_assistant_management/public/routes/components/knowledge_base_bulk_import_flyout.tsx
@@ -47,13 +47,18 @@ export function KnowledgeBaseBulkImportFlyout({ onClose }: { onClose: () => void
   };
 
   const handleSubmitNewEntryClick = async () => {
-    let entries: Array<Omit<KnowledgeBaseEntry, '@timestamp' | 'title'> & { title: string }> = [];
     const text = await files[0].text();
 
     const elements = text.split('\n').filter(Boolean);
 
     try {
-      entries = elements.map((el) => JSON.parse(el));
+      const entries = elements.map(
+        (el) =>
+          JSON.parse(el) as Omit<KnowledgeBaseEntry, '@timestamp' | 'title'> & {
+            title: string;
+          }
+      );
+      await mutateAsync({ entries });
     } catch (_) {
       toasts.addError(
         new Error(
@@ -74,8 +79,7 @@ export function KnowledgeBaseBulkImportFlyout({ onClose }: { onClose: () => void
         }
       );
     }
-
-    mutateAsync({ entries }).then(onClose);
+    onClose();
   };
 
   return (