Skip to content

Change handling, when no licence was found #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Change handling, when no licence was found #19

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
89a90d6
Change handling, when no licence was found
Dec 12, 2022
d7a6b8b
Change handling, when no licence type was found
Dec 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions detector/detector.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"fmt"
"io"
"io/ioutil"
"log"
"path/filepath"
"regexp"
"strings"
Expand Down Expand Up @@ -170,17 +171,20 @@ func doDetectLicences(licenceRegex *regexp.Regexp, classifier *licenseclassifier
// detect the licence type if the override hasn't provided one
if depInfo.LicenceType == "" {
if depInfo.LicenceFile == "" {
return nil, fmt.Errorf("no licence file found for %s. Add an override entry with licence type to continue.", depInfo.Name)
log.Printf("Skipping %s because no licence was found.\n", depInfo.Name)
continue
}

var err error
depInfo.LicenceType, err = detectLicenceType(classifier, depInfo.LicenceFile)
if err != nil {
return nil, fmt.Errorf("failed to detect licence type of %s from %s: %w", depInfo.Name, depInfo.LicenceFile, err)
log.Printf("Failed to detect licence type of %s. Skipping it!\n", depInfo.Name)
//return nil, fmt.Errorf("failed to detect licence type of %s from %s: %w", depInfo.Name, depInfo.LicenceFile, err)
}

if depInfo.LicenceType == "" {
return nil, fmt.Errorf("licence unknown for %s. Add an override entry with licence type to continue.", depInfo.Name)
log.Printf("Skipping %s because no licence was found.\n", depInfo.Name)
continue
}
}

Expand Down