From 40d8759237940c5a9bb9ebcaf4c28775064565a2 Mon Sep 17 00:00:00 2001 From: Alexey Antonov Date: Thu, 27 Jun 2024 12:14:43 +0300 Subject: [PATCH 1/3] [File Picker] update aria-label for `Remove` button Closes: https://github.com/elastic/observability-dev/issues/3641 # Conflicts: # packages/eui/src/components/form/file_picker/file_picker.tsx --- .../src/components/form/file_picker/file_picker.tsx | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/eui/src/components/form/file_picker/file_picker.tsx b/packages/eui/src/components/form/file_picker/file_picker.tsx index 38b530fb34d..038d2b929eb 100644 --- a/packages/eui/src/components/form/file_picker/file_picker.tsx +++ b/packages/eui/src/components/form/file_picker/file_picker.tsx @@ -144,10 +144,10 @@ export class EuiFilePickerClass extends Component< return ( - {(clearSelectedFiles: string) => { + {(removeSelectedFiles: string) => { const { stylesMemoizer, id, @@ -244,7 +244,7 @@ export class EuiFilePickerClass extends Component< if (normalFormControl) { clearButton = ( Date: Thu, 27 Jun 2024 12:41:28 +0300 Subject: [PATCH 2/3] add changelog --- packages/eui/changelogs/upcoming/7860.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 packages/eui/changelogs/upcoming/7860.md diff --git a/packages/eui/changelogs/upcoming/7860.md b/packages/eui/changelogs/upcoming/7860.md new file mode 100644 index 00000000000..d9975a4cf1b --- /dev/null +++ b/packages/eui/changelogs/upcoming/7860.md @@ -0,0 +1,3 @@ +**Accessibility** + +- Updated the `aria-label` attribute for the `EuiFilePicker` remove file button From ccae8beef2f6e5b05e508f340b22c2b068e96cce Mon Sep 17 00:00:00 2001 From: Cee Chen <549407+cee-chen@users.noreply.github.com> Date: Thu, 27 Jun 2024 09:35:35 -0700 Subject: [PATCH 3/3] [PR feedback] Token var name --- .../eui/src/components/form/file_picker/file_picker.tsx | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/packages/eui/src/components/form/file_picker/file_picker.tsx b/packages/eui/src/components/form/file_picker/file_picker.tsx index 038d2b929eb..43a32d20ee6 100644 --- a/packages/eui/src/components/form/file_picker/file_picker.tsx +++ b/packages/eui/src/components/form/file_picker/file_picker.tsx @@ -144,10 +144,10 @@ export class EuiFilePickerClass extends Component< return ( - {(removeSelectedFiles: string) => { + {(removeSelectedAriaLabel: string) => { const { stylesMemoizer, id, @@ -244,7 +244,7 @@ export class EuiFilePickerClass extends Component< if (normalFormControl) { clearButton = (