-
Notifications
You must be signed in to change notification settings - Fork 839
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EuiBreadcrumbs] Not visually clear if a breadcrumb has a link #7330
Comments
Assuming we wish to maintain the minimalistic nature of these breadcrumbs (which I personally do), the first areas that come to mind where we could apply such visual affordance for linked vs. non-linked breadcrumbs are font weight and color. Currently, it looks like we use a font weight of Perhaps we could update these styles with the following subtle changes to accommodate for a light affordance prior to the user attempting to hover/focus:
It's subtle, but I think it's enough of an offset to indicate to users that something is different about them, without hurting the minimalism of the component. What do you think, @ryankeairns? |
Agreed. I briefly poked around at this yesterday and also noted the general use of the +1 for the proposed changes. |
Going to be annoying and insert my non-designer opinion: that is absolutely too subtle for me to notice at a glance personally, especially at smaller font sizes 😅 (or, e.g. for users with low vision acuity). Could we consider the good old "underline if a link and do not underline if not" pattern, which is generally held to be an accessibility best practice? |
It's easy enough to try and see how it looks. Let's take a peek when this reaches the PR stage. |
This issue was moved to a discussion.
You can continue the conversation there. Go to discussion →
For the new serverless navigation in Kibana we're changing the look of breadcrumbs from
EuiHeaderBreadcrumbs
toEuiBreadcrumbs
elastic/kibana#166593Currently in
EuiBreadcrumbs
it it not visually clear if a breadcrumb has a link or not, for example comparing toEuiHeaderBreadcrumbs
:https://codesandbox.io/s/thirsty-cray-5xspnj?file=/demo.tsx
Do you think we could change this and add a visual difference between a crumb with and without a link in the default
EuiBreadcrumbs
look?cc @MichaelMarcialis @ryankeairns
The text was updated successfully, but these errors were encountered: