Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EuiBreadcrumbs] Not visually clear if a breadcrumb has a link #7330

Closed
Dosant opened this issue Oct 31, 2023 · 4 comments
Closed

[EuiBreadcrumbs] Not visually clear if a breadcrumb has a link #7330

Dosant opened this issue Oct 31, 2023 · 4 comments

Comments

@Dosant
Copy link
Contributor

Dosant commented Oct 31, 2023

For the new serverless navigation in Kibana we're changing the look of breadcrumbs from EuiHeaderBreadcrumbs to EuiBreadcrumbs elastic/kibana#166593

Currently in EuiBreadcrumbs it it not visually clear if a breadcrumb has a link or not, for example comparing to EuiHeaderBreadcrumbs:

Screenshot 2023-10-31 at 13 59 59
https://codesandbox.io/s/thirsty-cray-5xspnj?file=/demo.tsx

Do you think we could change this and add a visual difference between a crumb with and without a link in the default EuiBreadcrumbs look?

cc @MichaelMarcialis @ryankeairns

@MichaelMarcialis
Copy link
Contributor

MichaelMarcialis commented Nov 2, 2023

Assuming we wish to maintain the minimalistic nature of these breadcrumbs (which I personally do), the first areas that come to mind where we could apply such visual affordance for linked vs. non-linked breadcrumbs are font weight and color.

Currently, it looks like we use a font weight of 500 for all breadcrumbs. The current/active breadcrumb uses our default text color, while all other breadcrumbs use our subdued text color. On hover/focus of a linked breadcrumb, an underline decoration is added. Without hovering/focusing, the user won't know if a breadcrumb is a link or not.

CleanShot 2023-11-02 at 12 54 27

Perhaps we could update these styles with the following subtle changes to accommodate for a light affordance prior to the user attempting to hover/focus:

  • All breadcrumbs switch to 400 font weight, except the current/active breadcrumb (which stays at the current 500).
  • Linked breadcrumbs switch to using the default text color (instead of subdued).

CleanShot 2023-11-02 at 13 09 39

It's subtle, but I think it's enough of an offset to indicate to users that something is different about them, without hurting the minimalism of the component. What do you think, @ryankeairns?

@ryankeairns
Copy link
Contributor

Agreed. I briefly poked around at this yesterday and also noted the general use of the subdued color. As has been stated with the proposed changes, they are subtle may be all that is needed.

+1 for the proposed changes.

@cee-chen
Copy link
Contributor

cee-chen commented Nov 3, 2023

Going to be annoying and insert my non-designer opinion: that is absolutely too subtle for me to notice at a glance personally, especially at smaller font sizes 😅 (or, e.g. for users with low vision acuity).

Could we consider the good old "underline if a link and do not underline if not" pattern, which is generally held to be an accessibility best practice?

@ryankeairns
Copy link
Contributor

Going to be annoying and insert my non-designer opinion: that is absolutely too subtle for me to notice at a glance personally, especially at smaller font sizes 😅 (or, e.g. for users with low vision acuity).

Could we consider the good old "underline if a link and do not underline if not" pattern, which is generally held to be an accessibility best practice?

It's easy enough to try and see how it looks. Let's take a peek when this reaches the PR stage.

@elastic elastic locked and limited conversation to collaborators Nov 6, 2023
@JasonStoltz JasonStoltz converted this issue into discussion #7345 Nov 6, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Projects
None yet
Development

No branches or pull requests

4 participants