Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Emotion] Merge override SCSS into baseline SCSS #7042

Closed
10 tasks
cee-chen opened this issue Aug 7, 2023 · 2 comments
Closed
10 tasks

[Emotion] Merge override SCSS into baseline SCSS #7042

cee-chen opened this issue Aug 7, 2023 · 2 comments
Labels
good first issue meta task A task associated with a larger Meta issue

Comments

@cee-chen
Copy link
Contributor

cee-chen commented Aug 7, 2023

List of components with Amsterdam override SCSS

Preview Give feedback

See https://github.com/elastic/eui/blob/main/src/themes/amsterdam/overrides

@cee-chen cee-chen added meta task A task associated with a larger Meta issue labels Aug 7, 2023
@cee-chen cee-chen changed the title [Emotion] Merge override SCSS into baseline SCSS ahead of time for un-converted components [Emotion] Merge override SCSS into baseline SCSS Aug 7, 2023
@yaodada123
Copy link

Hello, I would like to contribute to the project on this issue. Now that I have successfully run the project locally and have found the EuiKeyPadMenuItem style file code, as shown in the figure, can you give me further hints as to what I should do to accomplish this task?
QQ图片20240702164409

@cee-chen
Copy link
Contributor Author

cee-chen commented Jul 5, 2024

Hey @yaodada123 - apologies, this task is actually out of date at this point. EuiKeyPadMenuItem has already been converted to Emotion and as such no longer has any SCSS to update. I'm going to go ahead and close this issue out as not planned.

@cee-chen cee-chen closed this as not planned Won't fix, can't repro, duplicate, stale Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue meta task A task associated with a larger Meta issue
Projects
None yet
Development

No branches or pull requests

3 participants