Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] Add a deprecation plugin to warn on deprecated code #6914

Open
1Copenut opened this issue Jul 6, 2023 · 5 comments
Open

[ESLint] Add a deprecation plugin to warn on deprecated code #6914

1Copenut opened this issue Jul 6, 2023 · 5 comments
Labels
good first issue help wanted The EUI team is looking for community members to pick up and implement this issue tech debt

Comments

@1Copenut
Copy link
Contributor

1Copenut commented Jul 6, 2023

Is your feature request related to a problem? Please describe.
We identified a legacy document method to copy text to the clipboard in #6912 and realized we don't currently lint for deprecated code.

Describe the solution you'd like
We would like to add ESLint-plugin-deprecation to warn (could also error) on deprecated code. It'd help us identify areas for improvement and keep EUI current with browsers.

The project has two dependencies, both of which are already in the EUI package.json file:

  • @typescript-eslint/parser
  • typescript
@cee-chen cee-chen added tech debt good first issue help wanted The EUI team is looking for community members to pick up and implement this issue and removed feature request labels Jul 10, 2023
@github-actions
Copy link

👋 Thank you for your suggestion or request! While the EUI team agrees that it's valid, it's unlikely that we will prioritize this issue on our roadmap. We'll leave the issue open if you or anyone else in the community wants to implement it by contributing to EUI. If not, this issue will auto close in one year.

@Param-Singh
Copy link

Hi all can someone please assign this issue to me
I would like to work on adding this plugin

@JasonStoltz
Copy link
Member

Hi @Param-Singh, per our contributing policy, we do not assign issues to non-core contributors. You are welcome to work on it, however, and submit a PR.

https://github.com/elastic/eui/tree/main/wiki/contributing-to-eui#who-can-contribute

If you find an issue that is not assigned, assume that you are welcome to work on it and can submit a pull request. We recommend that you leave us a comment indicating your intent before starting work to avoid potential conflict. We do not, as a policy, assign issues to community members

Copy link

👋 Hi there - this issue hasn't had any activity in 6 months. If the EUI team has not explicitly expressed that this is something on our roadmap, it's unlikely that we'll pick this issue up. We would sincerely appreciate a PR/community contribution if this is something that matters to you! If not, and there is no further activity on this issue for another 6 months (i.e. it's stale for over a year), the issue will be auto-closed.

@Cedgo1997
Copy link

Hello! I would like to contribute with this issue. Actually I just made a PR (#8198 ) a couple of weeks ago, but I don't really know what is the process to expect a review. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue help wanted The EUI team is looking for community members to pick up and implement this issue tech debt
Projects
None yet
Development

No branches or pull requests

5 participants