From 15cb3504187045b111b3370862e366f55b1bdbc1 Mon Sep 17 00:00:00 2001 From: 1Copenut Date: Thu, 7 Dec 2023 10:26:50 -0600 Subject: [PATCH] Adding EuiTabs guidance cross-link to EuiBreadcrumbs. --- src-docs/src/views/breadcrumbs/breadcrumbs_example.js | 7 +++++++ src-docs/src/views/tabs/tabs_guidance.js | 10 ++++++++-- 2 files changed, 15 insertions(+), 2 deletions(-) diff --git a/src-docs/src/views/breadcrumbs/breadcrumbs_example.js b/src-docs/src/views/breadcrumbs/breadcrumbs_example.js index 1f0c72bfee3..9d3ec472d66 100644 --- a/src-docs/src/views/breadcrumbs/breadcrumbs_example.js +++ b/src-docs/src/views/breadcrumbs/breadcrumbs_example.js @@ -57,6 +57,13 @@ export const BreadcrumbsExample = { {' '} should be used for application-wide navigation.

+

+ See{' '} + + EuiTabs guidelines + {' '} + if your application requires breadcrumbs and tabs on the same view. +

), sections: [ diff --git a/src-docs/src/views/tabs/tabs_guidance.js b/src-docs/src/views/tabs/tabs_guidance.js index b4294782b0b..308fbaf9111 100644 --- a/src-docs/src/views/tabs/tabs_guidance.js +++ b/src-docs/src/views/tabs/tabs_guidance.js @@ -1,4 +1,5 @@ import React from 'react'; +import { Link } from 'react-router-dom'; import { EuiCode, @@ -42,8 +43,13 @@ export default () => (

Tabs must not update higher-level navigation

Do not update navigation such as{' '} - breadcrumbs or{' '} - navigation menus{' '} + + breadcrumbs + {' '} + or{' '} + + navigation menus + {' '} when users click on tabs. Tabs show localized information and it is not always clear what changed if tabs are below the fold or navigation does not match the route.