SearchQueryThenFetchAsyncAction - close properly byte stream on failure

[drempapis]

Reviewing the class, I noticed that the onShardDone method has a potential leak on the exception path.

If writeSuccessfulResponse(out) or writeReductionFailureResponse(...) throws, the code enters the catch (IOException e) block and returns without releasing out.

In the success path, ownership of the buffer is correctly transferred via out.moveToBytesReference() and ActionListener.respondAndRelease(...), which ensures the bytes are released. However, in the failure path, the stream remains open and its underlying buffer is never returned to the recycler.

[elasticsearchmachine]

Pinging @elastic/es-search-foundations (Team:Search Foundations)

[drempapis]

@elasticmachine run elasticsearch-ci/part-2

[benchaplin]

Looks good thanks Dimi, I missed this piece in my recent change.

[elasticsearchmachine]

💔 Backport failed

Status	Branch	Result
❌	9.1	Commit could not be cherrypicked due to conflicts
❌	9.2	Commit could not be cherrypicked due to conflicts

You can use sqren/backport to manually backport by running backport --upstream elastic/elasticsearch --pr 137810

[drempapis]

💚 All backports created successfully

Status	Branch	Result
✅	9.2
✅	9.1

Questions ?

Please refer to the Backport tool documentation