chore: migration to vite+ #5709
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying egg with
|
| Latest commit: |
32730ce
|
| Status: | 🚫 Build failed. |
Deploying egg-v3 with
|
| Latest commit: |
32730ce
|
| Status: | 🚫 Build failed. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the Eggjs monorepo from oxlint/oxfmt tooling to vite+ (a custom tooling suite from VoidZero). The migration consolidates linting, formatting, and testing under a unified vite-based toolchain.
Key Changes:
- Replaces oxlint/oxfmt with vite+ commands across all packages and scripts
- Migrates vitest to @voidzero-dev/vite-plus-test package alias
- Introduces centralized vite.config.ts for format and lint configuration
- Adds GitHub package registry authentication for @voidzero-dev packages
Reviewed changes
Copilot reviewed 42 out of 43 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| vite.config.ts | New centralized configuration file migrating settings from .oxlintrc.json and .oxfmtrc.json |
| pnpm-workspace.yaml | Updates catalog to replace oxlint/oxfmt with vite+ packages; adds peer dependency rules and overrides |
| .npmrc | Configures GitHub package registry authentication for @voidzero-dev scoped packages |
| package.json (root) | Updates scripts to use vite commands; replaces oxlint/oxfmt devDependencies with @voidzero-dev/vite-plus |
| .oxlintrc.json | Removed - configuration migrated to vite.config.ts |
| .oxfmtrc.json | Removed - configuration migrated to vite.config.ts |
| packages/*/package.json | Updates lint/test scripts from oxlint/vitest to vite lint/vite test; removes oxlint devDependencies |
| plugins/*/package.json | Updates lint/test scripts from oxlint/vitest to vite lint/vite test; removes oxlint devDependencies |
| tools/*/package.json | Updates lint/test scripts from oxlint/vitest to vite lint/vite test; removes oxlint devDependencies |
| examples/*/package.json | Updates test scripts from vitest to vite test; updates lint commands in some examples |
| vite: 'catalog:' | ||
| vitest: 'catalog:' |
There was a problem hiding this comment.
The overrides section now forces both vite and vitest to use the catalog versions (which are aliased to @voidzero-dev packages). This is a significant change from the previous rolldown-vite@^7.1.13 override. Ensure that:
- All packages that depend on vite/vitest are compatible with the vite+ versions
- This doesn't break any existing functionality that relied on the rolldown-vite fork
- The change is intentional and has been tested across all workspace packages
This is a critical override that affects the entire monorepo's build and test infrastructure.
.npmrc
Outdated
| //npm.pkg.github.com/:_authToken=${GITHUB_TOKEN} | ||
| @voidzero-dev:registry=https://npm.pkg.github.com/ |
There was a problem hiding this comment.
The GitHub token is being referenced via environment variable ${GITHUB_TOKEN}, but there's no validation or fallback if this variable is not set. This could cause silent failures during package installation. Consider:
- Documenting this requirement in README or CONTRIBUTING.md
- Adding validation in CI/CD pipelines to ensure GITHUB_TOKEN is set
- Providing clear error messages when the token is missing
Additionally, ensure this token has appropriate read permissions for the @voidzero-dev scope packages.
| peerDependencyRules: | ||
| allowAny: | ||
| - vite | ||
| - vitest | ||
| allowedVersions: | ||
| vite: '*' | ||
| vitest: '*' |
There was a problem hiding this comment.
The peerDependencyRules configuration uses allowAny and allowedVersions: '*' for both vite and vitest. This effectively disables peer dependency version checking, which could lead to compatibility issues. While this may be necessary for the vite+ migration, consider:
- Whether this is a temporary workaround or permanent solution
- Adding documentation explaining why these broad permissions are needed
- Testing thoroughly to ensure no breaking changes occur from version mismatches
This configuration makes the build less strict and could hide incompatibility issues.
| - oxlint-tsgolint | ||
| - oxlint | ||
| - oxc-minify | ||
| - '@voidzero-dev/*' |
There was a problem hiding this comment.
The minimumReleaseAgeExclude list still references oxlint-tsgolint, oxlint, and oxc-minify (lines 240-242), but these packages have been removed from the catalog and are no longer used in the project. While adding @voidzero-dev/* to the exclusion list is correct, consider also removing the obsolete oxlint-related entries to keep the configuration clean and up-to-date.
fengmk2
force-pushed
the
vite-plus-migration4
branch
from
b55ec07 to
38adb66
Compare
Codecov Report✅ All modified and coverable lines are covered by tests.
Additional details and impacted files@@ Coverage Diff @@
## next #5709 +/- ##
===========================================
- Coverage 87.41% 70.58% -16.83%
===========================================
Files 561 1 -560
Lines 10932 17 -10915
Branches 1238 6 -1232
===========================================
- Hits 9556 12 -9544
+ Misses 1292 5 -1287
+ Partials 84 0 -84 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.