Why visitor_convert() has an extra argument true

[stefanos82]

In file lualib/nelua/analyzer.lua at line 1404 we have argnode, argtype = visitor_convert(context, argnodes, i, funcargtype, argnode, argtype, argattrs, true) where visitor_convert() adds an extra argument true.

Is it because of callargs?

Should I "see" it as ... or varargs?

[stefanos82]

I can also see the same behavior in file lualib/nelua/cgenerator.lua at line 818 cgenerator.emit_close_scope(context, emitter, scope, true), even though the function signature is function cgenerator.emit_close_scope(context, emitter, scope).

What is the purpose of true in this case?

[cpaybcho]

Those extra true arguments seem unnecessary.

I found a few more similar cases in lualib/nelua/preprocessor.lua:

1. At line 109: ppcontext:traverse_nodes(argnodes, emitter, node, 3)
2. At line 136: ppcontext:traverse_nodes(annotnodes, emitter, node, 5)

The traverse_nodes function is defined as function PPContext:traverse_nodes(nodes, emitter), so the extra arguments (node and 3/5) are ignored.

[stefanos82]

Thank you @cpaybcho 😃 for a moment I thought I've lost my mind! 🤣 I guess only @edubart can answer to our questions.

[cpaybcho]

Agreed. I'm also waiting for @edubart's reply. 😃 I just wanted to post my findings here since they were similar to what you originally pointed out.