Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: suport ascii mode #81

Open
bretagne-peiqi opened this issue Sep 23, 2019 · 3 comments
Open

Enhancement: suport ascii mode #81

bretagne-peiqi opened this issue Sep 23, 2019 · 3 comments

Comments

@bretagne-peiqi
Copy link

I am interested in adding ascii mode support for device-modbus-go.

If it is helpful for our project. I am going to make a pull request. Thanks.

@cloudxxx8
Copy link
Member

@bretagne-peiqi is there any standard way to intepret ascii in Modbus?

@bretagne-peiqi
Copy link
Author

bretagne-peiqi commented Oct 27, 2019

Hi, thanks for your reply. What do you mean by standard way to interpret ascii mode, interpret meas decode or somethings else as the links: http://www.simplymodbus.ca/ASCII.htm

I saw you are using modbus library which implements tcp rtu&ascii modes.
for the driver part (device service), I have not seen different processes for these three modes.

we are interested in this, waiting from your response :)

@cloudxxx8
Copy link
Member

@bretagne-peiqi Thanks, you are right. It's in the standard. Please feel free to open a PR in master branch, and we will help review the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants