Skip to content

Add DIR_TRANS API tests#371

Open
samhatfield wants to merge 6 commits intodevelopfrom
feat/add_dir_trans_tests
Open

Add DIR_TRANS API tests#371
samhatfield wants to merge 6 commits intodevelopfrom
feat/add_dir_trans_tests

Conversation

@samhatfield
Copy link
Collaborator

Adds the following API tests for DIR_TRANS:

  • ectrans_test_trans_api_dir_trans_call_mode_1_scalar_1
  • ectrans_test_trans_api_dir_trans_call_mode_1_wind_1
  • ectrans_test_trans_api_dir_trans_call_mode_1_wind_1_scalar_1
  • ectrans_test_trans_api_dir_trans_call_mode_2_pgp3a_1
  • ectrans_test_trans_api_dir_trans_call_mode_2_pgp3b_1
  • ectrans_test_trans_api_dir_trans_call_mode_2_wind_1

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new API test suite covering the DIR_TRANS entry point across multiple call modes/configurations, and wires it into the existing API-test CMake infrastructure.

Changes:

  • Introduces DIR_TRANS API tests (scalar, wind, mixed; call modes 1 and 2) in a new Fortran test suite module.
  • Adds a dir_trans API test CMake target list and registers it with the top-level tests/trans/api CMake.
  • Expands the API test matrix to run these tests across configured MPIxOMP combinations and backends.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.

File Description
tests/trans/api/dir_trans/dir_trans_test_suite.F90 New Fortran API tests validating basic DIR_TRANS behavior for scalar and wind fields.
tests/trans/api/dir_trans/CMakeLists.txt New CMake definition to generate/register the DIR_TRANS API test suite across backends and MPI/OMP configs.
tests/trans/api/CMakeLists.txt Adds the dir_trans subdirectory so the new suite is built and executed.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@samhatfield samhatfield force-pushed the feat/add_dir_trans_tests branch from 4fb942f to 2fe4220 Compare February 26, 2026 15:59
@samhatfield samhatfield force-pushed the feat/add_dir_trans_tests branch from 965950c to a457ddb Compare March 6, 2026 08:49
samhatfield and others added 6 commits March 9, 2026 15:11
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Willem Deconinck <willem.deconinck@ecmwf.int>
@samhatfield samhatfield force-pushed the feat/add_dir_trans_tests branch from a457ddb to ff95f08 Compare March 11, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants