Skip to content
CI

Adding exception type for empty callback functions (reopening of PR #301) #900

Sign in to view logs

Adding exception type for empty callback functions (reopening of PR #301)

Adding exception type for empty callback functions (reopening of PR #301) #900

Re-run triggered February 20, 2025 23:43
@PLeVasseurPLeVasseur
#304
lukas-he:bugfix/1.0.2/194-std-function-checks
Status Failure
Total duration 6m 8s
Artifacts 8

ci.yml

on: pull_request
Build up-cpp and dependencies
1m 18s
Build up-cpp and dependencies
Run up-cpp tests
12s
Run up-cpp tests
Run Valgrind Memcheck
3m 33s
Run Valgrind Memcheck
Run Valgrind ThreadCheck
4m 23s
Run Valgrind ThreadCheck
Run Valgrind Helgrind
3m 22s
Run Valgrind Helgrind
Run Valgrind DHAT
3m 4s
Run Valgrind DHAT
Lint C++ sources
45s
Lint C++ sources
CI status checks
0s
CI status checks
Fit to window
Zoom out
Zoom in

Annotations

4 errors and 10 warnings
test/coverage/communication/NotificationSinkTest.cpp:12:10 [clang-diagnostic-error]: test/coverage/communication/NotificationSinkTest.cpp#L12
'google/protobuf/util/message_differencer.h' file not found
test/coverage/communication/SubscriberTest.cpp:12:10 [clang-diagnostic-error]: test/coverage/communication/SubscriberTest.cpp#L12
'google/protobuf/util/message_differencer.h' file not found
test/coverage/utils/CallbackConnectionTest.cpp:12:10 [clang-diagnostic-error]: test/coverage/utils/CallbackConnectionTest.cpp#L12
'gtest/gtest.h' file not found
Lint C++ sources
Process completed with exit code 1.
include/up-cpp/utils/CallbackConnection.h:17:1 [misc-include-cleaner]: include/up-cpp/utils/CallbackConnection.h#L17
included header cstdint is not used directly
include/up-cpp/utils/CallbackConnection.h:88:29 [misc-include-cleaner]: include/up-cpp/utils/CallbackConnection.h#L88
no header providing "std::tuple" is directly included
include/up-cpp/utils/CallbackConnection.h:196:64 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L196
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:233:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L233
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:245:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L245
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:260:51 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L260
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:336:2 [modernize-use-nodiscard]: include/up-cpp/utils/CallbackConnection.h#L336
function 'isConnected' should be marked [[nodiscard]]
include/up-cpp/utils/CallbackConnection.h:354:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L354
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:367:51 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L367
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:393:2 [modernize-use-nodiscard]: include/up-cpp/utils/CallbackConnection.h#L393
function 'isConnected' should be marked [[nodiscard]]

Artifacts

Produced during runtime
Name Size Digest
build-artifacts Expired
34.8 MB
sha256:4d2d1601d63692464d483ec1d736720c00e1705780c0c6c7856fb13925599de1
compile-commands Expired
1.81 KB
sha256:312279c0d4a158a20e48f183c678ab34d526293a079c7da8e0d1a92824fcb01d
conan-cache Expired
1.85 MB
sha256:846216fe6cfb9a42b5454c0ead9470d70357a418745fa221cfedc8afe33fb10f
test-results Expired
126 KB
sha256:5579e3da3a2eb37ac9359f5367be7b387966f481dfc78b08795411679e90e322
valgrind-dhat-log Expired
2.93 KB
sha256:889cc532b39cd20c3709703caa2c2bad4501c49903cd14f1bf312d7ec0975cd3
valgrind-helgrind-log Expired
14.6 KB
sha256:deb20c410087708854a362b0a21c9fa6af4f21379c68913bf4169bae2a377a6b
valgrind-memcheck-log Expired
123 KB
sha256:0b74bbf00939c0046916338c3b897b79501ab6bdbe4729b80a472eae519cee49
valgrind-threadcheck-log Expired
13.7 KB
sha256:c5ab140a42c1651994112f11a07cb195337a83c71f35fdf405b62825c0d3870b