Skip to content
CI

Adding exception type for empty callback functions (reopening of PR #301) #899

Sign in to view logs

Adding exception type for empty callback functions (reopening of PR #301)

Adding exception type for empty callback functions (reopening of PR #301) #899

Re-run triggered February 14, 2025 01:35
@gregmeddgregmedd
#304
lukas-he:bugfix/1.0.2/194-std-function-checks
Status Failure
Total duration 5m 36s
Artifacts 8

ci.yml

on: pull_request
Build up-cpp and dependencies
1m 14s
Build up-cpp and dependencies
Run up-cpp tests
13s
Run up-cpp tests
Run Valgrind Memcheck
3m 26s
Run Valgrind Memcheck
Run Valgrind ThreadCheck
3m 51s
Run Valgrind ThreadCheck
Run Valgrind Helgrind
3m 53s
Run Valgrind Helgrind
Run Valgrind DHAT
2m 55s
Run Valgrind DHAT
Lint C++ sources
38s
Lint C++ sources
CI status checks
0s
CI status checks
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 9 warnings
Lint C++ sources
Process completed with exit code 100.
Lint C++ sources
Process completed with exit code 1.
include/up-cpp/utils/CallbackConnection.h:196:64 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L196
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:233:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L233
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:245:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L245
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:260:51 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L260
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:336:2 [modernize-use-nodiscard]: include/up-cpp/utils/CallbackConnection.h#L336
function 'isConnected' should be marked [[nodiscard]]
include/up-cpp/utils/CallbackConnection.h:354:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L354
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:367:51 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L367
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:393:2 [modernize-use-nodiscard]: include/up-cpp/utils/CallbackConnection.h#L393
function 'isConnected' should be marked [[nodiscard]]
include/up-cpp/utils/CallbackConnection.h:443:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L443
'operator optional<type-parameter-0-0> &&' must be marked explicit to avoid unintentional implicit conversions

Artifacts

Produced during runtime
Name Size Digest
build-artifacts Expired
34.8 MB
sha256:c6724ba8a3d74b849455f8e07a2567248f66d5ce6c1e5556e18adcf4fde17e72
compile-commands Expired
1.81 KB
sha256:6a97d17dba5332d25391da89bc7d08e2203f04e440b1e676ffc9376616fb0f9b
conan-cache Expired
1.85 MB
sha256:b0733c229347ce6788c57d368491db7f1335171a21ba499359b8f6eb9a4a1616
test-results Expired
126 KB
sha256:5a0dbe1a0353fe09245b9733d9882931db29240b7efc90305721e7450d5d68a5
valgrind-dhat-log Expired
2.89 KB
sha256:90c16abff70b999efdf8d1dab01c08c6b90015c6628beefbb2fc4e21a39cec9e
valgrind-helgrind-log Expired
14.6 KB
sha256:2b1e246f53fc992fffc137b30b9c79ead809f46879684a9f744044961714f59d
valgrind-memcheck-log Expired
88.9 KB
sha256:8400216a2fe2a4acccc67978ee137593cc930bf74e14ef8db3998917e0560639
valgrind-threadcheck-log Expired
13.6 KB
sha256:181a6e85e44e192405fdc60f03c8e2e88a988c34ae06bd00175fb64ee84a3860