Skip to content
CI

Adding exception type for empty callback functions (reopening of PR #301) #898

Sign in to view logs

Adding exception type for empty callback functions (reopening of PR #301)

Adding exception type for empty callback functions (reopening of PR #301) #898

Re-run triggered February 13, 2025 13:54
@PLeVasseurPLeVasseur
#304
lukas-he:bugfix/1.0.2/194-std-function-checks
Status Failure
Total duration 5m 27s
Artifacts 8

ci.yml

on: pull_request
Build up-cpp and dependencies
1m 32s
Build up-cpp and dependencies
Run up-cpp tests
6s
Run up-cpp tests
Run Valgrind Memcheck
3m 23s
Run Valgrind Memcheck
Run Valgrind ThreadCheck
3m 21s
Run Valgrind ThreadCheck
Run Valgrind Helgrind
3m 24s
Run Valgrind Helgrind
Run Valgrind DHAT
2m 57s
Run Valgrind DHAT
Lint C++ sources
37s
Lint C++ sources
CI status checks
0s
CI status checks
Fit to window
Zoom out
Zoom in

Annotations

2 errors and 9 warnings
Lint C++ sources
Process completed with exit code 100.
Lint C++ sources
Process completed with exit code 1.
include/up-cpp/utils/CallbackConnection.h:196:64 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L196
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:233:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L233
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:245:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L245
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:260:51 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L260
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:336:2 [modernize-use-nodiscard]: include/up-cpp/utils/CallbackConnection.h#L336
function 'isConnected' should be marked [[nodiscard]]
include/up-cpp/utils/CallbackConnection.h:354:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L354
constructors that are callable with a single argument must be marked explicit to avoid unintentional implicit conversions
include/up-cpp/utils/CallbackConnection.h:367:51 [readability-named-parameter]: include/up-cpp/utils/CallbackConnection.h#L367
all parameters should be named in a function
include/up-cpp/utils/CallbackConnection.h:393:2 [modernize-use-nodiscard]: include/up-cpp/utils/CallbackConnection.h#L393
function 'isConnected' should be marked [[nodiscard]]
include/up-cpp/utils/CallbackConnection.h:443:2 [google-explicit-constructor]: include/up-cpp/utils/CallbackConnection.h#L443
'operator optional<type-parameter-0-0> &&' must be marked explicit to avoid unintentional implicit conversions

Artifacts

Produced during runtime
Name Size Digest
build-artifacts Expired
34.8 MB
sha256:6cea459cba2e26cdb8d0ce9711985b59ec0764c6715a618c4689d272f151d83f
compile-commands Expired
1.81 KB
sha256:4faefe91e1406da9cc938109f9aa05410ad8d48a570bc121ac4465994ea0a26a
conan-cache Expired
1.85 MB
sha256:c37dbaad72ed260271cc5b8244f14d99708513d00218720310c05e02e22fed41
test-results Expired
126 KB
sha256:faab62430631b13a20a8a57f92b81a9df1bc25182ea726ae8defeb9a813eb031
valgrind-dhat-log Expired
3.47 KB
sha256:7ad5ae4324cab4d35238ea893798cffe3202cb236154c74d810b1d2951168cb4
valgrind-helgrind-log Expired
15 KB
sha256:bf0756dac03e05339134e5674d982106de6247510368783dc3d374eadce41fd8
valgrind-memcheck-log Expired
88.9 KB
sha256:536122dd23055557f7776b0dc5720537de297e204726f89cba696565e75e77dd
valgrind-threadcheck-log Expired
13.9 KB
sha256:e8464c3d917bdd1fb2c1bd7df8ee0bc7db081d4268c8177abe219b8291419481