Merge pull request #1440 from danielpeintner/issue-1430-typescript-eslint-prefer-nullish-coalescing

refactor: activate eslint typescript-eslint/prefer-nullish-coalescing

Author: relu91

eslint.config.mjs

@@ -122,7 +122,7 @@ export default defineConfig([
             "@typescript-eslint/no-unused-vars": "off",
             "@typescript-eslint/no-unused-expressions": "off",
             "@typescript-eslint/no-require-imports": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
-            "@typescript-eslint/prefer-nullish-coalescing": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
+            "@typescript-eslint/prefer-nullish-coalescing": "error",
             "@typescript-eslint/no-empty-object-type": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
             "@typescript-eslint/no-floating-promises": "off", // https://github.com/eclipse-thingweb/node-wot/issues/1430
 

packages/binding-coap/src/coap-server.ts

@@ -201,9 +201,7 @@ export default class CoapServer implements ProtocolServer {
             return;
         }
 
-        if (thing.forms == null) {
-            thing.forms = [];
-        }
+        thing.forms ??= [];
 
         const form = this.createAffordanceForm(base, this.PROPERTY_DIR, offeredMediaType, opValues, thing.uriVariables);
 

packages/binding-http/src/http-client-impl.ts

@@ -356,7 +356,7 @@ export default class HttpClient implements ProtocolClient {
 
         const url = HttpClient.fixLocalhostName(form.href);
 
-        requestInit.method = form["htv:methodName"] ? form["htv:methodName"] : defaultMethod;
+        requestInit.method = form["htv:methodName"] ?? defaultMethod;
 
         requestInit.headers = requestInit.headers ?? [];
         requestInit.headers = requestInit.headers as string[][];

packages/binding-http/src/http-server.ts

@@ -369,9 +369,7 @@ export default class HttpServer implements ProtocolServer {
                         "writemultipleproperties",
                     ];
                 }
-                if (thing.forms == null) {
-                    thing.forms = [];
-                }
+                thing.forms ??= [];
                 thing.forms.push(form);
                 this.addUrlRewriteEndpoints(form, thing.forms);
             }

packages/binding-modbus/src/modbus-client.ts

@@ -39,11 +39,9 @@ class ModbusSubscription {
         error?: (error: Error) => void,
         complete?: () => void
     ) {
-        if (!complete) {
-            complete = () => {
-                // do nothing.
-            };
-        }
+        complete ??= () => {
+            // do nothing.
+        };
         this.interval = global.setInterval(async () => {
             try {
                 const result = await client.readResource(form);

packages/binding-opcua/src/opcua-protocol-client.ts

@@ -257,9 +257,7 @@ export class OPCUAProtocolClient implements ProtocolClient {
 
     private async _getNamespaceArray(form: OPCUAForm): Promise<string[]> {
         return this._withConnection(form, async (c: OPCUAConnection) => {
-            if (!c.namespaceArray) {
-                c.namespaceArray = await readNamespaceArray(c.session);
-            }
+            c.namespaceArray ??= await readNamespaceArray(c.session);
             return c.namespaceArray;
         });
     }