Skip to content

Commit 9580b85

Browse files
GH-4592 Reenable geosparql junit testing.
Allow for non DAWG approved tests to run. Adds a manifest-all.ttl file for geosparql like sparql 1.1. compliance. Also remove some unused imports. Signed-off-by: Jerven Bolleman <[email protected]>
1 parent 166890e commit 9580b85

File tree

3 files changed

+19
-7
lines changed

3 files changed

+19
-7
lines changed

testsuites/geosparql/src/main/java/org/eclipse/rdf4j/testsuite/query/algebra/geosparql/GeoSPARQLManifestTest.java

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,10 +14,12 @@
1414

1515
import org.eclipse.rdf4j.testsuite.query.parser.sparql.manifest.SPARQLQueryComplianceTest;
1616
import org.junit.jupiter.api.DynamicTest;
17+
import org.junit.jupiter.api.TestFactory;
1718

1819
public abstract class GeoSPARQLManifestTest extends SPARQLQueryComplianceTest {
1920

21+
@TestFactory
2022
public Collection<DynamicTest> tests() {
21-
return getTestData("testcases-geosparql/functions/manifest.ttl");
23+
return getTestData("testcases-geosparql/manifest-all.ttl", false);
2224
}
2325
}
Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,10 @@
1+
@prefix rdf: <http://www.w3.org/1999/02/22-rdf-syntax-ns#> .
2+
@prefix rdfs: <http://www.w3.org/2000/01/rdf-schema#> .
3+
@prefix mf: <http://www.w3.org/2001/sw/DataAccess/tests/test-manifest#> .
4+
@prefix qt: <http://www.w3.org/2001/sw/DataAccess/tests/test-query#> .
5+
6+
<> rdf:type mf:Manifest ;
7+
rdfs:label "GeoSPARQL Evaluation tests" ;
8+
mf:include (
9+
<functions/manifest.ttl>
10+
).

testsuites/sparql/src/main/java/org/eclipse/rdf4j/testsuite/query/parser/sparql/manifest/SPARQLQueryComplianceTest.java

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@
1717
import java.io.IOException;
1818
import java.io.InputStream;
1919
import java.io.InputStreamReader;
20-
import java.io.StringWriter;
2120
import java.net.URL;
2221
import java.nio.charset.StandardCharsets;
2322
import java.util.ArrayDeque;
@@ -28,7 +27,6 @@
2827
import java.util.List;
2928
import java.util.Optional;
3029
import java.util.Set;
31-
import java.util.stream.Collectors;
3230

3331
import org.apache.commons.lang3.StringUtils;
3432
import org.eclipse.rdf4j.common.io.IOUtil;
@@ -57,7 +55,6 @@
5755
import org.eclipse.rdf4j.query.resultio.TupleQueryResultParser;
5856
import org.eclipse.rdf4j.repository.Repository;
5957
import org.eclipse.rdf4j.repository.RepositoryConnection;
60-
import org.eclipse.rdf4j.repository.RepositoryResult;
6158
import org.eclipse.rdf4j.repository.sail.SailRepository;
6259
import org.eclipse.rdf4j.repository.sail.SailRepositoryConnection;
6360
import org.eclipse.rdf4j.rio.RDFFormat;
@@ -518,14 +515,17 @@ public List<String> getSubManifests() {
518515
public abstract Collection<DynamicTest> tests();
519516

520517
public Collection<DynamicTest> getTestData(String manifestResource) {
518+
return getTestData(manifestResource, true);
519+
}
520+
521+
public Collection<DynamicTest> getTestData(String manifestResource, boolean approvedOnly) {
521522
List<DynamicTest> tests = new ArrayList<>();
522523

523524
Deque<String> manifests = new ArrayDeque<>();
524-
manifests.add(
525-
SPARQL11UpdateComplianceTest.class.getClassLoader().getResource(manifestResource).toExternalForm());
525+
manifests.add(this.getClass().getClassLoader().getResource(manifestResource).toExternalForm());
526526
while (!manifests.isEmpty()) {
527527
String pop = manifests.pop();
528-
SPARQLQueryTestManifest manifest = new SPARQLQueryTestManifest(pop, excludedSubdirs);
528+
SPARQLQueryTestManifest manifest = new SPARQLQueryTestManifest(pop, excludedSubdirs, approvedOnly);
529529
tests.addAll(manifest.tests);
530530
manifests.addAll(manifest.subManifests);
531531
}

0 commit comments

Comments
 (0)