feat(auth) - support aws sdk v2 for registry auth #3806
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Eclipse JKube CI ReportStarted new GH workflow run for #3806 (2025-12-05T15:19:13Z) ⚙️ JKube E2E Tests (19933929469)
|
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3806 +/- ##
=============================================
+ Coverage 59.36% 72.13% +12.77%
- Complexity 4586 4845 +259
=============================================
Files 500 492 -8
Lines 21211 19259 -1952
Branches 2830 2569 -261
=============================================
+ Hits 12591 13892 +1301
+ Misses 7370 4160 -3210
+ Partials 1250 1207 -43 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Since we don't have access to a real AWS instance, we might be able to leverage https://github.com/localstack/localstack to ensure the changes are working |
Contributor
Author
|
Tested the AWS SDK v2 with localstack, works fines. Attaching screenshots: 
|
ash-thakur-rh
requested review from
manusa,
rohanKanojia and
sunix
as code owners
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3732
Adds AWS SDK v2 support for ECR authentication while maintaining backward compatibility with AWS SDK v1.
Changes
1. AWS SDK v2 Support
New Architecture:
AbstractAwsSdkHelper- Abstract base class with common AWS credential handling logicAwsSdkHelperV1- AWS SDK v1 implementationAwsSdkHelperV2- AWS SDK v2 implementationAwsSdkAuthHelperinterface - Contract for SDK version abstractionKey Features:
AWS_ACCESS_KEY_ID,AWS_SECRET_ACCESS_KEY,AWS_SESSION_TOKEN)AWS_CONTAINER_CREDENTIALS_RELATIVE_URI)2. LocalStack Support & Error Handling
LocalStack Registry Support for development and testing:
*.dkr.ecr.*.localhost.localstack.cloud:PORTAWS_ENDPOINT_URLenvironment variable support for custom ECR endpoints. If set, uses custom ECR instead of real ECR for signing requestsEnhanced Error Messages:
AWS authentication failure. Status: 400, Response: {"__type": "AccessDeniedException", "message": "User: arn:aws:iam::000000000000:user/ash is not authorized to perform: ecr:GetAuthorizationToken..."}
Fully backward compatible
Type of change
test, version modification, documentation, etc.)
Checklist