[#957] Handle empty SANITIZER string

Signed-off-by: Ziad Mostafa <[email protected]>

Author: zmostafa

iceoryx2-cmake-modules/modules/Iceoryx2CommonOptionsAndParams.cmake

@@ -31,8 +31,7 @@ if(NOT ICEORYX2_COMMON_OPTIONS_AND_PARAMS_LISTED)
 
     add_param(
         NAME SANITIZERS
-        TYPE STRING
-        DESCRIPTION "Sanitizer configuration: 'address', 'ub', 'address;ub', or 'thread'"
+        DESCRIPTION "Sanitizer configuration: 'address', 'ub', 'address;ub', 'thread', or empty string (disabled)"
         DEFAULT_VALUE ""
     )
 

iceoryx2-cmake-modules/modules/Iceoryx2OptionAndParamMacros.cmake

@@ -20,7 +20,7 @@ endmacro()
 macro(add_param)
     set(ONE_VALUE_ARGS NAME DESCRIPTION DEFAULT_VALUE)
     cmake_parse_arguments(ADD_PARAM "" "${ONE_VALUE_ARGS}" "" ${ARGN})
-    if(NOT ${ADD_PARAM_NAME})
+    if(NOT DEFINED ${ADD_PARAM_NAME})
         set(${ADD_PARAM_NAME} ${ADD_PARAM_DEFAULT_VALUE})
     endif()
     message(STATUS "  ${ADD_PARAM_NAME}: ${${ADD_PARAM_NAME}} (Description: ${ADD_PARAM_DESCRIPTION})")

iceoryx2-cmake-modules/modules/Iceoryx2Sanitizer.cmake

@@ -13,14 +13,16 @@
 # Parse SANITIZERS string and set appropriate flags
 set(ICEORYX2_SANITZER_FLAGS "" CACHE INTERNAL "")
 
-if(SANITIZERS STREQUAL "address")
+if(SANITIZERS STREQUAL "")
+    # No sanitizers enabled - empty string is the default
+elseif(SANITIZERS STREQUAL "address")
     set(ICEORYX2_SANITZER_FLAGS -fsanitize=address CACHE INTERNAL "")
 elseif(SANITIZERS STREQUAL "ub")
     set(ICEORYX2_SANITZER_FLAGS -fsanitize=undefined CACHE INTERNAL "")
 elseif(SANITIZERS STREQUAL "address;ub")
     set(ICEORYX2_SANITZER_FLAGS -fsanitize=address -fsanitize=undefined CACHE INTERNAL "")
 elseif(SANITIZERS STREQUAL "thread")
     set(ICEORYX2_SANITZER_FLAGS -fsanitize=thread CACHE INTERNAL "")
-elseif(NOT SANITIZERS STREQUAL "")
-    message(FATAL_ERROR "Invalid SANITIZERS value: '${SANITIZERS}'. Valid options are: 'address', 'ub', 'address;ub', or 'thread'")
+else()
+    message(FATAL_ERROR "Invalid SANITIZERS value: '${SANITIZERS}'. Valid options are: 'address', 'ub', 'address;ub', 'thread', or empty string (disabled)")
 endif()