Skip to content

Updated Grizzly dependencies - fixed jpms - #6093

Merged
dmatej merged 3 commits into
eclipse-ee4j:5.0from
dmatej:fix-grizzly-dependencies
Jun 9, 2026
Merged

dmatej merged 3 commits into
eclipse-ee4j:5.0from
dmatej:fix-grizzly-dependencies

Conversation

@dmatej

@dmatej dmatej commented Jun 9, 2026 •

Copy link
Copy Markdown
Contributor

Grizzly NPN API 2.0.0 used just automatic module name and did not declare any module-info.java. 2.0.1 fixed that.

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej dmatej added this to the 5.0.0 milestone Jun 9, 2026
@dmatej
dmatej requested a review from a team June 9, 2026 19:45
dmatej added 2 commits June 9, 2026 21:52
- M1 depended on snapshot parent

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
- M1 depended on snapshot parent

Signed-off-by: David Matějček <david.matejcek@omnifish.ee>
@dmatej
dmatej merged commit 1b4247c into eclipse-ee4j:5.0 Jun 9, 2026
5 checks passed
@dmatej
dmatej deleted the fix-grizzly-dependencies branch June 9, 2026 20:15
@mkarg

mkarg commented Jun 9, 2026

Copy link
Copy Markdown
Member

@dmatej Thank you for this contribution. As I am a new committer on Jersey I have one question. Do we typically just merge directly our own commits without waiting for any review comments of other committers?

@arjantijms

Copy link
Copy Markdown
Contributor

Yes indeed. Of course after commit checking and reviews are still appreciated, and we can do new commits to fix anything if needed then.

@dmatej

dmatej commented Oct 3, 2026

Copy link
Copy Markdown
Contributor Author

@dmatej Thank you for this contribution. As I am a new committer on Jersey I have one question. Do we typically just merge directly our own commits without waiting for any review comments of other committers?

Some branches are protected, some not, I don't like it too much, but when the problem is clear and well tested, I can do that from time to time.

In general, Automated module names cause more problems that they resolve, and historically were just a temporary solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants