Skip to content

Conversation

@jonahgraham
Copy link
Member

@jonahgraham jonahgraham commented Oct 31, 2025

BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.

Includes a parent commit that deletes an unused method that interfered with the resolution of assertEquals when statically imported.

Part of #1380

With the move to JUnit5 any assertEquals methods declared in source files
cause problems with resolution.
BaseTestFramework is the base class for a hierarchy of tests and
all those test updates are included in this commit.
@jonahgraham jonahgraham added the junit5 JUnit5 conversion effort label Oct 31, 2025
@github-actions
Copy link

github-actions bot commented Oct 31, 2025

Test Results

  584 files   -   1    584 suites   - 1   13m 8s ⏱️ -38s
9 444 tests  - 473  9 420 ✅  - 473  24 💤 ±0  0 ❌ ±0 
9 471 runs   - 484  9 447 ✅  - 484  24 💤 ±0  0 ❌ ±0 

Results for commit 9d78040. ± Comparison against base commit 6574af3.

This pull request removes 595 and adds 122 tests. Note that renamed tests count towards both.
CommentHandlingTest ClassCommentTest ‑ Unknown test
CommentHandlingTest CommentHandlingTest 1 - von CERP ‑ Unknown test
CommentHandlingTest CommentHandlingTest 2 - von CERP ‑ Unknown test
CommentHandlingTest CommentHandlingTest 3 - von CERP ‑ Unknown test
CommentHandlingTest CommentHandlingTest 4 - von CERP ‑ Unknown test
CommentHandlingTest CommentRecognition Bug 233438 ‑ Unknown test
CommentHandlingTest CommentRecognition Bug 234786 ‑ Unknown test
CommentHandlingTest CommentRecognition comment in empty compound statement width include guard ‑ Unknown test
CommentHandlingTest CommentRecognition preprocessor directives comment recognition ‑ Unknown test
CommentHandlingTest CommentRecognition0 ‑ Unknown test
…
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[100] CommentRecognition205 - von ASTWriter IfStatement
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[101] CommentRecognition206 - von ASTWriter SwitchStatement
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[102] CommentRecognition207 - von ASTWriter WhileStatement
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[103] CommentRecognition208 - von ASTWriter ExplicitTemplateInstantiationStatement
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[104] CommentRecognition209 - von ASTWriter GPPExplicitTemplateInstantitation
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[105] CommentRecognition210 - von ASTWriter LinkageSpecification
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[106] CommentRecognition212 - von ASTWriter TemplateFunction
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[107] CommentRecognition213 - von ASTWriter DeclarationWithTraillingDoubleComments
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[108] CommentRecognition214 - von ASTWriter NamesapceDefinition
org.eclipse.cdt.core.parser.tests.rewrite.comenthandler.CommentHandlingTest ‑ test(List)[109] CommentRecognition215 - von ASTWriter NamesapceDefinition
…

♻️ This comment has been updated with latest results.

@jonahgraham
Copy link
Member Author

jonahgraham commented Nov 1, 2025

ExpressionWriterTest was being run twice before this commit because it was discovered on its own and added to another suite here:

This accounts for 11 of the reduced runs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

junit5 JUnit5 conversion effort

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants