-
Notifications
You must be signed in to change notification settings - Fork 216
Convert org.eclipse.cdt.core.tests.BaseTestFramework to JUnit5 #1379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
With the move to JUnit5 any assertEquals methods declared in source files cause problems with resolution.
BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.
Test Results 584 files - 1 584 suites - 1 13m 8s ⏱️ -38s Results for commit 9d78040. ± Comparison against base commit 6574af3. This pull request removes 595 and adds 122 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
|
ExpressionWriterTest was being run twice before this commit because it was discovered on its own and added to another suite here: Line 90 in a8b3401
This accounts for 11 of the reduced runs |
BaseTestFramework is the base class for a hierarchy of tests and all those test updates are included in this commit.
Includes a parent commit that deletes an unused method that interfered with the resolution of assertEquals when statically imported.
Part of #1380