Deduplicate bindings found both via cache and via nested bindings index

Author: i-garrison

core/org.eclipse.cdt.core/parser/org/eclipse/cdt/internal/core/pdom/PDOM.java

@@ -1414,15 +1414,15 @@ public IIndexFragmentBinding[] findBindings(char[] name, boolean filescope, Inde
 
 	public IIndexFragmentBinding[] findBindings(char[] name, boolean filescope, boolean isCaseSensitive,
 			IndexFilter filter, IProgressMonitor monitor) throws CoreException {
-		ArrayList<IIndexFragmentBinding> result = new ArrayList<>();
+		HashSet<PDOMBinding> uniqueNodes = new HashSet<>();
 		try {
 			for (PDOMLinkage linkage : getLinkageList()) {
 				if (filter.acceptLinkage(linkage)) {
 					if (isCaseSensitive) {
 						PDOMBinding[] bindings = linkage.getBindingsViaCache(name, monitor);
 						for (PDOMBinding binding : bindings) {
 							if (filter.acceptBinding(binding)) {
-								result.add(binding);
+								uniqueNodes.add(binding);
 							}
 						}
 					}
@@ -1443,14 +1443,14 @@ public IIndexFragmentBinding[] findBindings(char[] name, boolean filescope, bool
 
 						PDOMBinding[] bindings = visitor.getBindings();
 						for (PDOMBinding binding : bindings) {
-							result.add(binding);
+							uniqueNodes.add(binding);
 						}
 					}
 				}
 			}
 		} catch (OperationCanceledException e) {
 		}
-		return result.toArray(new IIndexFragmentBinding[result.size()]);
+		return uniqueNodes.toArray(new IIndexFragmentBinding[uniqueNodes.size()]);
 	}
 
 	public IIndexFragmentBinding[] findMacroContainers(char[] prefix, boolean isPrefix, boolean isCaseSensitive,