Problem with RateLimitingProgressMonitor

[snjeza]

The related issue - redhat-developer/vscode-java#4292

RateLimitingProgressMonitor is created when a tooling action is executed -

buildship/org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/internal/operation/DefaultToolingApiOperationManager.java

Line 38 in 218322a

IProgressMonitor efficientMonitor = new RateLimitingProgressMonitor(monitor, 500, TimeUnit.MILLISECONDS);

This monitor creates a timer that would need to be canceled in the done method.
However, the done method is never called.

Steps to reproduce:

• import spring-petclinic into Eclipse, VS Code or Cursor
• call jstack -l <jvm_process_pid>

You will see 10+ Timer threads.
They call the forwardMostRecentMessage method every 500ms - https://github.com/eclipse-buildship/buildship/blob/218322a0d994543cf0aec77def05e6feeddd4b95/org.eclipse.buildship.core/src/main/java/org/eclipse/buildship/core/internal/util/progress/RateLimitingProgressMonitor.java#L66C23-L66C47

[kcnklub]

I am using jdtls within my nvim configuration and I found this issue as well. When opening large projects like junit-framework the my CPU was spiking in weird ways. When inspecting I saw that there was over 10k threads for jdtls process which using buildship.

Looking at the linked #1359 that looks to do the trick.

Another workaround that I have used for this is to add the following configuration to jdtls. This is great when not making a lot of changes to build files but it also means that if you do make changes to those file it you will have to restart jdtls to refresh the project.

configuration = {
    updateBuildConfiguration = "interactive",
}

Full config here: https://github.com/kcnklub/neovim-config/blob/main/ftplugin/java.lua#L51

Not sure how to configure in VSCode but hope it helps.

Edit: I hope the PR gets merged so then we don't need the work around. 🤞🏼