Clean up build and re-intro -Werror in CI

Author: earlephilhower

lib/platform_def.txt

@@ -45,8 +45,8 @@
 -DLIB_PICO_RUNTIME_INIT=1
 -DLIB_PICO_STANDARD_BINARY_INFO=1
 -DLIB_PICO_STANDARD_LINK=1
--DLIB_PICO_STDIO=1
--DLIB_PICO_STDIO_UART=1
+-DLIB_PICO_STDIO=0
+-DLIB_PICO_STDIO_UART=0
 -DLIB_PICO_STDLIB=1
 -DLIB_PICO_SYNC=1
 -DLIB_PICO_SYNC_CRITICAL_SECTION=1

platform.txt

@@ -47,7 +47,7 @@ compiler.warning_flags=-Werror=return-type -Wno-psabi
 compiler.warning_flags.none=-Werror=return-type -Wno-psabi
 compiler.warning_flags.default=-Werror=return-type -Wno-psabi
 compiler.warning_flags.more=-Wall -Werror=return-type -Wno-ignored-qualifiers -Wno-psabi
-compiler.warning_flags.all=-Wall -Wextra -Werror=return-type -Wno-psabi -Wno-type-limits -Wno-unused-parameter
+compiler.warning_flags.all=-Wall -Wextra -Werror=return-type -Wno-psabi -Wno-type-limits -Wno-unused-parameter -Wno-missing-field-initializers
 
 compiler.netdefines={build.libpicowdefs} -DLWIP_IGMP=1 -DLWIP_CHECKSUM_CTRL_PER_NETIF=1
 compiler.psramdefines={build.psram_cs} {build.psram_freq}

tests/common.sh

@@ -234,8 +234,8 @@ function install_ide()
         debug_flags="-DDEBUG_RP2040_WIRE -DDEBUG_RP2040_SPI -DDEBUG_RP2040_CORE -DDEBUG_RP2040_PORT=Serial"
     fi
     # Set custom warnings for all builds (i.e. could add -Wextra at some point)
-    echo "compiler.c.extra_flags=-Wall -Wextra -Wno-ignored-qualifiers $debug_flags" > rp2040/platform.local.txt
-    echo "compiler.cpp.extra_flags=-Wall -Wextra -Wno-ignored-qualifiers -Wno-overloaded-virtual $debug_flags" >> rp2040/platform.local.txt
+    echo "compiler.c.extra_flags=-Wall -Wextra -Werror -Wno-ignored-qualifiers $debug_flags" > rp2040/platform.local.txt
+    echo "compiler.cpp.extra_flags=-Wall -Wextra -Werror -Wno-ignored-qualifiers -Wno-overloaded-virtual $debug_flags" >> rp2040/platform.local.txt
     echo -e "\n----platform.local.txt----"
     cat rp2040/platform.local.txt
     echo -e "\n----\n"