Skip to content

chore: allow overriding encoding for the logger#2334

Merged
jakubno merged 3 commits intomainfrom
chore/allow-overriding-encoding-for-logger
Apr 9, 2026
Merged

chore: allow overriding encoding for the logger#2334
jakubno merged 3 commits intomainfrom
chore/allow-overriding-encoding-for-logger

Conversation

@jakubno
Copy link
Copy Markdown
Member

@jakubno jakubno commented Apr 8, 2026

Allow customizing the encoder so we can reuse it in other services where the logger needs different encoder

@cursor
Copy link
Copy Markdown

cursor bot commented Apr 8, 2026

PR Summary

Medium Risk
Behavior now depends on new config fields and introduces a runtime error path for non-console encodings without an encoder config, which could impact service startup/logging if misconfigured.

Overview
Adds support for overriding Zap Encoding and EncoderConfig when building the logger, defaulting to console but now erroring if a non-console encoding is selected without an explicit encoder config (which may break existing callers that start setting Encoding without providing EncoderConfig).

Reviewed by Cursor Bugbot for commit a1f0cc3. Bugbot is set up for automated code reviews on this repo. Configure here.

@jakubno jakubno marked this pull request as ready for review April 9, 2026 07:11
@jakubno jakubno assigned sitole and unassigned arkamar Apr 9, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 566542af6b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@sitole sitole self-requested a review April 9, 2026 08:31
@jakubno jakubno force-pushed the chore/allow-overriding-encoding-for-logger branch from a1f0cc3 to 883cd89 Compare April 9, 2026 09:15
@jakubno jakubno merged commit 52904f3 into main Apr 9, 2026
81 of 82 checks passed
@jakubno jakubno deleted the chore/allow-overriding-encoding-for-logger branch April 9, 2026 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants