Skip to content

feat(dashboard-api): HTTP tracing and metrics#2320

Merged
ben-fornefeld merged 13 commits intomainfrom
dashboard-api-otel-observability
Apr 8, 2026
Merged

feat(dashboard-api): HTTP tracing and metrics#2320
ben-fornefeld merged 13 commits intomainfrom
dashboard-api-otel-observability

Conversation

@ben-fornefeld
Copy link
Copy Markdown
Member

@ben-fornefeld ben-fornefeld commented Apr 7, 2026

Summary

  • add request tracing middleware to dashboard-api so request logs inherit trace_id and span_id
  • add route-level OTEL HTTP metrics middleware for dashboard-api, excluding /health
  • align the local middleware shape with the main API service pattern so the new Grafana HTTP panels have consistent metric names and labels

Made with Cursor

Align dashboard-api request observability with the main API service so request logs carry trace context and route-level HTTP latency metrics can power Grafana panels.

Made-with: Cursor
@cursor
Copy link
Copy Markdown

cursor bot commented Apr 7, 2026

PR Summary

Medium Risk
Adds new request-level tracing/metrics and a hard request timeout to dashboard-api, which can change request cancellation behavior and metric/log labeling. Also upgrades core dependencies (notably gin and OpenTelemetry) across several services, which may introduce subtle runtime/compatibility regressions.

Overview
Adds OpenTelemetry HTTP tracing and route-level metrics to dashboard-api (excluding /health) so logs inherit trace/span IDs and metrics align with the main API’s naming/labels, and enforces a RequestTimeout middleware for long-running requests. Across services, bumps gin to v1.12.0 and updates OpenTelemetry and related transitive deps, plus switches API services to use shared OTEL middleware packages instead of service-local ones.

Reviewed by Cursor Bugbot for commit 6ac100f. Bugbot is set up for automated code reviews on this repo. Configure here.

@ben-fornefeld ben-fornefeld changed the title Add dashboard-api HTTP tracing and metrics add(dashboard-api): HTTP tracing and metrics Apr 7, 2026
@ben-fornefeld ben-fornefeld changed the title add(dashboard-api): HTTP tracing and metrics feat(dashboard-api): HTTP tracing and metrics Apr 7, 2026
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a1bf03fa5c

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Copy link
Copy Markdown

@claude claude bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review comments on otel middleware.

Copy link
Copy Markdown
Contributor

@dobrac dobrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If this is the same implementation as in the API, can we please first move it to shared and reuse it here?

@ben-fornefeld ben-fornefeld assigned dobrac and unassigned ValentaTomas Apr 7, 2026
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit eea4941. Configure here.

Copy link
Copy Markdown
Contributor

@matthewlouisbrockman matthewlouisbrockman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lotta version changes, seems to still work

@ben-fornefeld ben-fornefeld requested a review from dobrac April 8, 2026 02:07
@ben-fornefeld
Copy link
Copy Markdown
Member Author

resolving all bugbot comments since i don't want to change the middleware directly in this pr. it just got shared

@ben-fornefeld ben-fornefeld merged commit 80a172a into main Apr 8, 2026
44 checks passed
@ben-fornefeld ben-fornefeld deleted the dashboard-api-otel-observability branch April 8, 2026 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants